Bug Reports (snapshot builds)
Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by tjtillman » 15 Aug 2016, 02:11
r31989
Game crashed when using Collective Effort to destroy Infectious Curse (I was also using both of the other modes of Collective Effort)
Game crashed when using Collective Effort to destroy Infectious Curse (I was also using both of the other modes of Collective Effort)
- Code: Select all
Description: [describe what you were doing when the crash occurred]
[spoiler=RuntimeException][code]
Forge Version: 1.5.56-SNAPSHOT-r31989
Operating System: Windows 10 10.0 amd64
Java Version: 1.8.0_66 Oracle Corporation
java.lang.RuntimeException: AbilityFactory : getAbility -- Infectious Curse has no SVar: TrigChoose
at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:115)
at forge.game.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:514)
at forge.game.trigger.TriggerHandler.runNonStaticTriggersForPlayer(TriggerHandler.java:371)
at forge.game.trigger.TriggerHandler.runWaitingTrigger(TriggerHandler.java:335)
at forge.game.trigger.TriggerHandler.runWaitingTriggers(TriggerHandler.java:290)
at forge.game.zone.MagicStack.unfreezeStack(MagicStack.java:167)
at forge.game.zone.MagicStack.finishResolving(MagicStack.java:580)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:528)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:976)
at forge.game.GameAction.startGame(GameAction.java:1464)
at forge.game.Match.startGame(Match.java:95)
at forge.match.HostedMatch$2.run(HostedMatch.java:220)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
[/code][/spoiler]
Re: Bug Reports (snapshot builds)
by Hanmac » 15 Aug 2016, 04:00
@tjtiklman: the problem is not the destroy spell, but the Curse one.
There is a Trigger which should not trigger, that's why it does look for a Svar which does not exist (on that side of creature)
I have a clue where the problem is (and it seems to be my fault again :/)
===
Edit: the bug is more complicated than i thought.
@others:
the problem are spells with Sub abilities, and Triggers (specially from Cards with Alternate States)
because the active triggers are cleared between the abilities.
the new triggers does want to trigger for events which should not touch them.
in this example with Collective Effort:
DestroyCreature > DestroyEnchantment > PutCounter
DestroyEnchantment on the Curse causes ChangesZone to Trigger (add to TriggerWaiting)
then the active Triggers are cleared, and now the Witch is back.
when later the TriggerWaiting are checked, it looks in activeTriggers and find the Witch. (but it should find none)
my current ideas to fix that are most likely some kind of messy patch.
i think the whole stuff with waitingTriggers and activeTriggers need to be reworked.
Like instead of just have the TriggerWaiting, we might need to have it collect the Trigger objects for which of them could be run.
with that we might not have the whole Subability Chain to cause trigger which might not happen anymore. ... or what do you guys think?
===
Edit: that and others should be fixed by r31993
now the waiting Trigger does look for the Trigger it should cause to run.
PLEASE look for if i break something with that again.
There is a Trigger which should not trigger, that's why it does look for a Svar which does not exist (on that side of creature)
I have a clue where the problem is (and it seems to be my fault again :/)
===
Edit: the bug is more complicated than i thought.
@others:
the problem are spells with Sub abilities, and Triggers (specially from Cards with Alternate States)
because the active triggers are cleared between the abilities.
the new triggers does want to trigger for events which should not touch them.
in this example with Collective Effort:
DestroyCreature > DestroyEnchantment > PutCounter
DestroyEnchantment on the Curse causes ChangesZone to Trigger (add to TriggerWaiting)
then the active Triggers are cleared, and now the Witch is back.
when later the TriggerWaiting are checked, it looks in activeTriggers and find the Witch. (but it should find none)
my current ideas to fix that are most likely some kind of messy patch.
i think the whole stuff with waitingTriggers and activeTriggers need to be reworked.
Like instead of just have the TriggerWaiting, we might need to have it collect the Trigger objects for which of them could be run.
with that we might not have the whole Subability Chain to cause trigger which might not happen anymore. ... or what do you guys think?
===
Edit: that and others should be fixed by r31993
now the waiting Trigger does look for the Trigger it should cause to run.
PLEASE look for if i break something with that again.
Re: Bug Reports (snapshot builds)
by tjtillman » 16 Aug 2016, 05:57
r31996
CPU played Rise From the Grave, taking my Wild-Field Scarecrow from the graveyard. CPU on a later turn sacrificed the scarecrow to get two lands, but on sacrifice, it triggered my Bloodbriar to get a +1/+1 counter.
CPU played Rise From the Grave, taking my Wild-Field Scarecrow from the graveyard. CPU on a later turn sacrificed the scarecrow to get two lands, but on sacrifice, it triggered my Bloodbriar to get a +1/+1 counter.
Re: Bug Reports (snapshot builds)
by Hanmac » 16 Aug 2016, 10:32
@tjtillman:
fixed it in r31997 i added another parameter for the Player, because the Card copy doesn't seems to copy the current controller.
tested it with each a Bloodbriar on both sides on the field, now only the right one should get a +1/+1 counter.
fixed it in r31997 i added another parameter for the Player, because the Card copy doesn't seems to copy the current controller.
tested it with each a Bloodbriar on both sides on the field, now only the right one should get a +1/+1 counter.
Re: Bug Reports (snapshot builds)
by friarsol » 17 Aug 2016, 00:08
I cast Supplant Form on my opponent's Ghalma's Warden. I don't have metalcraft but the AI does. The Warden is a 4/6 when it should be a 2/4. Even after the AI loses metalcraft, it's still a 4/6
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by timmermac » 17 Aug 2016, 00:49
Did you have anything else in play that could have given the Warden +2/+2?
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
Re: Bug Reports (snapshot builds)
by fmartel » 17 Aug 2016, 01:01
Description: [2 instances of Forge open on same PC, trying the Multi-player. Starting the game, hands are drawn.]
It's my fault ! I have 2 time the same human player in each window !
It's my fault ! I have 2 time the same human player in each window !
- RuntimeException | Open
- fmartel
- Posts: 281
- Joined: 31 Dec 2013, 19:27
- Location: Québec City
- Has thanked: 8 times
- Been thanked: 4 times
Re: Bug Reports (snapshot builds)
by stormcat » 17 Aug 2016, 01:39
Arc by block from Assembled Alphas to Ingenious Skaab is not displayed.
Please refer to attachment.
Please refer to attachment.
- Attachments
-
Re: Bug Reports (snapshot builds)
by tjtillman » 17 Aug 2016, 06:40
r32003
Game state as posted below (after the incident occurred). During its upkeep, CPU cast Aim High targeting its Deranged Whelp which was already in its graveyard. Aim High fizzled, but shouldn't have been able to target the Deranged Whelp on cast.
Game state as posted below (after the incident occurred). During its upkeep, CPU cast Aim High targeting its Deranged Whelp which was already in its graveyard. Aim High fizzled, but shouldn't have been able to target the Deranged Whelp on cast.
- Code: Select all
humanlife=20
ailife=18
activeplayer=ai
activephase=COMBAT_DECLARE_ATTACKERS
humancardsinhand=Tamiyo's Journal;Drownyard Behemoth
humancardsinlibrary=Plains;Forest;Clear Shot;Explosive Apparatus;Moldgraf Scavenger;Plains;Island;Geist of the Archives;Watcher in the Web;Quilled Wolf;Island;Bloodbriar;Choking Restraints;Grapple with the Past;Spontaneous Mutation;Forest;Forest;Island;Forest;Stitched Mangler;Lambholt Pacifist;Forest;Woodland Stream;Backwoods Survivalists;Altered Ego;Terrarion;Island
humancardsingraveyard=Blessed Alliance;Ingenious Skaab
humancardsinplay=Forest;Terrarion;Plains|Tapped:True;Island;Exultant Cultist;Island|Tapped:True;Drownyard Explorers;t:Clue,P:0,T:0,Cost:no cost,Types:Artifact-Clue,Keywords:,Image:c_clue6;Forest|Tapped:True;Bloodbriar|SummonSick:True
humancardsinexile=
humancardsincommand=
aicardsinhand=Woodland Patrol;Shrill Howler;Swift Spinner;Hermit of the Natterknolls
aicardsinlibrary=Highland Lake;Woodland Patrol;Cultist's Staff;Thermo-Alchemist;Mountain;Forest;Bedlam Reveler;Forest;Forest;Senseless Rage;Shrill Howler;Shrill Howler;Stensia Masquerade;Hinterland Logger;Warped Landscape;Gibbering Fiend;Forest;Uncaged Fury;Mountain;Mountain;Forest;Mountain;Cryptolith Fragment;Falkenrath Reaver;Brazen Wolves;Thermo-Alchemist;Mountain
aicardsingraveyard=Deranged Whelp;Alchemist's Greeting;Aim High
aicardsinplay=Mountain|Tapped:True;Mountain;Geier Reach Sanitarium;Forest|Tapped:True;Insatiable Gorgers|Tapped:True;Mountain
aicardsinexile=
aicardsincommand=
Re: Bug Reports (snapshot builds)
by MIC132 » 17 Aug 2016, 19:44
r32003
Could someone look into picking decks in network multiplayer EDH?
Only the host gets the correct deck, the rest gets a generated one no matter what they pick.
Could someone look into picking decks in network multiplayer EDH?
Only the host gets the correct deck, the rest gets a generated one no matter what they pick.
Last edited by MIC132 on 18 Aug 2016, 00:47, edited 1 time in total.
Re: Bug Reports (snapshot builds)
by tjtillman » 18 Aug 2016, 00:24
r32003
Not sure if this is already a known issue, but CPU had Cult of the Waxing Moon and Ulvenwald Captive, paid to transform the Ulvenwald Captive and then, before the transform ability resolved but was still on the stack, Cult of the Waxing Moon triggered several times.
Not sure if this is already a known issue, but CPU had Cult of the Waxing Moon and Ulvenwald Captive, paid to transform the Ulvenwald Captive and then, before the transform ability resolved but was still on the stack, Cult of the Waxing Moon triggered several times.
Who is online
Users browsing this forum: No registered users and 57 guests