Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by Marek14 » 14 Dec 2016, 14:47
Sapphire Charm crashes the game when cast in its first mode.
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by Agetian » 14 Dec 2016, 15:32
Hmm, I remember there was a recent issue with another card that crashed in exactly the same way (AdditionalAbility in "Execute" not being filled), Hanmac fixed it recently, but apparently there are other similar cases (e.g. Sapphire Charm) that are not fixed yet :/ Tried looking at it but couldn't figure out how to solve it, maybe Hanmac will be able to resolve this one when possible.Marek14 wrote:Sapphire Charm crashes the game when cast in its first mode.
- NullPointerException | Open
EDIT: Ok, as a mockup for a solution, I committed r32695 - it fixes the crash but it does so by filling AdditionalAbility parameters for SAs parented to Charm API. Most likely something bigger is up here: should the relevant if statement be extended somehow differently to properly account for all cases where this Execute parameter may not be filled?
P.S. Jhoira of the Ghitu Avatar crash is also fixed (r32694).
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Shadowzeny » 15 Dec 2016, 09:58
- NullPointerException | Open
- Shadowzeny
- Posts: 52
- Joined: 04 Aug 2014, 06:36
- Has thanked: 9 times
- Been thanked: 7 times
Re: Bug Reports (snapshot builds)
by Hanmac » 15 Dec 2016, 10:07
My fault, I will fix it when I am at home.Shadowzeny wrote:Batwing Brume crashes if viewed in deck editor and deck viewer.
- NullPointerException | Open
Or Agetian is faster.
Re: Bug Reports (snapshot builds)
by Agetian » 15 Dec 2016, 10:26
I fixed the crash.Hanmac wrote:My fault, I will fix it when I am at home.Shadowzeny wrote:Batwing Brume crashes if viewed in deck editor and deck viewer.
- NullPointerException | Open
Or Agetian is faster.
However, the spell description on the stack is wrong (no matter if you pay 
or 
or both types of mana, the game says "<such-and-such-player> prevents all combat damage this turn". Couldn't figure out why, there is a correct SpellDescription on the ability. :/ The card functions correctly though.- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Hanmac » 15 Dec 2016, 11:02
You need to set StackDescription with SpellDescriptionAgetian wrote:I fixed the crash.
- Agetian
Re: Bug Reports (snapshot builds)
by Agetian » 16 Dec 2016, 07:09
I have tested this in the last three days, tried almost every card with a Moved replacement event, and played a couple dozen random matches with various cards and things look fine so far. I decided to commit (r32705) to see if maybe someone else will pinpoint something that might go wrong with this. I limited my change only to "ReplaceMoved" replacement effects, which are the only ones where this matters.Agetian wrote:Hmm, OK, I might set it up on my experimental installation and play a bit with it, see how it behaves. :/Hanmac wrote:Hm I remember doing something similar before and reverting it because it did break something. But I can't remember what or if it does still happen.
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Marek14 » 16 Dec 2016, 13:57
OK, this is a weird bug and I have no idea what causes it because it arises in a complicated combo deck.
First, let's start with this deck:
The issue is this: when I click on Basking Rootwalla on the battlefield, I get the option to use its normal pump ability, but when I cancel, the Rootwalla dies for some reason.
First, let's start with this deck:
- Code: Select all
[metadata]
Name=Lizardcycling
[general]
Constructed
[main]
4 Altar of Dementia
4 Earthcraft
4 Fluctuator
4 Artificial Evolution
4 Wheel of Sun and Moon
4 Scalding Tarn
4 Misty Rainforest
4 Basking Rootwalla
4 Fabricate
4 Homing Sliver
4 Ponder
3 Steam Vents
3 Breeding Pool
4 Impulse
2 Forest
3 Island
1 Mountain
[sideboard]
The issue is this: when I click on Basking Rootwalla on the battlefield, I get the option to use its normal pump ability, but when I cancel, the Rootwalla dies for some reason.
Re: Bug Reports (snapshot builds)
by stormcat » 16 Dec 2016, 16:23
:r32708
Occur error when I cast Everflowing Chalice suspended by Delay in my upkeep without paying its mana cost.
Description: [describe what you were doing when the crash occurred]
Occur error when I cast Everflowing Chalice suspended by Delay in my upkeep without paying its mana cost.
Description: [describe what you were doing when the crash occurred]
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by Agetian » 16 Dec 2016, 18:53
Goodness gracious, that's one hell of a combo.Marek14 wrote:OK, this is a weird bug and I have no idea what causes it because it arises in a complicated combo deck.
First, let's start with this deck:Now, I found the original article (http://magic.wizards.com/en/articles/ar ... 2014-02-26) that describe how it's supposed to work. It took some tries, but I finally assembled the combo (Homing Sliver with Sliver changed to Lizard, Earthcraft, Fluctuator, Altar of Dementia, Basking Rootwalla in hand). The combo works by discarding Basking Rootwalla with Lizardcycling granted by Evolved Homing Sliver, paying only 1 mana because of Fluctuator, playing Basking Rootwalla through madness and untapping the land you used using Earthcraft and the Rootwalla. Then you sacrifice the tapped Rootwalla to Altar of Dementia, milling 1 card from opponent's library, but because of Wheel of Sun and Moon, the Rootwalla ends in your library, ready to be searched with another Lizardcycling.
- Code: Select all
[metadata]
Name=Lizardcycling
[general]
Constructed
[main]
4 Altar of Dementia
4 Earthcraft
4 Fluctuator
4 Artificial Evolution
4 Wheel of Sun and Moon
4 Scalding Tarn
4 Misty Rainforest
4 Basking Rootwalla
4 Fabricate
4 Homing Sliver
4 Ponder
3 Steam Vents
3 Breeding Pool
4 Impulse
2 Forest
3 Island
1 Mountain
[sideboard]
The issue is this: when I click on Basking Rootwalla on the battlefield, I get the option to use its normal pump ability, but when I cancel, the Rootwalla dies for some reason.
I tried recreating this but I think I failed miserably. At any rate, the returned Basking Rootwalla (after Wheel of Sun and Moon and sacrifice to Altar of Dementia and stuff, as well as the preliminary text-changing shenanigans via Artificial Evolution for Lizardcycling) allowed me to correctly use *and* cancel the pump ability of the Rootwalla while it was on the battlefield, it did not die or otherwise disappear unexpectedly from the battlefield. I'm not sure how to recreate the conditions for this... but indeed, since it deals with replacement effects, can you please check if it worked before r32705 as Hanmac suggested? If it worked there but it doesn't work now, I think I *may* have an idea how to improve my fix in r32705 to account for this case (maybe... we'll see :/ )
- Agetian
Last edited by Agetian on 16 Dec 2016, 19:04, edited 2 times in total.
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Agetian » 16 Dec 2016, 18:53
Fixed (r32709).stormcat wrote::r32708
Occur error when I cast Everflowing Chalice suspended by Delay in my upkeep without paying its mana cost.
Description: [describe what you were doing when the crash occurred]
- NullPointerException | Open
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Kclone » 16 Dec 2016, 18:54
Description: AI's turn and the game crashed. Was playing against a friends deck. Forge has crashed multiple times against this deck. My best guess is something to do with crosis charm in the deck since I've heard issues with charms. It crashed when they were on 3 mana too.
- NullPointerException | Open
Re: Bug Reports (snapshot builds)
by Agetian » 16 Dec 2016, 19:03
Most likely this has to do with some other card (since Crosis's Charm does not have a control-gaining ability), but there was a separate potential NPE for the Charm which I addressed (r32710) + I tried to address a potential NPE in ControlGainAi at the point where you're experiencing it (r32712), so hopefully things should be better now.Kclone wrote:Description: AI's turn and the game crashed. Was playing against a friends deck. Forge has crashed multiple times against this deck. My best guess is something to do with crosis charm in the deck since I've heard issues with charms. It crashed when they were on 3 mana too.
- NullPointerException | Open
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by Kclone » 16 Dec 2016, 19:15
Well he does have a lot of control-gaining abilities in the deck. Slave of bolas, control magic, nicol bolas, dragonlord silumgar. But it has crashed before the AI had mana to cast the abilities. I don't know if that matters? My best guess is actually Slave of Bolas now since I haven't seen AI ever cast it.
EDIT: I think I found where to download the new revisions (so I was a big dummy not looking hard enough)
EDIT 2: Game crashes now when match starts.
EDIT: I think I found where to download the new revisions (so I was a big dummy not looking hard enough)
EDIT 2: Game crashes now when match starts.
- NullPointerException | Open
Last edited by Kclone on 16 Dec 2016, 19:43, edited 1 time in total.
Who is online
Users browsing this forum: No registered users and 41 guests