It is currently 30 Oct 2025, 22:58
   
Text Size

Return to Ravnica Spoiler Season

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Re: Return to Ravnica Spoiler Season

Postby moomarc » 27 Sep 2012, 13:54

We must be nearing release... ArsenalNut is suddenly committing cards like crazy! Great stuff :mrgreen:
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 27 Sep 2012, 14:20

I don't have my codebase here but it looks like Rootborn Defenses is using a Pump All when it should be using the same Effect Dauntless Escort has:

A:AB$ Effect | Cost$ Sac<1/CARDNAME> | Name$ Dauntless Escort Effect | StaticAbilities$ KWPump | SpellDescription$ Creatures you control are indestructible this turn.
SVar:KWPump:Mode$ Continuous | Affected$ Creature.YouCtrl | AddHiddenKeyword$ HIDDEN Indestructible | Description$ Creatures you control are indestructible this turn.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 00:28

Ok, mtgdata is updated, so we should be able to run OracleScript on RTR cardsfolder.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 01:23

friarsol wrote:
moomarc wrote:So while I was looking for the reason why no tokens were being downloaded, I ended up coming across what's possibly the reason why blank cards are being downloaded for new sets. I added a test to check the response code for the download links and it always returns 200 which means that it thinks the url is valid. Then I came across something on StackOverflow about some sites returning 200 for any junk link. I think this is what's happening with Cardforge where you land on the homepage whenever you type a dud address. Not sure though (not my area of expertise). Anyone clued up on that side of things?
That sounds right. We can see if there's a way to not follow redirects so it forces the webserver to give us a 404 error instead of a redirect and the home page.
Looks like that's exactly what was going on. I guess cardforge is setup to redirect everything to the homepage that doesn't land somewhere with a 301. So I told the HTTP request to not follow redirects, and confirm that we have a 200 before actually trying to download. This also told me that tokens\liliana_of_the_dark_realms_effect.jpg didn't download.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby ArsenalNut » 28 Sep 2012, 02:20

friarsol wrote:Ok, mtgdata is updated, so we should be able to run OracleScript on RTR cardsfolder.
Just did. Are we good to go on merging the RTR branch back into the Trunk? If so, I'll get the merge done tonight.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 02:36

ArsenalNut wrote:
friarsol wrote:Ok, mtgdata is updated, so we should be able to run OracleScript on RTR cardsfolder.
Just did. Are we good to go on merging the RTR branch back into the Trunk? If so, I'll get the merge done tonight.
Yep that's the only thing we were waiting for. Hopefully the change I made to the downloader today will prevent the bogus pictures that people have been reporting recently.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby ArsenalNut » 28 Sep 2012, 03:05

friarsol wrote:
ArsenalNut wrote:
friarsol wrote:Ok, mtgdata is updated, so we should be able to run OracleScript on RTR cardsfolder.
Just did. Are we good to go on merging the RTR branch back into the Trunk? If so, I'll get the merge done tonight.
Yep that's the only thing we were waiting for. Hopefully the change I made to the downloader today will prevent the bogus pictures that people have been reporting recently.
Reintegration of the RTRCards branch is complete. Please make sure not to make any more commits to the RTRCards branch. I will plan to remove the branch in a couple of days.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 03:09

Just so everyone is aware of our progess:

Return to Ravnica:
Percentage implemented: 82.28%

Remaining Cards | Open
Missing (45):
Angel of Serenity
Azor's Elocutors
Azorius Charm
Call of the Conclave
Carnival Hellsteed
Chemister's Trick
Common Bond
Corpsejack Menace
Counterflux
Coursers' Accord
Cryptborn Horror
Desecration Demon
Detention Sphere
Druid's Deliverance
Epic Experiment
Essence Backlash
Firemind's Foresight
Grave Betrayal
Growing Ranks
Guild Feud
Havoc Festival
Hellhole Flailer
Hussar Patrol
Izzet Staticaster
Jarad's Orders
Korozda Guildmage
Mana Bloom
New Prahv Guildmage
Nivix Guildmage
Nivmagus Elemental
Rakdos Charm
Rakdos Ringleader
Righteous Authority
Rix Maadi Guildmage
Search Warrant
Selesnya Charm
Skymark Roc
Slaughter Games
Spawn of Rix Maadi
Sphinx of the Chimes
Sundering Growth
Tablet of the Guilds
Teleportal
Urban Burgeoning
Volatile Rig


Edit: Updating list
Last edited by friarsol on 29 Sep 2012, 13:35, edited 1 time in total.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby ArsenalNut » 28 Sep 2012, 03:29

moomarc wrote:We must be nearing release... ArsenalNut is suddenly committing cards like crazy! Great stuff :mrgreen:
Starting on the blue cards now :D

Question: what is the preference for the spell description for the overload cards?
Here's how I scripted Blustersquall
Blustersquall | Open
Name:Blustersquall
ManaCost:U
Types:Instant
Text:no text
A:SP$ Tap | Cost$ U | ValidTgts$ Creature.YouDontCtrl | TgtPrompt$ Select target creature you don't control | SpellDescription$ Tap target creature you don't control.
A:SP$ TapAll | Cost$ 3 U | ValidCards$ Creature.YouDontCtrl | ValidDescription$ each creature you don't control. | PrecostDesc$ Overload | CostDesc$ 3 U | NonBasicSpell$ True | SpellDescription$ (You may cast this spell for its overload cost. If you do, change its text by replacing all instances of "target" with "each.".)
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/blustersquall.jpg
SetInfo:RTR|Uncommon|http://magiccards.info/scans/en/rtr/30.jpg
Oracle:Tap target creature you don't control.\nOverload {3}{U} (You may cast this spell for its overload cost. If you do, change its text by replacing all instances of "target" with "each.".)
End

In the deck editor, this makes the card text read just like the print card. I used Mizzium Mortars as a template for overload but it did not follow the Oracle text for the the overload spell description.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

Re: Return to Ravnica Spoiler Season

Postby moomarc » 28 Sep 2012, 03:42

friarsol wrote:Looks like that's exactly what was going on. I guess cardforge is setup to redirect everything to the homepage that doesn't land somewhere with a 301. So I told the HTTP request to not follow redirects, and confirm that we have a 200 before actually trying to download. This also told me that tokens\liliana_of_the_dark_realms_effect.jpg didn't download.
I noticed when I was first testing yesterday that the token download list looks for her effect instead of emblem. I apparently just forgot to commit the change. Thanks for the reminder (and for getting the url check sorted obviously).
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 03:48

ArsenalNut wrote:Question: what is the preference for the spell description for the overload cards?
Here's how I scripted Blustersquall
Looks fine to me. I think Sloth might be the only other one with an opinion on the matter, but I don't see it being a big deal.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby moomarc » 28 Sep 2012, 06:36

friarsol wrote:
ArsenalNut wrote:Question: what is the preference for the spell description for the overload cards?
Here's how I scripted Blustersquall
Looks fine to me. I think Sloth might be the only other one with an opinion on the matter, but I don't see it being a big deal.
I think Sloth just followed what I did when I added the first Overload card. I used some creative license and just used the actual replacement text because I thought it just made life a tiny bit easier for the users if they don't have to think. But I'm fine with whichever way you guys decide.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Return to Ravnica Spoiler Season

Postby friarsol » 28 Sep 2012, 19:25

There's some really long hanging fruit, if any new scripters want to give it a shot before everyone else gets to them. Here are some Unleash cards that are very simple.

Unleash:
Bloodfray Giant
Carnival Hellsteed
Chaos Imps
Gore-House Chainwalker
Hellhole Flailer (check out Fling)
Spawn of Rix Maadi
Splatter Thug
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Return to Ravnica Spoiler Season

Postby ZzzzSleep » 29 Sep 2012, 00:47

More Green cards!
"Centaur's Herald" | Open
Code: Select all
Name:Centaur's Herald
ManaCost:G
Types:Creature Elf Scout
Text:no text
PT:0/1
A:AB$ Token | Cost$ 2 G Sac<1/CARDNAME> | TokenAmount$ 1 | TokenName$ Centaur | TokenTypes$ Creature,Centaur | TokenOwner$ You | TokenColors$ Green | TokenPower$ 3 | TokenToughness$ 3 | SpellDescription$ Put a 3/3 green Centaur creature token onto the battlefield.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/centaurs_herald.jpg
End
"Korozda Monitor" | Open
Code: Select all
Name:Korozda Monitor
ManaCost:2 G G
Types:Creature Lizard
Text:no text
PT:3/3
A:AB$ PutCounter | Cost$ 5 G G ExileFromGrave<1/CARDNAME> | ActivationZone$ Graveyard | ValidTgts$ Creature | CounterType$ P1P1 | CounterNum$ X | SorcerySpeed$ True | References$ X | PrecostDesc$ Scavenge | SpellDescription$ Put a number of +1/+1 counters equal to this card's power on target creature. Scavenge only as a sorcery.
SVar:X:Count$CardPower
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/korozda_monitor.jpg
End
"Rubbleback Rhino" | Open
Code: Select all
Name:Rubbleback Rhino
ManaCost:4 G
Types:Creature Rhino
Text:no text
PT:3/4
K:Hexproof
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/rubbleback_rhino.jpg
End
"Stonefare Crocodile" | Open
Code: Select all
Name:Stonefare Crocodile
ManaCost:2 G
Types:Creature Crocodile
Text:no text
PT:3/2
A:AB$ Pump | Cost$ 2 B | KW$ Lifelink | SpellDescription$ CARDNAME gets lifelink until end of turn.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/stonefare_crocodile.jpg
End
"Towering Indrik" | Open
Code: Select all
Name:Towering Indrik
ManaCost:3 G
Types:Creature Beast
Text:no text
PT:2/4
K:Reach
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/towering_indrik.jpg
End
ZzzzSleep
 
Posts: 182
Joined: 29 Oct 2010, 02:19
Has thanked: 18 times
Been thanked: 18 times

Re: Return to Ravnica Spoiler Season

Postby ArsenalNut » 30 Sep 2012, 18:04

Here's the script I came up with for Jarad's Orders
Jarad's Orders | Open
Name:Jarad's Orders
ManaCost:2 B G
Types:Sorcery
Text:no text
A:SP$ ChangeZone | Cost$ 2 B G | Origin$ Library | Destination$ Library | ChangeType$ Creature | ChangeNum$ 2 | RememberChanged$ True | SubAbility$ DBChoice | SpellDescription$ Search your library for up to two creature cards and reveal them. Put one into your hand and the other into your graveyard. Then shuffle your library.
SVar:DBChoice:DB$ TwoPiles | Defined$ You | DefinedCards$ Remembered | Separator$ You | ChosenPile$ DBHand | UnchosenPile$ DBGrave
SVar:DBHand:DB$ ChangeZone | Defined$ Remembered | Origin$ Library | Destination$ Hand
SVar:DBGrave:DB$ ChangeZone | Defined$ Remembered | Origin$ Library | Destination$ Graveyard
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/jarads_orders.jpg
End

The script works but I want to see if there so unintended consequence I am missing. Also the actual play of the card is very menu intensive.
So many cards, so little time
User avatar
ArsenalNut
 
Posts: 512
Joined: 08 Jul 2011, 03:49
Has thanked: 27 times
Been thanked: 121 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 26 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 26 users online :: 0 registered, 0 hidden and 26 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 26 guests

Login Form