UI Improvements, Round 2: Match UI

[Hellfish]

Found a slight problem, the "Always Accept/Decline" context menu does not work with the new stack. Performance-wise however, everything now feels up to the standard of the old UI (Or possibly even better, it's a little hard to tell)

Also, the Burning Vengeance deck I was talking about is the one I posted here: viewtopic.php?f=48&t=5696

EDIT: Also a minor niggle; When I hover over a card and press Ctrl+D to view details, the view reverts to image as soon as the mouse is moved, even if I'm still over the same card. It would be a little more user friendly if it didn't revert until the next time you hovered over a card instead.

[Sloth]

EDIT: Also a minor niggle; When I hover over a card and press Ctrl+D to view details, the view reverts to image as soon as the mouse is moved, even if I'm still over the same card. It would be a little more user friendly if it didn't revert until the next time you hovered over a card instead.

I still favor having the details and the picture visible all the time.

EDIT: Little bugs
When I click on my own library I get the message "Decklist too long for dialog" (53 cards). The opponents Hand and the libraries are still available when the developer feature is disabled.

EDIT2:
When I start a game with the new GUI and after that a game with the old GUI, I get this crash:

| Open

forge.GuiDisplay cannot be cast to forge.view.match.ViewTopLevel


Version:
Forge version SVN

OS: Windows 7 Version: 6.1 Architecture: amd64

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.ClassCastException: forge.GuiDisplay cannot be cast to forge.view.match.ViewTopLevel
at forge.view.match.ViewField.updateDetails(ViewField.java:150)
at forge.control.match.ControlField$2.update(ControlField.java:129)
at java.util.Observable.notifyObservers(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at forge.MyObservable.updateObservers(MyObservable.java:38)
at forge.GuiDisplay.addObservers(GuiDisplay.java:733)
at forge.GuiDisplay.<init>(GuiDisplay.java:165)
at forge.view.swing.OldGuiNewGame.startButtonActionPerformed(OldGuiNewGame.java:890)
at forge.view.swing.OldGuiNewGame$14.actionPerformed(OldGuiNewGame.java:635)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$000(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.awt.EventQueue$1.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.awt.EventQueue$2.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

[slapshot5]

Any progress on this?

I'll have a look into that excessive amount of repaints - that could be the problem right there.

Sorted that. How 'bout now? r12333.

Yep. Looks good. 25%, eh? Must mean you're on a quad-core. Must be nice.

-slapshot5

[slapshot5]

We need something better than a giant question mark for a player's avatar. I thought we had some kind of a "face in shadow" looking icon, but I don't see it in SVN anywhere. Perhaps moomarc can whip something up.

-slapshot5

[moomarc]

We need something better than a giant question mark for a player's avatar. I thought we had some kind of a "face in shadow" looking icon, but I don't see it in SVN anywhere. Perhaps moomarc can whip something up.

-slapshot5

I'll try put something together this evening.

[Rob Cashwalker]

"face in shadow"

Or we could just use moomarc's avatar itself.......

[moomarc]

"face in shadow"

Or we could just use moomarc's avatar itself.......

Can't say I EVER thought I'd have my face in a game

We need something better than a giant question mark for a player's avatar. I thought we had some kind of a "face in shadow" looking icon, but I don't see it in SVN anywhere. Perhaps moomarc can whip something up.

I'll try put something together this evening.

Here's one I just drew up and a slight variation on it.

[Sloth]

Here's one I just drew up and a slight variation on it.

I vote for the variation, because it doesn't look like Jace.

[moomarc]

Here's one I just drew up and a slight variation on it.

I vote for the variation, because it doesn't look like Jace.

Yip. I'd planned on the first having more colours with some red side lighting perhaps, but just didn't have the time to get that right. So I thought I'd just post those two variations for now seeing as I don't think I'll have any spare time for the next few weeks. Anyone with image editing skills can feel free to play with them

[Jaedayr]

I still favor having the details and the picture visible all the time.

I agree.

The old UI checkbox does not take effect if you then go into quest mode.

Is the player avatar the same format etc. as the quest opponent avatars? If so, is it possible to copy/rename/replace the player file with the icon of your choice? And then, is that format easily created so players could even create their own player avatars?

[slapshot5]

Is the player avatar the same format etc. as the quest opponent avatars? If so, is it possible to copy/rename/replace the player file with the icon of your choice? And then, is that format easily created so players could even create their own player avatars?

Yeah, I think it's the same. We should probably have a default image, then allow a user to put a custom image in a different directory. Ideally, we would probably have an "Import avatar pic" option so the user doesn't need to manually put anything in a directory. I was thinking about this this morning.

-slapshot5

[Doublestrike]

I still favor having the details and the picture visible all the time.

I'll be committing a new new UI incorporating this, and friarsol's suggestions, and resizable regions, in about 12 hours (assuming nothing goes wrong).

After that, I'll be attacking all the small requests generally starting from page 2 of this thread.

Re: avatar - looks good. We'll need one for the AI as well.

[Doublestrike]

We should probably have a default image, then allow a user to put a custom image in a different directory. Ideally, we would probably have an "Import avatar pic" option so the user doesn't need to manually put anything in a directory. I was thinking about this this morning.

I think it would be good in the skin, so if you're playing the rebel skin, you play as Luke against Vader, or something. The look would change depending on the skin, which is the whole idea.

EDIT

Is the player avatar the same format etc. as the quest opponent avatars? If so, is it possible to copy/rename/replace the player file with the icon of your choice? And then, is that format easily created so players could even create their own player avatars?

It shall be done.

[Doublestrike]

If I start a match in quest mode, it uses the new GUI even if I have the old GUI checkbox selected.

Fixed r12356.

When I start a game with the new GUI and after that a game with the old GUI, I get this crash:

Fixed r12357.

Also, the Burning Vengeance deck I was talking about is the one I posted here

Cheers. Will get right on it.

[slapshot5]

I still favor having the details and the picture visible all the time.

I'll be committing a new new UI incorporating this, and friarsol's suggestions, and resizable regions, in about 12 hours (assuming nothing goes wrong).

Doublestrike, I'm not sure what all this is going to look like when you check it in, but I wanted to throw something out there at this point: Some of the View boxes (like the ViewInput) look like they hang off the edge of the screen. Maybe I'm the only one this bothers, maybe not. I've tweaked a few things to the point where I think it looks much cleaner. (Some of the gaps between boxes can still be adjusted for consistency, but this shows the general idea):

-slapshot5

PS: I put the two avatars in locally. It looks pretty cool!