It is currently 14 Sep 2025, 17:47
   
Text Size

Card Contributions

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Card Contributions

Postby squee1968 » 08 Mar 2012, 01:12

Let's see if any of these will pass muster.

Code: Select all
Name:Defender en-Vec
ManaCost:3 W
Types:Creature Human Cleric
Text:no text
PT:2/4
K:Fading:4
A:AB$ PreventDamage | Cost$ SubCounter<1/FADE> | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player | Amount$ 2 | SpellDescription$ Prevent the next 2 damage that would be dealt to target creature or player this turn.
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/defender_en_vec.jpg
SetInfo:NMS|Common|http://magiccards.info/scans/ne/en/5.jpg
Oracle:Fading 4 (This creature enters the battlefield with four fade counters on it. At the beginning of your upkeep, remove a fade counter from it. If you can’t, sacrifice it.)\nRemove a fade counter from Defender en-Vec: Prevent the next 2 damage that would be dealt to target creature or player this turn.
End
Code: Select all
Name:Orim's Cure
ManaCost:1 W
Types:Instant
Text:no text
A:SP$ PreventDamage | Cost$ tapXType<1/Creature> | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player | Amount$ 4 | IsPresent$ Plains.YouCtrl | CostDesc$ If you control a Plains, | SpellDescription$ you may tap an untapped creature you control rather than pay CARDNAME's mana cost.
A:SP$ PreventDamage | Cost$ 1 W | ValidTgts$ Creature,Player | TgtPrompt$ Select target creature or player | Amount$ 4 | SpellDescription$ Prevent the next 4 damage that would be dealt to target creature or player this turn.
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/orims_cure.jpg
SetInfo:MMQ|Common|http://magiccards.info/scans/mm/en/33.jpg
Oracle:If you control a Plains, you may tap an untapped creature you control rather than pay Orim’s Cure’s mana cost.\nPrevent the next 4 damage that would be dealt to target creature or player this turn.
End
Code: Select all
Name:Samite Alchemist
ManaCost:3 W
Types:Creature Human Cleric
Text:no text
PT:0/2
A:AB$ PreventDamage | Cost$ W W T | ValidTgts$ Creature.YouCtrl | TgtPrompt$ Select target creature you control | Amount$ 4 |  SubAbility$ DBTap | SpellDescription$ Prevent the next 4 damage that would be dealt this turn to target creature you control. Tap that creature. It doesn’t untap during your next untap step.
SVar:DBTap:AB$Tap | Cost$ 0 | Defined$ Targeted | SubAbility$ DBStayTapped
SVar:DBStayTapped:DB$Pump | KW$ HIDDEN This card doesn't untap during your next untap step. | Defined$ Targeted | Permanent$ True | IsCurse$ True
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/samite_alchemist.jpg
SetInfo:HML|Common|http://magiccards.info/scans/hl/en/116.jpg
Oracle:{W}{W}, {T}: Prevent the next 4 damage that would be dealt this turn to target creature you control. Tap that creature. It doesn’t untap during your next untap step.
End
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Card Contributions

Postby Sloth » 08 Mar 2012, 07:27

squee1968 wrote:Let's see if any of these will pass muster.
They've passed and were added. Thanks squee1968.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby moomarc » 08 Mar 2012, 08:49

friarsol wrote:
squee1968 wrote:Thanks to Sloth's conversion of Triangle of War to script, I can now add the last card of my Beast deck: Contested Cliffs.

Code: Select all
Name:Contested Cliffs
ManaCost:no cost
Types:Land
Text:no text
A:AB$ Mana | Cost$ T | Produced$ 1 | SpellDescription$ Add 1 to your mana pool.
A:AB$ Fight | Cost$ R G T | ValidTgts$ Creature.Beast+YouCtrl | TgtPrompt$ Choose target Beast creature you control | TargetsFromDifferentZone$ True | TargetMin$ 2 | TargetMax$ 2 | SpellDescription$ Choose target Beast creature you control and target creature an opponent controls. Each of those creatures deals damage equal to its power to the other.
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/contested_cliffs.jpg
SetInfo:ONS|Rare|http://magiccards.info/scans/on/en/314.jpg
Oracle:{T}: Add {1} to your mana pool.\n{R{}G}, {T}: Choose target Beast creature you control and target creature an opponent controls. Each of those creatures deals damage equal to its power to the other.
End
I'm not sure if that works Squee. It looks like you won't be able to target anything for the second Target, and even without the +YouCtrl you would be forced to target a Beast your opponent controls.
I got it to work with the following script: (just needed to add a tiny bit of code to tidy up the stack description)
Contested Cliffs | Open
Name:Contested Cliffs
ManaCost:no cost
Types:Land
Text:no text
A:AB$ Mana | Cost$ T | Produced$ 1 | SpellDescription$ Add 1 to your mana pool.
A:AB$ Pump | Cost$ R G T | ValidTgts$ Creature.Beast+YouCtrl | TgtPrompt$ Choose target Beast creature you control | SubAbility$ FightForTheCliffs | StackDescription$ None | SpellDescription$ Choose target Beast creature you control and target creature an opponent controls. Each of those creatures deals damage equal to its power to the other.
SVar:FightForTheCliffs:DB$ Fight | Defined$ Targeted | ValidTgts$ Creature.YouDontCtrl | TgtPrompt$ Choose target creature an opponent controls
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/contested_cliffs.jpg
SetInfo:ONS|Rare|http://magiccards.info/scans/en/on/314.jpg
Oracle:{T}: Add {1} to your mana pool.\n{R}{G}, {T}: Choose target Beast creature you control and target creature an opponent controls. Those creatures fight each other. (Each deals damage equal to its power to the other.)
End
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby moomarc » 08 Mar 2012, 20:34

I just added Mind Maggots. For the 'discard any number of creature cards' part, instead of handling it like Nantuko Cultivator, a list pops up asking how many cards you want to discard. Then the chosen number is passed on to NumCards in discard. The player can still cancel at any stage to stop discarding though.

My reasoning is that without that middle step, the player has to cancel for each card they don't want to discard, which can be mighty annoying when you're playing with Spellbook decks.

Anyway, if the powers that be feel that it doesn't play nicely, I'll revert to the method used by Nantuko Cultivator. :|

Edit: Someone might want to have a look at the changes I made to ChooseNumber to it to get the Max value from an SVar. I tested all the other ChooseNumber cards and they're all working as before, but there might be a better way to achieve what I've done. I just commented out the old lines at the start of the block.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby squee1968 » 12 Mar 2012, 19:15

Here's Monsoon.

Code: Select all
Name:Monsoon
ManaCost:2 R G
Types:Enchantment
Text:no text
T:Mode$ Phase | Phase$ End of Turn | ValidPlayer$ You | Execute$ TrigTapAllYou | TriggerZones$ Battlefield | TriggerDescription$ At the beginning of each player's end step, tap all untapped Islands that player controls and CARDNAME deals X damage to the player, where X is the number of Islands tapped this way.
SVar:TrigTapAllYou:AB$ TapAll | Cost$ 0 | ValidCards$ Island.untapped+YouCtrl | RememberTapped$ True | SubAbility$ DBDamageYou
SVar:DBDamageYou:DB$ DealDamage | Defined$ You | NumDmg$ MonsoonYouX | SubAbility$ DBCleanupYou
SVar:DBCleanupYou:DB$ Cleanup | ClearRemembered$ True
T:Mode$ Phase | Phase$ End of Turn | ValidPlayer$ Opponent | Execute$ TrigTapAllOpp | TriggerZones$ Battlefield | Secondary$ True | TriggerDescription$ At the beginning of each player's end step, tap all untapped Islands that player controls and CARDNAME deals X damage to the player, where X is the number of Islands tapped this way.
SVar:TrigTapAllOpp:AB$ TapAll | Cost$ 0 | ValidCards$ Island.untapped+YouDontCtrl | RememberTapped$ True | SubAbility$ DBDamageOpp
SVar:DBDamageOpp:DB$ DealDamage | Defined$ Opponent | NumDmg$ MonsoonOppX | SubAbility$ DBCleanupOpp
SVar:DBCleanupOpp:DB$ Cleanup | ClearRemembered$ True
SVar:MonsoonYouX:Remembered$Amount
SVar:MonsoonOppX:Remembered$Amount
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/monsoon.jpg
SetInfo:ICE|Rare|http://magiccards.info/scans/ia/en/376.jpg
Oracle:At the beginning of each player's end step, tap all untapped Islands that player controls and Monsoon deals X damage to the player, where X is the number of Islands tapped this way.
End
Also, I am re-posting this from the Card developement thread, as I've done some quick playtesting with it, and it seems to work fine.

Code: Select all
Name:Oriss, Samite Guardian
ManaCost:1 W W
Types:Legendary Creature Human Cleric
Text:no text
PT:1/3
A:AB$ Pump | Cost$ T | KW$ HIDDEN Prevent all damage that would be dealt to CARDNAME. | ValidTgts$ Creature | TgtPrompt$ Select target creature | SpellDescription$ Prevent all damage that would be dealt to target creature this turn.
A:AB$ Effect | Cost$ Discard<1/Card.namedOriss, Samite Guardian> | CostDesc$ Grandeur - Discard another card named CARDNAME:| Name$ Oriss Effect | IsCurse$ True | StaticAbilities$ CantBeCast | ValidTgts$ Player | RememberObjects$ Targeted | AILogic$ BeginningOfOppTurn | SubAbility$ DBPump | SpellDescription$ Target player can't cast spells this turn, and creatures that player controls can't attack this turn.
SVar:CantBeCast:Mode$ CantBeCast | ValidCard$ Card | Caster$ Player.IsRemembered | Description$ Target player can't cast spells this turn, and creatures that player controls can't attack this turn.
SVar:DBPump:DB$PumpAll | Defined$ Targeted | ValidCards$ Creature | KW$ HIDDEN CARDNAME can't attack.
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/oriss_samite_guardian.jpg
SetInfo:FUT|Rare|http://magiccards.info/scans/fut/en/28.jpg
Oracle:{T}: Prevent all damage that would be dealt to target creature this turn.\nGrandeur — Discard another card named Oriss, Samite Guardian: Target player can't cast spells this turn, and creatures that player controls can't attack this turn.
End
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Card Contributions

Postby friarsol » 12 Mar 2012, 19:25

squee1968 wrote:Here's Monsoon.
Pretty sure Monsoon falls into Sloth's Reserve list of "Scriptable but Broken due to AI"
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Card Contributions

Postby squee1968 » 13 Mar 2012, 08:02

About 3 weeks ago, Jeff added Scent of Nightshade. Probably meant to code the rest of the cycle, but forgot. So I've taken the liberty.

Code: Select all
Name:Scent of Brine
ManaCost:1 U
Types:Instant
Text:no text
A:SP$ Reveal | Cost$ 1 U | Defined$ You | RevealValid$ Card.Blue | AnyNumber$ True | RememberRevealed$ True | SubAbility$ DBScentOfBrineCounter | SpellDescription$ Reveal any number of blue cards in your hand. Counter target spell unless its controller pays {1} for each card revealed this way.
SVar:DBScentOfBrineCounter:AB$ Counter | Cost$ 0 | TargetType$ Spell | TgtPrompt$ Select target spell | ValidTgts$ Card | UnlessCost$ ScentOfBrineX | SubAbility$ DBScentOfBrineCleanup
SVar:DBScentOfBrineCleanup:DB$ Cleanup | ClearRemembered$ True
SVar:ScentOfBrineX:Remembered$Amount
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/scent_of_brine.jpg
SetInfo:UDS|Common|http://magiccards.info/scans/ud/en/45.jpg
Oracle:Reveal any number of blue cards in your hand. Counter target spell unless its controller pays {1} for each card revealed this way.
End
Code: Select all
Name:Scent of Cinder
ManaCost:1 R
Types:Sorcery
Text:no text
A:SP$ Reveal | Cost$ 1 R | Defined$ You | RevealValid$ Card.Red | AnyNumber$ True | RememberRevealed$ True | SubAbility$ DBScentOfCinderDamage | SpellDescription$ Reveal any number of red cards in your hand. CARDNAME deals X damage to target creature or player, where X is the number of cards revealed this way.
SVar:DBScentOfCinderDamage:DB$ DealDamage | Tgt$ TgtCP | NumDmg$ ScentOfCinderX | SubAbility$ DBScentOfCinderCleanup
SVar:ScentOfCinderX:Remembered$Amount
SVar:DBScentOfCinderCleanup:DB$ Cleanup | ClearRemembered$ True
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/scent_of_cinder.jpg
SetInfo:UDS|Common|http://magiccards.info/scans/uds/en/96.jpg
Oracle:Reveal any number of red cards in your hand. Scent of Cinder deals X damage to target creature or player, where X is the number of cards revealed this way.
End
Code: Select all
Name:Scent of Ivy
ManaCost:G
Types:Instant
Text:no text
A:SP$ Reveal | Cost$ G | Defined$ You | RevealValid$ Card.Green | AnyNumber$ True | RememberRevealed$ True | SubAbility$ DBScentOfIvyPump | SpellDescription$ Reveal any number of green cards in your hand. Target creature gets +X/+X until end of turn, where X is the number of cards revealed this way.
SVar:DBScentOfIvyPump:DB$ Pump | ValidTgts$ Creature | TgtPrompt$ Select target creature | NumAtt$ ScentOfIvyX | NumDef$ ScentOfIvyX | SubAbility$ DBScentOfIvyCleanup
SVar:ScentOfIvyX:Remembered$Amount
SVar:DBScentOfIvyCleanup:DB$ Cleanup | ClearRemembered$ True
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/scent_of_ivy.jpg
SetInfo:UDS|Common|http://magiccards.info/scans/ud/en/120.jpg
Oracle:Reveal any number of green cards in your hand. Target creature gets +X/+X until end of turn, where X is the number of cards revealed this way.
End
Code: Select all
Name:Scent of Jasmine
ManaCost:W
Types:Instant
Text:no text
A:SP$ Reveal | Cost$ W | Defined$ You | RevealValid$ Card.White | AnyNumber$ True | RememberRevealed$ True | SubAbility$ DBScentOfJasmineLife | SpellDescription$ Reveal any number of white cards in your hand. You gain 2 life for each card revealed this way.
SVar:DBScentOfJasmineLife:DB$ GainLife | LifeAmount$ ScentOfJasmineX | SubAbility$ DBScentOfJasmineCleanup
SVar:ScentOfJasmineX:Remembered$Amount/Times.2
SVar:DBScentOfJasmineCleanup:DB$ Cleanup | ClearRemembered$ True
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/scent_of_jasmine.jpg
SetInfo:UDS|Common|http://magiccards.info/scans/ud/en/17.jpg
Oracle:Reveal any number of white cards in your hand. You gain 2 life for each card revealed this way.
End
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Card Contributions

Postby squee1968 » 13 Mar 2012, 08:14

And here's some more.

Code: Select all
Name:Scout's Warning
ManaCost:W
Types:Instant
Text:no text
A:SP$Effect | Cost$ W | Name$ Scout's Warning effect | Triggers$ SpellCastTrig | SVars$ ScoutFlash,DBCleanup | SubAbility$ DBDraw | SpellDescription$ The next creature card you play this turn can be played as though it had flash.
SVar:DBDraw:DB$Draw | NumCards$ 1 | SpellDescription$ Draw a card.
SVar:SpellCastTrig:Mode$ SpellCast | ValidCard$ Creature | ValidControllingPlayer$ You | Execute$ ScoutFlash | Remember$ True | TriggerDescription$ The next creature card you play this turn can be played as though it had flash.
SVar:ScoutFlash:AB$ Pump | Cost$ 0 | Defined$ TriggeredCard | CheckSVar$ X | SVarCompare$ LT1 | KW$ HIDDEN Flash | PumpZone$ Hand | SubAbility$ DBCleanup
SVar:DBCleanup:DB$ ChangeZone | Defined$ Self | Origin$ Battlefield | Destination$ Graveyard
SVar:X:Remembered$Amount
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/scouts_warning.jpg
SetInfo:FUT|Rare|http://magiccards.info/scans/fut/en/16.jpg
Oracle:The next creature card you play this turn can be played as though it had flash.\nDraw a card.
End
Code: Select all
Name:Scrabbling Claws
ManaCost:1
Types:Artifact
Text:no text
A:AB$ ChangeZone | Cost$ T | ValidTgts$ Player | TgtPrompt$ Select target player | Origin$ Graveyard | Destination$ Exile | ChangeType$ Card | ChangeNum$ 1 | Hidden$ True | Chooser$ Targeted | Mandatory$ True | IsCurse$ True | SpellDescription$ Target player exiles a card from his or her graveyard.
A:AB$ ChangeZone | Cost$ T Sac<1/CARDNAME> | Origin$ Graveyard | Destination$ Exile | TgtPrompt$ Choose target card in a graveyard | ValidTgts$ Card | SubAbility$ DBDraw | SpellDescription$ Exile target card from a graveyard. Draw a card.
SVar:DBDraw:DB$Draw | NumCards$ 1
SVar:RemAIDeck:True
SVar:Rarity:Uncommon
SVar:Picture:http://www.wizards.com/global/images/magic/general/scrabbling_claws.jpg
SetInfo:MRD|Uncommon|http://magiccards.info/scans/mi/en/237.jpg
Oracle:{T}: Target player exiles a card from his or her graveyard.\n{1}, Sacrifice Scrabbling Claws: Exile target card from a graveyard. Draw a card.
End
Code: Select all
Name:Searing Spear Askari
ManaCost:2 R
Types:Creature Human Knight
Text:no text
PT:2/2
K:Flanking
A:AB$ Pump | Cost$ 1 R | KW$ CARDNAME can't be blocked except by two or more creatures. | SpellDescription$ CARDNAME can't be blocked except by two or more creatures this turn.
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/searing_spear_askari.jpg
SetInfo:MIR|Common|http://magiccards.info/scans/mr/en/191.jpg
Oracle:Flanking (Whenever a creature without flanking blocks this creature, the blocking creature gets -1/-1 until end of turn.)\n{1}{R}: Searing Spear Askari can’t be blocked except by two or more creatures this turn.
End
Code: Select all
Name:Seedling Charm
ManaCost:G
Types:Instant
Text:no text
A:SP$ ChangeZone | Cost$ G | ValidTgts$ Aura.AttachedTo Creature | TgtPrompt$ Select target Aura attached to a creature | Origin$ Battlefield | Destination$ Hand | SpellDescription$  Choose one - Return target Aura attached to a creature to its owner's hand;
A:SP$ Regenerate | Cost$ G | ValidTgts$ Creature.Green | TgtPrompt$ Select target green creature. | SpellDescription$ or regenerate target green creature;
A:SP$ Pump | Cost$ G | ValidTgts$ Creature | TgtPrompt$ Select target creature | KW$ Trample | SpellDescription$ or target creature gains trample until end of turn.
SVar:RemAIDeck:True
SVar:Rarity:Common
SVar:Picture:http://www.wizards.com/global/images/magic/general/seedling_charm.jpg
SetInfo:MIR|Common|http://magiccards.info/scans/mr/en/138.jpg
Oracle:Choose one — Return target Aura attached to a creature to its owner's hand; or regenerate target green creature; or target creature gains trample until end of turn.
End
Code: Select all
Name:Seht's Tiger
ManaCost:2 W W
Types:Creature Cat
Text:no text
PT:3/3
K:Flash
T:Mode$ ChangesZone | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigChoose | TriggerDescription$ When CARDNAME enters the battlefield, you gain protection from the color of your choice until end of turn
SVar:TrigChoose:AB$ ChooseColor | Cost$ 0 | Defined$ You | AILogic$ MostProminentAttackers | SubAbility$ DBProtection
SVar:DBProtection:DB$ Protection | ValidPlayers$ You | Gains$ ChosenColor
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/sehts_tiger.jpg
SetInfo:FUT|Rare|http://magiccards.info/scans/fut/en/31.jpg
Oracle:Flash (You may cast this spell any time you could cast an instant.)\nWhen Seht's Tiger enters the battlefield, you gain protection from the color of your choice until end of turn.
End
Code: Select all
Name:Silent Assassin
ManaCost:B B
Types:Creature Human Mercenary Assassin
Text:no text
PT:2/1
A:AB$ Pump | Cost$ 3 B | ValidTgts$ Creature.blocking | TgtPrompt$ Select target blocking creature | IsCurse$ True | Triggers$ DelTrig | SVars$ TrigDestroy | RememberObjects$ Targeted | SpellDescription$ Destroy target blocking creature at end of combat
SVar:DelTrig:Mode$ Phase | Phase$ EndCombat | TriggerZones$ Battlefield | ValidPlayer$ Player | Execute$ TrigDestroy | TriggerDescription$ Destroy target blocking creature at end of combat
SVar:TrigDestroy:AB$ Destroy | Cost$ 0 | ValidCards$ Creature.Remembered
SVar:RemAIDeck:True
SVar:Rarity:Rare
SVar:Picture:http://www.wizards.com/global/images/magic/general/silent_assassin.jpg
SetInfo:MMQ|Rare|http://magiccards.info/scans/mm/en/160.jpg
Oracle:{3}{B}: Destroy target blocking creature at end of combat.
End
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Card Contributions

Postby Sloth » 13 Mar 2012, 16:28

@Squee:

I've added the following cards:
Scent of Brine
Scent of Cinder
Scent of Ivy
Searing Spear Askari
Seedling Charm
Silent Assassin

Oriss, Samite Guardian
Her Grandeur "can't attack" ability should also be an effect and affect creatures after resolution.

Scent of Jasmine
For some reason the "Times.2" operator is not applied (no scripting error, but a missing feature).

Scout's Warning
The card can't work like this.

Scrabbling Claws
The targeted player of the first ability can exile a card from any graveyard.

Seht's Tiger
untested. EDIT: As i thought: AF Protetcion does not support ValidPlayers.

Thank you Squee.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Card Contributions

Postby moomarc » 13 Mar 2012, 16:39

Sloth wrote:Scent of Jasmine
For some reason the "Times.2" operator is not applied (no scripting error, but a missing feature).
I've come across this before. Remembered$Amount doesn't seem to allow math operations. Just use one of these:
Code: Select all
SVar:ScentOfJasmineX:Remembered$Amount.Twice

or

SVar:X:Remembered$Amount
SVar:ScentOfJasmineX:SVar$X/Twice
or

SVar:X:Remembered$Amount
SVar:ScentOfJasmineX:SVar$X/Times.2
That should sort it out.
Last edited by moomarc on 14 Mar 2012, 04:54, edited 1 time in total.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby squee1968 » 13 Mar 2012, 18:10

Sloth wrote:@Squee:

I've added the following cards:
Scent of Brine
Scent of Cinder
Scent of Ivy
Searing Spear Askari
Seedling Charm
Silent Assassin

Oriss, Samite Guardian
Her Grandeur "can't attack" ability should also be an effect and affect creatures after resolution.

This is beyond my ability to fix.

Scent of Jasmine
For some reason the "Times.2" operator is not applied (no scripting error, but a missing feature).

Looks like Moomarc has the solution for this. Thanks!

Scout's Warning
The card can't work like this.

If it's the "CheckSVar$ X | SVarCompare$ LT1" part of the script that is making it so that it can't work, I can explain. It was a half-baked attempt at making sure that it was only the next creature spell that could be played with flash. Got the idea from Insist, which if you look at that script, the SVar seems to be missing. Perhaps an Activation limit would be better. If it's something else, it's very likely I won't be able to correct it.

Scrabbling Claws
The targeted player of the first ability can exile a card from any graveyard.

This was taken from Graveyard Shovel, so if there's a fix for this, it needs to be applied to both cards.

Seht's Tiger
untested. EDIT: As i thought: AF Protetcion does not support ValidPlayers.

This was taken from Faith's Shield. Maybe ProtectionAll could be used to fix Seht's Tiger? Or does Faith's Shield need to be fixed as well?

Thank you Squee.
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

Re: Card Contributions

Postby moomarc » 14 Mar 2012, 06:55

I made the necessary fix to Scent of Jasmine and added it for you. I also tested Scrabbling Claws and it works. Added.

Insist and Overmaster did indeed need to be fixed. They had erroneous CheckSVars (I know I'd tested these so must have pasted that in while working on another card before committing them). Anyway, those are fixed but Scout's Warning had another problem. It's not the CheckSVar that caused issues (it could have been removed completely in fact - these limit the effect to the next 'whatever' by exiling the effect as part of the trigger). The actual problem is that it would never actually affect a card until it was cast which makes it too late to give it flash. So the effect has to statically pump all cards that could be played before it's played. It also needs some additional code that puts a restriction on the trigger to only go off if the card was played at non-sorcery speed. EDIT: Scratch that. The trigger only applies to the next card regardless of how you choose to use it. Committing soon.

Edit: Added Scout's warning. Thanks Squee. I also added the related card, Quicken.

Seht's Tiger doesn't work even if you change it to ProtectionAll, though Faith's Shield does. I'm not too sure what the issue is. I'm guessing it has to have valid creatures too? :shrug:
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby moomarc » 14 Mar 2012, 08:32

Looked into ProtectAll AF and it wouldn't get to ValidPlayers unless the script had ValidCards as well. So I've moved the block dealing with non-players into an if-block similar to player so that it will be ignored if there's no ValidCards parameter.

Seht's Tiger now works and is added.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby moomarc » 14 Mar 2012, 09:53

Added Oriss, Samite Guardian. The reason it was wrong before was because PumpAll would only affect creatures that were already in play. Instead the effect had to have a second static ability that pumped the "can't attack" keyword. It did need some additional code to support it though (needed a RememberedPlayerCtrl restriction).

I think that's all your cards added. Thanks!
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Card Contributions

Postby squee1968 » 14 Mar 2012, 10:10

Yep, that would be all of them, except of course for Monsoon, which has been deemed unfair to the AI. Thanks to you for caring enough to fix and add these cards for me. I'll make sure your good deeds will not go unpunished, by which I mean that I'll soon be screwing up more scripts that you can fix. :)
squee1968
 
Posts: 254
Joined: 18 Nov 2011, 03:28
Has thanked: 110 times
Been thanked: 45 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 54 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 54 users online :: 0 registered, 0 hidden and 54 guests (based on users active over the past 10 minutes)
Most users ever online was 7967 on 09 Sep 2025, 23:08

Users browsing this forum: No registered users and 54 guests

Login Form