It is currently 16 Aug 2025, 08:56
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby timmermac » 10 May 2011, 20:50

r8413. Computer cast Disenchant on a Mageta's Boon attached to my Covert Operative. The Boon's bonus is still being applied.

Edit: Instant ueot buffs are also remaining on creatures after their effect should have ended. Example: I cast a Riding The Dilu Horse on a Kresh, the Bloodbraided. The effect is still there the next turn.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
User avatar
timmermac
Tester
 
Posts: 1512
Joined: 17 May 2010, 20:36
Has thanked: 18 times
Been thanked: 95 times

Re: SVN Bug Reports

Postby Hellfish » 10 May 2011, 21:00

Riding the Dilu Horse is a permanent effect ;)
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: SVN Bug Reports

Postby timmermac » 10 May 2011, 21:09

Hellfish wrote:Riding the Dilu Horse is a permanent effect ;)
Oops. :oops:
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
User avatar
timmermac
Tester
 
Posts: 1512
Joined: 17 May 2010, 20:36
Has thanked: 18 times
Been thanked: 95 times

Re: SVN Bug Reports

Postby timmermac » 10 May 2011, 21:14

r8413... I got an uncommon - Confiscate - as my random rare after winning a match against King Arthur.
"I just woke up, haven't had coffee, let alone a pee in 7 days, and I find out you stole my ass and made a ...mini-me! Carter, I should be irked currently, yes?" - Jack O'Neill
User avatar
timmermac
Tester
 
Posts: 1512
Joined: 17 May 2010, 20:36
Has thanked: 18 times
Been thanked: 95 times

Re: SVN Bug Reports

Postby slapshot5 » 10 May 2011, 21:24

timmermac wrote:r8413... I got an uncommon - Confiscate - as my random rare after winning a match against King Arthur.
fixed in SVN. Thanks!

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby Fnoed » 11 May 2011, 06:55

Chris H. wrote:I was able to export a deck from the deck editor but the deck file is a text file rather than a serialized deck file. I suspect that the import command has not yet been updated in the quest editor to be able to handle this change.
This is precisely the case.
Based on this discussion, I think we should just disable the import command in the quest deck editor and add an option at the start of the quest to import a deck (replacing the random initial card pool). This would mean that people would have to start a new quest to test a new deck though.
Fnoed
 
Posts: 84
Joined: 20 Dec 2010, 01:03
Has thanked: 0 time
Been thanked: 3 times

Re: SVN Bug Reports

Postby Sloth » 11 May 2011, 10:35

Fnoed wrote:
Chris H. wrote:I was able to export a deck from the deck editor but the deck file is a text file rather than a serialized deck file. I suspect that the import command has not yet been updated in the quest editor to be able to handle this change.
This is precisely the case.
Based on this discussion, I think we should just disable the import command in the quest deck editor and add an option at the start of the quest to import a deck (replacing the random initial card pool). This would mean that people would have to start a new quest to test a new deck though.
Sounds fair enough to me.

Another question Fnoed:
Does the new metadata in deck files allow to add quest decks without an entry in the QuestBattle class?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby Chris H. » 11 May 2011, 12:34

Fnoed wrote:Based on this discussion, I think we should just disable the import command in the quest deck editor and add an option at the start of the quest to import a deck (replacing the random initial card pool). This would mean that people would have to start a new quest to test a new deck though.
`
Yeah, there has been several discussions over the last couple of years in reference to importing decks into quest mode.

Some people are looking for a gauntlet type mode where they can play a pre-con deck against high quality AI decks. In this case wining cards, buying and selling cards and developing a deck over time might not be their primary goal.

Other people might not have the time or the interest in re-rolling their starting quest pool while they look for an interesting pool of cards to start with. These people might have an interest in improving their deck as they progress through their quest. They might just want a starter deck to help them save some initial start up time.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Jaedayr » 11 May 2011, 18:16

Chris H. wrote:Other people might not have the time or the interest in re-rolling their starting quest pool while they look for an interesting pool of cards to start with. These people might have an interest in improving their deck as they progress through their quest. They might just want a starter deck to help them save some initial start up time.
I agree with this. I enjoy winning new cards, trying to improve and build alternate decks as I quest. I am not an expert player and for me there is a lot of frustration trying to get started, with a random set of cards from our ever-expanding :) pool. Playing against early opponents sometimes I can tell by about the third or fourth turn that I have no chance whatsoever of winning the game.
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby SoulStorm » 11 May 2011, 19:08

Chris H. wrote:Some people are looking for a gauntlet type mode where they can play a pre-con deck against high quality AI decks. In this case wining cards, buying and selling cards and developing a deck over time might not be their primary goal.
Yep, this would be me, at least until Shandalar is integrated. Though admittedly, I'm not playing much at all currently. I just track the change log, and every once in awhile a new card or other change inspires me to design a new deck to play around with for a bit.

I'm not exactly sure why some people want to make it difficult to import decks into quest mode anyway. I personally played over 1,000 games in quest mode before I got tired of playing hundreds of games to build one deck. Now I just want to be able to tinker with new decks and test them against the creations of others. Why do some people not want me to be able to do this?
SoulStorm
 
Posts: 423
Joined: 24 Jun 2010, 22:48
Has thanked: 16 times
Been thanked: 11 times

Re: SVN Bug Reports

Postby Jaedayr » 11 May 2011, 19:32

r8521

This occurred in AI Main2.

Code: Select all
An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


There is an error in the card code for Flayer Husk:



Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.RuntimeException: AbilityFactory : getAbility -- abString too short in Flayer Husk
   at forge.card.abilityFactory.AbilityFactory.getMapParams(AbilityFactory.java:106)
   at forge.card.abilityFactory.AbilityFactory.getAbility(AbilityFactory.java:142)
   at forge.card.spellability.Spell_Permanent.checkETBEffects(Spell_Permanent.java:255)
   at forge.card.spellability.Spell_Permanent.canPlayAI(Spell_Permanent.java:231)
   at forge.ComputerAI_General.getPlayable(ComputerAI_General.java:194)
   at forge.ComputerAI_General.getMain2(ComputerAI_General.java:148)
   at forge.ComputerAI_General.playCards(ComputerAI_General.java:38)
   at forge.ComputerAI_General.main2(ComputerAI_General.java:34)
   at forge.ComputerAI_Input.think(ComputerAI_Input.java:67)
   at forge.ComputerAI_Input.showMessage(ComputerAI_Input.java:33)
   at forge.GuiInput.setInput(GuiInput.java:29)
   at forge.GuiInput.update(GuiInput.java:23)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.Phase.nextPhase(Phase.java:385)
   at forge.GuiDisplay4$25.actionPerformed(GuiDisplay4.java:746)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby Jaedayr » 11 May 2011, 19:48

r8521

Got the following as I was casting Carnifex Demon against quest Darrin Stevens easy. Checking the AI hand afterwards showed one Assert Authority, but I don't know if this actually caused the problem.

Code: Select all
An error has occurred. You can copy/paste this message or save it to a file.
Please report this, plus what you tried to do, to:
   http://www.slightlymagic.net/forum/viewforum.php?f=26
If you don't want to register an account, you can mail it directly to
   mtgerror@yahoo.com


null


Version:
Forge -- official beta: $Date: 2011-01-06 11:34:48 -0500 (Thu, 06 Jan 2011) $, SVN revision: $Revision: 4891 $

OS: Windows XP Version: 5.1 Architecture: x86

Java Version: 1.6.0_24 Vendor: Sun Microsystems Inc.

Detailed error trace:
java.lang.NullPointerException
   at forge.card.abilityFactory.AbilityFactory_CounterMagic.counterCanPlayAI(AbilityFactory_CounterMagic.java:155)
   at forge.card.abilityFactory.AbilityFactory_CounterMagic.access$2(AbilityFactory_CounterMagic.java:144)
   at forge.card.abilityFactory.AbilityFactory_CounterMagic$2.canPlayAI(AbilityFactory_CounterMagic.java:98)
   at forge.ComputerUtil.playCounterSpell(ComputerUtil.java:151)
   at forge.ComputerAI_General.stackResponse(ComputerAI_General.java:317)
   at forge.ComputerAI_General.stack_not_empty(ComputerAI_General.java:285)
   at forge.gui.input.InputControl.updateInput(InputControl.java:151)
   at forge.GuiInput.update(GuiInput.java:21)
   at java.util.Observable.notifyObservers(Unknown Source)
   at java.util.Observable.notifyObservers(Unknown Source)
   at forge.MyObservable.updateObservers(MyObservable.java:9)
   at forge.gui.input.InputControl.resetInput(InputControl.java:58)
   at forge.Phase.passPriority(Phase.java:527)
   at forge.gui.input.Input_PassPriority.selectButtonOK(Input_PassPriority.java:42)
   at forge.GuiInput.selectButtonOK(GuiInput.java:37)
   at forge.GuiDisplay4.okButtonActionPerformed(GuiDisplay4.java:954)
   at forge.GuiDisplay4.access$3(GuiDisplay4.java:953)
   at forge.GuiDisplay4$25.actionPerformed(GuiDisplay4.java:741)
   at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
   at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
   at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
   at java.awt.Component.processMouseEvent(Unknown Source)
   at javax.swing.JComponent.processMouseEvent(Unknown Source)
   at java.awt.Component.processEvent(Unknown Source)
   at java.awt.Container.processEvent(Unknown Source)
   at java.awt.Component.dispatchEventImpl(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
   at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
   at java.awt.Container.dispatchEventImpl(Unknown Source)
   at java.awt.Window.dispatchEventImpl(Unknown Source)
   at java.awt.Component.dispatchEvent(Unknown Source)
   at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
   at java.awt.EventQueue.access$000(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.awt.EventQueue$1.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.awt.EventQueue$2.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.AccessControlContext$1.doIntersectionPrivilege(Unknown Source)
   at java.awt.EventQueue.dispatchEvent(Unknown Source)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
   at java.awt.EventDispatchThread.run(Unknown Source)
Jaedayr
Tester
 
Posts: 523
Joined: 08 Jul 2010, 00:06
Has thanked: 16 times
Been thanked: 13 times

Re: SVN Bug Reports

Postby Chris H. » 11 May 2011, 20:04

Jaedayr wrote:I agree with this. I enjoy winning new cards, trying to improve and build alternate decks as I quest. I am not an expert player and for me there is a lot of frustration trying to get started, with a random set of cards from our ever-expanding :) pool. Playing against early opponents sometimes I can tell by about the third or fourth turn that I have no chance whatsoever of winning the game.
`
Sometimes I really enjoy re-rolling the starting pool of cards and other times I just do not want to be bothered.

Fnoed and Sol came up with an idea in another topic about giving us the ability to import a deck rather than using a random set of cards at the beginning of a quest.

We would not be able to import other cards and decks at a later stage in the quest but this might encourage a few people to create some starter decks that people could consider before starting their quest.

It might be fun to use your quest to improve that starter Goblin/Elf/Counter/Discard type deck.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby friarsol » 11 May 2011, 20:14

Jaedayr wrote:r8521

This occurred in AI Main2.
There is an error in the card code for Flayer Husk:
Was Flayer Husk in play? We need more information so we can recreate problems like this.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Fnoed » 11 May 2011, 20:15

Sloth wrote:Another question Fnoed:
Does the new metadata in deck files allow to add quest decks without an entry in the QuestBattle class?
Yes, this is the plan. There will be some additional lines that will indicate the difficulty of the deck, the description and the opponent image name. We should even be able to define quests' various parameters like initial board setup and reward data in there.
Fnoed
 
Posts: 84
Joined: 20 Dec 2010, 01:03
Has thanked: 0 time
Been thanked: 3 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 10 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 10 users online :: 0 registered, 0 hidden and 10 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 10 guests

Login Form