Bug Reports (snapshot builds)
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Bug Reports (snapshot builds)
by RumbleBBU » 12 Nov 2012, 13:02
Hard to tell...it doesn't compile/run for me because of com.beust.jcommander stuff, I just get a "Source not found." from URLClassLoader and Forge won't start.Max mtg wrote:Ok, will changes in 18051 do the job?
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Nov 2012, 13:07
Oh hell, there should beRumbleBBU wrote:Hard to tell...it doesn't compile/run for me because of com.beust.jcommander stuff, I just get a "Source not found." from URLClassLoader and Forge won't start.Max mtg wrote:Ok, will changes in 18051 do the job?
- Code: Select all
import com.google.common.collect.Lists;
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 12 Nov 2012, 13:28
...doesn't work. 
When I now start a quest with custom format limited to Ice Age block + 4th Ed, I get cards from the full cardpool.
(You could actually test whether the code changes work for GameFormatQuest or not before committing - just try to start a quest with a custom format and see if you get the editions you asked for or not.)
When I now start a quest with custom format limited to Ice Age block + 4th Ed, I get cards from the full cardpool.
(You could actually test whether the code changes work for GameFormatQuest or not before committing - just try to start a quest with a custom format and see if you get the editions you asked for or not.)
Re: Bug Reports (snapshot builds)
by Max mtg » 12 Nov 2012, 13:46
Well, it's completelly my fault - so let me explore the problem in detail today's evening.RumbleBBU wrote:...doesn't work.
When I now start a quest with custom format limited to Ice Age block + 4th Ed, I get cards from the full cardpool.
(You could actually test whether the code changes work for GameFormatQuest or not before committing - just try to start a quest with a custom format and see if you get the editions you asked for or not.)
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Max mtg » 13 Nov 2012, 08:12
Rumble, I could not understand how the start quest dialog works - that is what should one do to start a quest with sets to be unlocked. Guess, a lot of people also faced difficulties understanding what each option does.
This is why I have rewritten that dialog. Will return to quest unlocks today's evening.
ATM a new starting options dialog is commited. I'll also add options to adjust the initial set of boosters allowed as prize... so that it does not just copy the starting pool format (when provided).
This is why I have rewritten that dialog. Will return to quest unlocks today's evening.
ATM a new starting options dialog is commited. I'll also add options to adjust the initial set of boosters allowed as prize... so that it does not just copy the starting pool format (when provided).
Single class for single responsibility.
- Max mtg
- Programmer
- Posts: 1997
- Joined: 02 Jul 2011, 14:26
- Has thanked: 173 times
- Been thanked: 334 times
Re: Bug Reports (snapshot builds)
by Agetian » 14 Nov 2012, 05:14
A bug related to Savage Hunter: when choosing its ability, only Cycling is shown in the dialog box, the main card effect has no description but can still be selected. EDIT: After trying it again, the problem seemingly went away. Not sure what the problem was.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3489
- Joined: 14 Mar 2011, 05:58
- Has thanked: 684 times
- Been thanked: 572 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 15 Nov 2012, 07:38
I'd say you got it about right...yes, it's a lot more logical now. Well done!Max mtg wrote:Rumble, I could not understand how the start quest dialog works - that is what should one do to start a quest with sets to be unlocked. Guess, a lot of people also faced difficulties understanding what each option does.
This is why I have rewritten that dialog.
However, I'm getting NPE when I choose "Starting Pool: Custom format" (+Define) and "Prized cards: Same as starting pool", and then click Embark.
- | Open
Re: Bug Reports (snapshot builds)
by RumbleBBU » 15 Nov 2012, 07:48
And the Concurrent Modification Exception for quest challenges that contain preset cards (HumanExtras, AIExtras) still persists.
1.2.15 is the last version I know that didn't have this, so it's related to something that was done since then (between 1.2.15 and 1.3.0).
This is in fact the single biggest reason why I can't upgrade my personal 'playing version' to the current codebase - I very much want to play those challenges. Unfortunately, I don't have the slightest idea why this is happening or how to fix this. The UI/concurrency stuff is way over my head.
- | Open
1.2.15 is the last version I know that didn't have this, so it's related to something that was done since then (between 1.2.15 and 1.3.0).
This is in fact the single biggest reason why I can't upgrade my personal 'playing version' to the current codebase - I very much want to play those challenges. Unfortunately, I don't have the slightest idea why this is happening or how to fix this. The UI/concurrency stuff is way over my head.
Re: Bug Reports (snapshot builds)
by Bundy » 15 Nov 2012, 11:26
- Bundy
- Posts: 348
- Joined: 17 Dec 2010, 17:32
- Location: The netherlands
- Has thanked: 23 times
- Been thanked: 3 times
Re: Bug Reports (snapshot builds)
by ttdic » 15 Nov 2012, 13:18
This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.
For input string: ""
Version:
Forge version 1.3.1-SNAPSHOT-r17955
OS: Windows 7 Version: 6.1 Architecture: amd64
Java Version: 1.7.0_09 Vendor: Oracle Corporation
Detailed error trace:
java.lang.NumberFormatException: For input string: ""
at java.lang.NumberFormatException.forInputString(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at forge.card.abilityfactory.ai.PumpAi.chkAIDrawback(PumpAi.java:397)
at forge.card.abilityfactory.CommonDrawback.chkAIDrawback(CommonDrawback.java:70)
at forge.card.abilityfactory.SpellAiLogic.canPlayAIWithSubs(SpellAiLogic.java:13)
at forge.card.abilityfactory.CommonAbility.canPlayAI(CommonAbility.java:66)
at forge.game.player.ComputerUtil.canBePlayedAndPayedByAI(ComputerUtil.java:454)
at forge.game.player.ComputerUtil.playSpellAbilities(ComputerUtil.java:112)
at forge.game.player.ComputerAIGeneral.playSpellAbilitiesStackEmpty(ComputerAIGeneral.java:84)
at forge.game.player.ComputerAIGeneral.main(ComputerAIGeneral.java:69)
at forge.game.player.ComputerAIInput.think(ComputerAIInput.java:114)
at forge.game.player.ComputerAIInput.showMessage(ComputerAIInput.java:77)
at forge.gui.GuiInput.setInput(GuiInput.java:71)
at forge.gui.GuiInput.update(GuiInput.java:54)
at java.util.Observable.notifyObservers(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at forge.util.MyObservable.updateObservers(MyObservable.java:38)
at forge.game.zone.MagicStack.finishResolving(MagicStack.java:1061)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:913)
at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:718)
at forge.control.input.InputPassPriority.selectButtonOK(InputPassPriority.java:74)
at forge.gui.GuiInput.selectButtonOK(GuiInput.java:80)
at forge.gui.match.controllers.CMessage$2.actionPerformed(CMessage.java:51)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$200(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.
For input string: ""
Version:
Forge version 1.3.1-SNAPSHOT-r17955
OS: Windows 7 Version: 6.1 Architecture: amd64
Java Version: 1.7.0_09 Vendor: Oracle Corporation
Detailed error trace:
java.lang.NumberFormatException: For input string: ""
at java.lang.NumberFormatException.forInputString(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at java.lang.Integer.parseInt(Unknown Source)
at forge.card.abilityfactory.ai.PumpAi.chkAIDrawback(PumpAi.java:397)
at forge.card.abilityfactory.CommonDrawback.chkAIDrawback(CommonDrawback.java:70)
at forge.card.abilityfactory.SpellAiLogic.canPlayAIWithSubs(SpellAiLogic.java:13)
at forge.card.abilityfactory.CommonAbility.canPlayAI(CommonAbility.java:66)
at forge.game.player.ComputerUtil.canBePlayedAndPayedByAI(ComputerUtil.java:454)
at forge.game.player.ComputerUtil.playSpellAbilities(ComputerUtil.java:112)
at forge.game.player.ComputerAIGeneral.playSpellAbilitiesStackEmpty(ComputerAIGeneral.java:84)
at forge.game.player.ComputerAIGeneral.main(ComputerAIGeneral.java:69)
at forge.game.player.ComputerAIInput.think(ComputerAIInput.java:114)
at forge.game.player.ComputerAIInput.showMessage(ComputerAIInput.java:77)
at forge.gui.GuiInput.setInput(GuiInput.java:71)
at forge.gui.GuiInput.update(GuiInput.java:54)
at java.util.Observable.notifyObservers(Unknown Source)
at java.util.Observable.notifyObservers(Unknown Source)
at forge.util.MyObservable.updateObservers(MyObservable.java:38)
at forge.game.zone.MagicStack.finishResolving(MagicStack.java:1061)
at forge.game.zone.MagicStack.resolveStack(MagicStack.java:913)
at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:718)
at forge.control.input.InputPassPriority.selectButtonOK(InputPassPriority.java:74)
at forge.gui.GuiInput.selectButtonOK(GuiInput.java:80)
at forge.gui.match.controllers.CMessage$2.actionPerformed(CMessage.java:51)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
at java.awt.EventQueue.access$200(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.awt.EventQueue$3.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.awt.EventQueue$4.run(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)
Re: Bug Reports (snapshot builds)
by friarsol » 15 Nov 2012, 13:54
Can you post your quest somewhere and exact steps with how you are getting it? I don't really get this one anymore, at least without any type of consistency.RumbleBBU wrote:And the Concurrent Modification Exception for quest challenges that contain preset cards (HumanExtras, AIExtras) still persists.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by friarsol » 15 Nov 2012, 14:46
Looks like we're running into this:RumbleBBU wrote:However, I'm getting NPE when I choose "Starting Pool: Custom format" (+Define) and "Prized cards: Same as starting pool", and then click Embark.
http://stackoverflow.com/questions/2926 ... fault-case
Maybe instead of returning null from getPrizedPoolType() we should be returning getStartingPoolType(). Is there anything we would actually want to use null for?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Bug Reports (snapshot builds)
by RumbleBBU » 15 Nov 2012, 14:59
Well, the problem seems to occur with 100% certainty for any challenge I have made...including, for example, my Shandalar challenges - viewtopic.php?f=48&t=8365friarsol wrote:Can you post your quest somewhere and exact steps with how you are getting it? I don't really get this one anymore, at least without any type of consistency.RumbleBBU wrote:And the Concurrent Modification Exception for quest challenges that contain preset cards (HumanExtras, AIExtras) still persists.
You should be able to replicate the problem by using the challenges included in that post (instead of the stock challenges). If not, I can post a quest save.
Of course, it could be a problem in my challenges, but I doubt that. I don't see that I have anything much differently from the stock ones. Could some cards be more likely to trigger the crash than others?
Re: Bug Reports (snapshot builds)
by Sloth » 15 Nov 2012, 17:37
positionAllCards puts the cards into stacks and rows on the battlefield. I can imagine the problem to only occur when cards with different types are added (for example lands and creatures).RumbleBBU wrote:Of course, it could be a problem in my challenges, but I doubt that. I don't see that I have anything much differently from the stock ones. Could some cards be more likely to trigger the crash than others?
-
Sloth - Programmer
- Posts: 3498
- Joined: 23 Jun 2009, 19:40
- Has thanked: 125 times
- Been thanked: 507 times
Who is online
Users browsing this forum: No registered users and 36 guests