It is currently 24 Aug 2025, 20:31
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby Agetian » 25 Nov 2012, 14:40

Metalcraft is broken in the latest (r18391) build - the Metalcraft abilities are in effect regardless of whether there are three artifacts in play on the controller's side or not.

- Agetian
Agetian
Programmer
 
Posts: 3489
Joined: 14 Mar 2011, 05:58
Has thanked: 684 times
Been thanked: 572 times

Re: Bug Reports (snapshot builds)

Postby Hellfish » 25 Nov 2012, 14:53

Re:block sound event outside combat.
You could just have the method that posts the event check if the game is not in the combat and throw an exception if so. That way you'll get a call stack once it does happen, at least.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
User avatar
Hellfish
Programmer
 
Posts: 1297
Joined: 07 Jun 2009, 10:41
Location: South of the Pumphouse
Has thanked: 110 times
Been thanked: 169 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 25 Nov 2012, 15:07

Agetian wrote:Metalcraft is broken in the latest (r18391) build - the Metalcraft abilities are in effect regardless of whether there are three artifacts in play on the controller's side or not.

- Agetian
Which card did you test? Ardent Recruit works fine.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 25 Nov 2012, 15:13

Here's a test file for e.g. Snapsail Glider which is always Flying no matter the artifacts:

Code: Select all
ActivePlayer=AI
ActivePhase=Main1
AICardsInPlay=Snapsail Glider
The same goes for e.g. Spire Serpent - always +2/+2.

- Agetian
Agetian
Programmer
 
Posts: 3489
Joined: 14 Mar 2011, 05:58
Has thanked: 684 times
Been thanked: 572 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 25 Nov 2012, 15:19

Agetian wrote:Here's a test file for e.g. Snapsail Glider which is always Flying no matter the artifacts:

Code: Select all
ActivePlayer=AI
ActivePhase=Main1
AICardsInPlay=Snapsail Glider
The same goes for e.g. Spire Serpent - always +2/+2.

- Agetian
They all work correct for me. Did you refresh? Can someone else test them?
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 25 Nov 2012, 15:20

Umm I'm using the latest codebase... let me just make sure by reverting all possible local changes if any, updating again to the latest head revision, cleaning the project and recompiling. I'll get back to you by editing this post.

EDIT: Yep, full recompilation and resource refresh helped, seems like at least something somewhere was out of sync in my main game folder. Sorry for the false positive.

- Agetian
Agetian
Programmer
 
Posts: 3489
Joined: 14 Mar 2011, 05:58
Has thanked: 684 times
Been thanked: 572 times

Re: Bug Reports (snapshot builds)

Postby jeffwadsworth » 25 Nov 2012, 15:59

Agetian wrote:Umm I'm using the latest codebase... let me just make sure by reverting all possible local changes if any, updating again to the latest head revision, cleaning the project and recompiling. I'll get back to you by editing this post.

EDIT: Yep, full recompilation and resource refresh helped, seems like at least something somewhere was out of sync in my main game folder. Sorry for the false positive.

- Agetian
This happened to me all the time. I adapted a full refresh every week approach because of it.
jeffwadsworth
Super Tester Elite
 
Posts: 1172
Joined: 20 Oct 2010, 04:47
Location: USA
Has thanked: 287 times
Been thanked: 70 times

Re: Bug Reports (snapshot builds)

Postby Corwin72 » 27 Nov 2012, 03:26

forge-1.3.2-20121126.131929-10

New quest.
Developer mode off.
at the end of every turn the game sends the land that I or the AI play to the library.
User avatar
Corwin72
 
Posts: 793
Joined: 15 Sep 2009, 13:26
Location: Grayson, Ga
Has thanked: 25 times
Been thanked: 9 times

Re: Bug Reports (snapshot builds)

Postby swordshine » 27 Nov 2012, 05:29

In the script of Ashen Ghoul , "PlayerTurn$ True" is not replaced with "Condition$ PlayerTurn"
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 27 Nov 2012, 05:41

 Erg Raiders script does not fire correctly (it doesn't deal 2 damage to me even if it's not the turn it came into play if I haven't attacked with it) - tried it with a full clean rebuild and resource refresh, still won't fire for me. :(

Erg Raiders picture does not show correctly for Arabian Nights (ARN) set, most likely because the "Erg Raiders1.full.jpg" / "Erg Raiders2.full.jpg" form is not recognized or something (true for at least many other cards from ARN, ALL, and FEM, possibly among others).

- Agetian
Last edited by Chris H. on 27 Nov 2012, 12:10, edited 1 time in total.
Reason:  
Agetian
Programmer
 
Posts: 3489
Joined: 14 Mar 2011, 05:58
Has thanked: 684 times
Been thanked: 572 times

Re: Bug Reports (snapshot builds)

Postby moomarc » 27 Nov 2012, 06:05

Agetian wrote:Erg Raiders script does not fire correctly (it doesn't deal 2 damage to me even if it's not the turn it came into play if I haven't attacked with it) - tried it with a full clean rebuild and resource refresh, still won't fire for me. :(

Erg Raiders picture does not show correctly for Arabian Nights (ARN) set, most likely because the "Erg Raiders1.full.jpg" / "Erg Raiders2.full.jpg" form is not recognized or something (true for at least many other cards from ARN, ALL, and FEM, possibly among others).

- Agetian
The EOT trigger is now fixed (was just missing the actual 'Count$' part of the count method).

My images are also working fine, regardless of whether I rename them "Erg Raiders1.full.jpg" or the clean name version "erg_raiders1.jpg". Are you using the version downloaded through Forge, or did you just use the HQ pics?
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Bug Reports (snapshot builds)

Postby Sloth » 27 Nov 2012, 08:24

swordshine wrote:In the script of Ashen Ghoul , "PlayerTurn$ True" is not replaced with "Condition$ PlayerTurn"
The change to "Condition$ PlayerTurn" was only made for static abilities. Activated abilities have restrictions and conditions which are handled differently.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 27 Nov 2012, 10:23

moomarc wrote:My images are also working fine, regardless of whether I rename them "Erg Raiders1.full.jpg" or the clean name version "erg_raiders1.jpg". Are you using the version downloaded through Forge, or did you just use the HQ pics?
I'm using the CCGHQ high quality pics, the files are called Erg Raiders1.full.jpg and Erg Raiders2.full.jpg - for whatever reason, they're not working in Forge (the only way I can make them work is by renaming one of the files just Erg Raiders.full.jpg, in which case it works fine).

- Agetian
Agetian
Programmer
 
Posts: 3489
Joined: 14 Mar 2011, 05:58
Has thanked: 684 times
Been thanked: 572 times

Re: Bug Reports (snapshot builds)

Postby moomarc » 27 Nov 2012, 11:26

Agetian wrote:I'm using the CCGHQ high quality pics, the files are called Erg Raiders1.full.jpg and Erg Raiders2.full.jpg - for whatever reason, they're not working in Forge (the only way I can make them work is by renaming one of the files just Erg Raiders.full.jpg, in which case it works fine).

- Agetian
That's kinda strange because I'm also using the hq pics with the same names. Check the script for Erg Raiders on your build. You should only get the situation you're describing if the setinfo for ARN doesn't end with |2 which says how many variations there are within the set. I had that issue when I first scripted Nafs Asp because the SetInfo script doesn't pick up extra variations automatically (although I think it once did in earlier versions of Ark's mtgdata file) so it had a blank image because it didn't know to check the extra numbers.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 27 Nov 2012, 12:43

moomarc wrote:I had that issue when I first scripted Nafs Asp because the SetInfo script doesn't pick up extra variations automatically (although I think it once did in earlier versions of Ark's mtgdata file) so it had a blank image because it didn't know to check the extra numbers.
This was never the case, since the SetInfo script grabs from magiccards.info not mtgdata.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 15 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 15 users online :: 0 registered, 0 hidden and 15 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 15 guests

Login Form