It is currently 17 Aug 2025, 19:45
   
Text Size

SVN Bug Reports

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: SVN Bug Reports

Postby Sloth » 04 Jun 2011, 15:54

Agetian wrote:SVN r9251: the AI casts Shambling Shell and sacrifices it to try and put a counter on the sacrificed Shambling Shell instead of on other creatures that it has.
The AI won't use the ability for now. Thanks Agetian.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby lazylockie » 04 Jun 2011, 17:15

r9243

Sower of Temptation dies and I still have control of AI's creature.

Dreamspoiler Witches - after I cast a creature with Flash (Scion of Oona), the creature doesn't appear on battlefield (and doesn't go to graveyard either). Also, might be related, the same creature with flash couldn't be cast at all (doesn't prompt mana cost payment) on the subsequent games.

Allies (Kazandu Blademaster and others) are triggering when themselves enter the battlefield twice
Last edited by lazylockie on 04 Jun 2011, 19:54, edited 1 time in total.
lazylockie
 
Posts: 508
Joined: 13 Jul 2010, 22:44
Has thanked: 74 times
Been thanked: 15 times

Re: SVN Bug Reports

Postby Sloth » 04 Jun 2011, 17:27

Biribau wrote:.

Goblin Grenade gives an error when it's played by human - as soon as you sacrifice.
I just tried Goblin Grenade and it worked fine. What did you sacrifice Biribau? (and maybe can you post the error report next time)
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby friarsol » 05 Jun 2011, 02:03

It looks like enPump isn't displaying in the card detail Panel, here's a few I noticed.
Cursed Flesh
Sea's Claim (duplicates)
Viscerid Armor
Shackles
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby friarsol » 05 Jun 2011, 02:20

Has anyone noticed the AI properly paying mana for CounterMagic with UnlessCosts? I just Condescend -ed his spell for 3, it resolved (allowing me to Scry) but then the Spell still resolved. The AI only had 2 mana available, and neither land is now tapped.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby slapshot5 » 05 Jun 2011, 02:35

r9279

Many cards have duplicate text. See:

Clone
Siren's Call (good example; it shows '\r\n' not being translated, which may give a clue)
Vesuvan Doppelganger

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby Chris H. » 05 Jun 2011, 02:46

slapshot5 wrote:r9279

Many cards have duplicate text. See:

Clone
Siren's Call (good example; it shows '\r\n' not being translated, which may give a clue)
Vesuvan Doppelganger

-slapshot5
`
I have spent a lot of time trying to figure this one out. It appears that somewhere in the code some cards are getting a:

getText() + getSpellText()

It seems to only show up in hard coded cards but I could be mistaken.

There are a number of cards showing the "\r\n" that Slapshot mentions. If the second copy was being added somewhere in the getText() method then these symbols should be replaced.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: SVN Bug Reports

Postby Sloth » 05 Jun 2011, 08:14

The problem with duplicate spell texts comes from cards with:
A. "SpellAbility XXX = new Spell(card)" and
B. "card.addSpellAbility(XXX);"

just put "XXX.setDescription("");" before B and the duplicate is gone (But maybe the stack description too).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby slapshot5 » 05 Jun 2011, 09:21

Sloth wrote:The problem with duplicate spell texts comes from cards with:
A. "SpellAbility XXX = new Spell(card)" and
B. "card.addSpellAbility(XXX);"

just put "XXX.setDescription("");" before B and the duplicate is gone (But maybe the stack description too).
What happened? It never used to be this way?

And this works on Siren's Call for example, but on Clone, this forced the getStackDescription() text to be added to the card.

-slapshot5
slapshot5
Programmer
 
Posts: 1391
Joined: 03 Jan 2010, 17:47
Location: Mac OS X
Has thanked: 25 times
Been thanked: 68 times

Re: SVN Bug Reports

Postby Sloth » 05 Jun 2011, 10:47

friarsol wrote:Has anyone noticed the AI properly paying mana for CounterMagic with UnlessCosts? I just Condescend -ed his spell for 3, it resolved (allowing me to Scry) but then the Spell still resolved. The AI only had 2 mana available, and neither land is now tapped.
I just did a test with Mana Leak and it worked (both without paying and with paying). It must be a problem with the X cost.
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby friarsol » 05 Jun 2011, 11:31

slapshot5 wrote:
Sloth wrote:The problem with duplicate spell texts comes from cards with:
A. "SpellAbility XXX = new Spell(card)" and
B. "card.addSpellAbility(XXX);"

just put "XXX.setDescription("");" before B and the duplicate is gone (But maybe the stack description too).
What happened? It never used to be this way?
I can't say for those, but I wonder if some of the other ones have to do with my converting some Auras to be Spell_Permanents.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby Sloth » 05 Jun 2011, 12:33

friarsol wrote:Has anyone noticed the AI properly paying mana for CounterMagic with UnlessCosts? I just Condescend -ed his spell for 3, it resolved (allowing me to Scry) but then the Spell still resolved. The AI only had 2 mana available, and neither land is now tapped.
I tested Condescend and it also worked (both without paying and with paying).
User avatar
Sloth
Programmer
 
Posts: 3498
Joined: 23 Jun 2009, 19:40
Has thanked: 125 times
Been thanked: 507 times

Re: SVN Bug Reports

Postby friarsol » 05 Jun 2011, 14:16

Sloth wrote:I tested Condescend and it also worked (both without paying and with paying).
Alright good. Must just be my local changes. I didn't think it would affect that, but wasn't sure.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: SVN Bug Reports

Postby goonjamin » 05 Jun 2011, 20:47

r9307
Hi, I receive the error in the attached jpg when trying to launch this SVN revision with the forge.exe that comes with build scripts? All my previous builds up to yesterday worked fine? Any idea how I can fix this?

error.jpg


Here is a little more info on the error when I try to run via the command line.

Code: Select all
C:\Users\Mike\Downloads\forge>java -Xmx1024m -jar run-forge.jar
Exception in thread "main" java.lang.NoClassDefFoundError: forge/BoosterDraft
Caused by: java.lang.ClassNotFoundException: forge.BoosterDraft
        at java.net.URLClassLoader$1.run(Unknown Source)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
        at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
        at java.lang.ClassLoader.loadClass(Unknown Source)
Could not find the main class: forge.Gui_NewGame. Program will exit.
goonjamin
 
Posts: 133
Joined: 19 Aug 2010, 19:51
Has thanked: 39 times
Been thanked: 5 times

Re: SVN Bug Reports

Postby friarsol » 06 Jun 2011, 00:06

r9314
Pupeteer Clique doesn't seem to give Raised Creature Haste or Exile keywords. Probably has to do with the fact the Target happens before a ChangeZone

Also, my 3/3 Mindless Automaton took 2 Wither damage, and now it has 3 +1/+1 counters and 2 -1/-1 counters. It should only have 1 +1/+1 Counter.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 18 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 18 users online :: 0 registered, 0 hidden and 18 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 18 guests

Login Form