Collectible Card Game Headquarters

Problem:
Keywords are not updated right after the Platinum Emperion has been exiled. Swords to Plowshares keeps resolving and cannot add life to former creature controller.

Solution:
Call forge.game.GameAction.checkStaticAbilities() more frequently... somewhere inside forge.card.ability.AbilityUtils.resolveApiAbility(SpellAbility, boolean, GameState) before proceeding to subabilities.

Won't it ruin anything important?

Max mtg wrote:Won't it ruin anything important?

I think it's a necessary step that has to be done sooner or later. Let's see how many bugs pop up.

I think certain things should only be run in the current timeframes. Like SA granting abilities and triggers (are they called from there right now?)

friarsol wrote:I think certain things should only be run in the current timeframes. Like SA granting abilities and triggers (are they called from there right now?)

Max wants to run checkStaticAbilities which only updates continuous static abilities. checkStateEffects is the beast that should not be called carelessly.

Sloth wrote:

friarsol wrote:I think certain things should only be run in the current timeframes. Like SA granting abilities and triggers (are they called from there right now?)

Max wants to run checkStaticAbilities which only updates continuous static abilities. checkStateEffects is the beast that should not be called carelessly.

Ah good. Ok, I was worried for a few minutes there.

Commited: r21511

Same starting conditions, but with Elesh Norn, Grand Cenobite on table
Should I get 10 lives? (Actually forge gives 8 - it did so even in 1.4.2 beta)

Max mtg wrote:Same starting conditions, but with Elesh Norn, Grand Cenobite on table
Should I get 10 lives? (Actually forge gives 8 - it did so even in 1.4.2 beta)

It should be taking LKI of the Emperion, which is 10. "10/1/2008: The amount of life that's gained is equal to the power of the targeted creature as it last existed on the battlefield."

friarsol wrote:

Max mtg wrote:Same starting conditions, but with Elesh Norn, Grand Cenobite on table
Should I get 10 lives? (Actually forge gives 8 - it did so even in 1.4.2 beta)

It should be taking LKI of the Emperion, which is 10. "10/1/2008: The amount of life that's gained is equal to the power of the targeted creature as it last existed on the battlefield."

Fixed with r22456.