Sorin Markov Playtesting

[friarsol]

Ok, firstly thanks Max for all the hard work into getting Controlling of the Opponent's turn.

Here's some brief observations and specific ideas:

Things I like:
- The fact that this may be available soon, people have been asking for it for years.
- Generate Mana DevMode generating for the priority player.

Issues/Concerns
- I was testing with the Tibalt deck that I have, but was confused how cards like Browbeat were working with it. When I cast Blazing Salvo it just said "Do you want to..." but I don't know who "You" is. I expected to be asked twice (once for each player I controlled), but was only asked once (assumably for the Player I "owned" if you will.
- I know it says who is Priority in the Input box, but it may be good to have some type of color highlighting in the player panel to show who has Priority? Maybe a little puck that overlays the Player image? Yes, this is a feature request and something that doesn't exist right now. This is mostly to ease the use of cards that either player can activate (I believe Sloth has been using Feral Hydra as his example.) But honestly it's fairly low priority

Related:
- I know this isn't related to Sorin specifically, but it is related to Hot Seat play. It seems like we should allow the Human to name him/herself. Probably through the Preference panel for the default name, and then to be able to choose (or generate) a name for the second human.

I'll do a little research about cards that interact oddly with Mindslaver and give those a test too if I have a chance.

[moomarc]

One thing that probably won't work at the moment is cards that make a player skip his/her turn. The problem isn't with the control player ability (not yet at least although it might yet become one) - instead the current implementation of skip turn is still based on there only being two players so the first player is given an extra turn rather than a target skipping a turn. We'd needs skipTurn ability and we could then check whether the control of the turn is then correctly allocated to the next turn that the player actually has.

[Max mtg]

Yes, can release it in 3.17

Test list:
1. Karn Liberated (both per se and restart game while controlled by other player)
2. Game loss / game win should restore control.