MagicStack.add

[Max mtg]

There is such code at the end of MagicStack.add(SpellAbility sa)

Code: Select all

        if (!this.getSimultaneousStackEntryList().isEmpty()) {
            game.getPhaseHandler().passPriority();
        }

What is its purpose?

[friarsol]

I believe simultaneousStackEntryList is keeping track of what triggers are hitting the stack at the same time for ordering (or at least was many a moon ago). I'm not sure why you would be passing priority if that were empty.

[Max mtg]

Well, there is no longer passPriority method... so I cannot sustain this code.

If there's a repro when current code won't work, please write it here or file as a bugreport.

[Max mtg]

Found a repro : cast Bloodbraid Elf.
But it should not pass priority in that case - when Cascade trigger is added to stack

I commited r21786, seems to work as it should