Can remove some steps

[Max mtg]

With new phase loop we can remove COMBAT_DECLARE_ATTACKERS_INSTANT_ABILITY and COMBAT_DECLARE_BLOCKERS_INSTANT_ABILITY steps.
Turn-based actions will be executed from onPhaseBegin, and then after triggers are ordered and put on stack the system will give each player priority.

Also, this will make scripting of Odric, Master Tactician easier.

[friarsol]

Ah nice. This will require certain cards to update their scripts. But definitely a good change.

[swordshine]

Nice！

[Max mtg]

I have commited the code that removes the named steps - r21895

[swordshine]

I have commited the code that removes the named steps - r21895

Shall we remove all the " - Play Instants and Abilities" in card scripts?

[moomarc]

Going to have to remove them otherwise the condition checks will fail

[Max mtg]

I have commited the code that removes the named steps - r21895

Shall we remove all the " - Play Instants and Abilities" in card scripts?

How do you find any of these in scripts?
There are no matches in *.txt files on "INSTANT_ABILITY" case-insensitive search

[swordshine]

I have commited the code that removes the named steps - r21895

Shall we remove all the " - Play Instants and Abilities" in card scripts?

How do you find any of these in scripts?
There are no matches in *.txt files on "INSTANT_ABILITY" case-insensitive search

Just search "Declare Attackers - Play Instants and Abilities" and "Declare Blockers - Play Instants and Abilities" in *.txt