Page 1 of 1

Can remove some steps

PostPosted: 02 Jun 2013, 00:30
by Max mtg
With new phase loop we can remove COMBAT_DECLARE_ATTACKERS_INSTANT_ABILITY and COMBAT_DECLARE_BLOCKERS_INSTANT_ABILITY steps.
Turn-based actions will be executed from onPhaseBegin, and then after triggers are ordered and put on stack the system will give each player priority.

Also, this will make scripting of Odric, Master Tactician easier.

Re: Can remove some steps

PostPosted: 02 Jun 2013, 00:59
by friarsol
Ah nice. This will require certain cards to update their scripts. But definitely a good change.

Re: Can remove some steps

PostPosted: 02 Jun 2013, 01:15
by swordshine
Nice!

Re: Can remove some steps

PostPosted: 02 Jun 2013, 06:42
by Max mtg
I have commited the code that removes the named steps - r21895

Re: Can remove some steps

PostPosted: 02 Jun 2013, 07:52
by swordshine
Max mtg wrote:I have commited the code that removes the named steps - r21895
Shall we remove all the " - Play Instants and Abilities" in card scripts?

Re: Can remove some steps

PostPosted: 02 Jun 2013, 08:12
by moomarc
Going to have to remove them otherwise the condition checks will fail

Re: Can remove some steps

PostPosted: 02 Jun 2013, 08:32
by Max mtg
swordshine wrote:
Max mtg wrote:I have commited the code that removes the named steps - r21895
Shall we remove all the " - Play Instants and Abilities" in card scripts?
How do you find any of these in scripts?
There are no matches in *.txt files on "INSTANT_ABILITY" case-insensitive search

Re: Can remove some steps

PostPosted: 02 Jun 2013, 08:37
by swordshine
Max mtg wrote:
swordshine wrote:
Max mtg wrote:I have commited the code that removes the named steps - r21895
Shall we remove all the " - Play Instants and Abilities" in card scripts?
How do you find any of these in scripts?
There are no matches in *.txt files on "INSTANT_ABILITY" case-insensitive search
Just search "Declare Attackers - Play Instants and Abilities" and "Declare Blockers - Play Instants and Abilities" in *.txt