The doctor is in

[Hellfish]

I just made a Bad Moon pump blue creatures instead of black using a slightly incorrect but working Trait Doctoring...Oh yeah.

I can't create a branch for it til work's over but in the meantime I can do research Keyword handling will need to be altered for keywords that contain card types, basic land types or colors to match even if thatext is changed.Are there any such keywords outside of -walk/protection?

It's looking like only valids(done?), keywords and a couple of AF's need changing to begin with before getting to mucking with spell text.

Oh, and when all is said and done this should all work as a StaticAbility. It currently doesn't because debug.

[swordshine]

Wow! Glad to hear we are implementing the last card of RTR block.
The other keywords containing colors are:
K:CantBeBlockedBy Creature.Red (Barrenton Cragtreads,Sacred Knight)
K:Enchant red or green creature (Controlled Instincts,Mind Harness)
K:CARDNAME can't be blocked by red creatures.(Elder Spawn,Fylamarid)
K:CARDNAME can't be the target of red spells or abilities from red sources.(Suq'Ata Firewalker)
K:Permanents don't untap during their controllers' untap steps:Creature.Red(Wrath of Marit Lage)
K:CantBlock Creature.Black(Gibbering Hyenas,Orcish Veteran)
K:CARDNAME can't be the target of black spells.(Karplusan Strider)
K:CARDNAME can't attack unless defending player controls a blue permanent.(Whimwader)
and cost in the keyword K:Flashback tapXType<3/Creature.White/white creature> (Battle Screech,Hundred-Talon Strike,Prismatic Strands,Veil of Secrecy)

basic land types:
K:CARDNAME enters the battlefield tapped unless you control a Mountain or a Plains.(Clifftop Retreat)
K:TypeCycling:Plains:2(Eternal Dragon)
K:Enchant Plains(Genju of the Fields)
K:CARDNAME can't attack unless defending player controls an Island.(Armored Galleon)
K:Permanents don't untap during their controllers' untap steps:Island(Choke)

keyword with cost, K:Morph:Return<2/Island>(Fathom Seer,Walk the Aeons)

[Hellfish]

Thanks! It looks like most of those are handled by the changes to valids already

[timmermac]

Is it just me, or does this sound like we're a step closer to Magical Hack?

[friarsol]

Is it just me, or does this sound like we're a step closer to Magical Hack?

Since Trait Doctor is a non-permanent combination of Magical Hack and Slight of Mind, adding this card should allow a bunch more.

[Hellfish]

Hmm, I thought we had a way to determine wether a spellability is intrinsic to a card or not?

[Max mtg]

Which revision number?
Or is it just an announce?

[Hellfish]

I will create a branch either when I get an interaction worked out (the fact that granted abilities and keywords shouldn't get their text replaced) or when I turn in for the night. Either way I'll post here.

EDIT:They *shouldn't* get their text replaced.Derp.

[Hellfish]

Alright, err, I have *attempted* a branch but I don't know if it went through alright, net's really weird about it. Try it out and see *crosses fingers*

[Max mtg]

looks like you've added only the changed files into the branch.

I've seen a fourth parameter to isValid(...) and that makes me upset. I am totally confused with all that intrinsic (wish I've spelled the word correctly) and external abilities, and failed to understand how it works.
If it was the moment of initial design I would never keep any abilities granted by other (external) static abilities on the same card.

It looks like I can't be of any help (or just welcome the changes) - ok, we'll clean it up later... probably.
It also looks like I need to write Forge code less and breath fresh air more, so I'd better take a vacation for the next week.

[Hellfish]

Well, damn it, that didn't work... Try 2 sometime this weekend hopefully.

EDIT: OK, Change of plans, Will introduce IC ardTrait wich will be implemented by triggers, replacementseffetcts, spellabilities, keywords (they will be turned into objects) and expose methods that returns if the trait is intrinsic and its sourcecard. Traits will then pass themselves instead of a card and a player into isValid.This preserves previous functionality while giving text replacement what it needs and avoids cluttering