It is currently 30 Oct 2025, 02:01
   
Text Size

Modern Masters Patch

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Agetian, friarsol, Blacksmith, KrazyTheFox, CCGHQ Admins

Modern Masters Patch

Postby carpeamentum » 07 Jun 2013, 21:47

So, as I was interested in drafting some Modern Masters on Forge, and since MM is just a reprint set, I just set upon making the changes on the config files necessary to make it work.

In doing so I found one card that is not implemented as far as I can tell is Test of Faith.

So, except for that one, I appear to have Modern Masters working.

I attached a patch file that should cooperate with the source directories.
Attachments
ModernMasters.zip
Zipped patch file to enable the Modern Masters set
(26.01 KiB) Downloaded 406 times
carpeamentum
 
Posts: 18
Joined: 03 Jun 2012, 15:34
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby Max mtg » 07 Jun 2013, 22:43

Hi, carpeamentum.

It's good to see you've patched 1.4.0 to support MMA.

When it came to adding the new expansion to SVN version I looked at the amount of work it would need (that is change every affected card script) and realized that It was a too complicate way to add new expansions.

This is why I have changed the rules that add a certain card to an edition. The changes in every card's script are no longer needed, instead a set description file is used - it looks like this: http://svn.slightlymagic.net/websvn/fil ... asters.txt
All SetInfo lines in card scripts are now obsolette and ignored by parser.

This thread might also be of interest for you: viewtopic.php?f=26&t=10565


As for cards coverage - here's the quote:
Code: Select all
Modern Masters (229 cards) ... 99,12% (2 cards missing: Test of Faith | Kira, Great Glass-Spinner)
Last edited by Max mtg on 07 Jun 2013, 23:08, edited 1 time in total.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Modern Masters Patch

Postby carpeamentum » 07 Jun 2013, 23:17

Are you sure they are ignored? My additions worked. Perhaps that edition definition was already in there? I am away from the files I used at the moment though, so I can't say for sure.
carpeamentum
 
Posts: 18
Joined: 03 Jun 2012, 15:34
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby Max mtg » 07 Jun 2013, 23:19

Depends on the sources version you have
1.4.0 still uses the old format.
1.4.1+ will rely on expansion definition files
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: Modern Masters Patch

Postby carpeamentum » 07 Jun 2013, 23:21

Ah. That makes sense then.
carpeamentum
 
Posts: 18
Joined: 03 Jun 2012, 15:34
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby Tygrak » 10 Jun 2013, 13:26

I am a total noob in these things, so could anyone direct me how to get modern masters draft working using that .patch thing file?
Tygrak
 
Posts: 18
Joined: 02 Feb 2013, 10:52
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby Tygrak » 10 Jun 2013, 18:03

Please? *bump*
Tygrak
 
Posts: 18
Joined: 02 Feb 2013, 10:52
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby carpeamentum » 10 Jun 2013, 18:20

Quick version:

unzip \res\cardsfolder\cardsfolder.zip to \res\cardsfolder\cardsfolder

apply patch (search for how to apply patch files on windows, assuming you are on windows)
(there is a linux program called "patch" .. I think there might be a windows version.. otherwise you could use look into cygwin to be able to run patch)

then re-zip up \res\cardsfolder\cardsfolder to \res\cardsfolder\cardsfolder.zip
carpeamentum
 
Posts: 18
Joined: 03 Jun 2012, 15:34
Has thanked: 0 time
Been thanked: 0 time

Re: Modern Masters Patch

Postby friarsol » 10 Jun 2013, 18:25

Tygrak wrote:Please? *bump*
Please don't bump posts 4 hours after you post them. Not everyone is around to answer questions that quickly.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Modern Masters Patch

Postby Tygrak » 10 Jun 2013, 18:34

carpeamentum wrote:Quick version:

unzip \res\cardsfolder\cardsfolder.zip to \res\cardsfolder\cardsfolder

apply patch (search for how to apply patch files on windows, assuming you are on windows)
(there is a linux program called "patch" .. I think there might be a windows version.. otherwise you could use look into cygwin to be able to run patch)

then re-zip up \res\cardsfolder\cardsfolder to \res\cardsfolder\cardsfolder.zip
Thanks alot!
Tygrak
 
Posts: 18
Joined: 02 Feb 2013, 10:52
Has thanked: 0 time
Been thanked: 0 time


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 12 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 12 users online :: 0 registered, 0 hidden and 12 guests (based on users active over the past 10 minutes)
Most users ever online was 9298 on 10 Oct 2025, 12:54

Users browsing this forum: No registered users and 12 guests

Login Form