Page 1 of 1

Modern Masters Patch

PostPosted: 07 Jun 2013, 21:47
by carpeamentum
So, as I was interested in drafting some Modern Masters on Forge, and since MM is just a reprint set, I just set upon making the changes on the config files necessary to make it work.

In doing so I found one card that is not implemented as far as I can tell is Test of Faith.

So, except for that one, I appear to have Modern Masters working.

I attached a patch file that should cooperate with the source directories.

Re: Modern Masters Patch

PostPosted: 07 Jun 2013, 22:43
by Max mtg
Hi, carpeamentum.

It's good to see you've patched 1.4.0 to support MMA.

When it came to adding the new expansion to SVN version I looked at the amount of work it would need (that is change every affected card script) and realized that It was a too complicate way to add new expansions.

This is why I have changed the rules that add a certain card to an edition. The changes in every card's script are no longer needed, instead a set description file is used - it looks like this: http://svn.slightlymagic.net/websvn/fil ... asters.txt
All SetInfo lines in card scripts are now obsolette and ignored by parser.

This thread might also be of interest for you: viewtopic.php?f=26&t=10565


As for cards coverage - here's the quote:
Code: Select all
Modern Masters (229 cards) ... 99,12% (2 cards missing: Test of Faith | Kira, Great Glass-Spinner)

Re: Modern Masters Patch

PostPosted: 07 Jun 2013, 23:17
by carpeamentum
Are you sure they are ignored? My additions worked. Perhaps that edition definition was already in there? I am away from the files I used at the moment though, so I can't say for sure.

Re: Modern Masters Patch

PostPosted: 07 Jun 2013, 23:19
by Max mtg
Depends on the sources version you have
1.4.0 still uses the old format.
1.4.1+ will rely on expansion definition files

Re: Modern Masters Patch

PostPosted: 07 Jun 2013, 23:21
by carpeamentum
Ah. That makes sense then.

Re: Modern Masters Patch

PostPosted: 10 Jun 2013, 13:26
by Tygrak
I am a total noob in these things, so could anyone direct me how to get modern masters draft working using that .patch thing file?

Re: Modern Masters Patch

PostPosted: 10 Jun 2013, 18:03
by Tygrak
Please? *bump*

Re: Modern Masters Patch

PostPosted: 10 Jun 2013, 18:20
by carpeamentum
Quick version:

unzip \res\cardsfolder\cardsfolder.zip to \res\cardsfolder\cardsfolder

apply patch (search for how to apply patch files on windows, assuming you are on windows)
(there is a linux program called "patch" .. I think there might be a windows version.. otherwise you could use look into cygwin to be able to run patch)

then re-zip up \res\cardsfolder\cardsfolder to \res\cardsfolder\cardsfolder.zip

Re: Modern Masters Patch

PostPosted: 10 Jun 2013, 18:25
by friarsol
Tygrak wrote:Please? *bump*
Please don't bump posts 4 hours after you post them. Not everyone is around to answer questions that quickly.

Re: Modern Masters Patch

PostPosted: 10 Jun 2013, 18:34
by Tygrak
carpeamentum wrote:Quick version:

unzip \res\cardsfolder\cardsfolder.zip to \res\cardsfolder\cardsfolder

apply patch (search for how to apply patch files on windows, assuming you are on windows)
(there is a linux program called "patch" .. I think there might be a windows version.. otherwise you could use look into cygwin to be able to run patch)

then re-zip up \res\cardsfolder\cardsfolder to \res\cardsfolder\cardsfolder.zip
Thanks alot!