Collectible Card Game Headquarters

Are you trying to go through a proxy? A quick web search on the "RA layer request failed" seems to be most related to proxy settings.

I almost never use the Subclipse anymore. I prefer to use TortoiseSVN. I think the interface is more intuitive.

ArsenalNut wrote:Are you trying to go through a proxy? A quick web search on the "RA layer request failed" seems to be most related to proxy settings.

I almost never use the Subclipse anymore. I prefer to use TortoiseSVN. I think the interface is more intuitive.

I've had RA layer request failures when my internet connection is bogged down in the past.

I've sort of figured it out.

I tried different clients, including plain command line. Kept getting the same error message, in different places. But I also noticed that my external drive was rather slow when it had to deal with a gazillion small files. I started suspecting that this could be the problem.

So I tried the command-line SVN on the internal HD. It downloaded the whole source in no time. So apparently the external USB HD was too slow, the connection just died on me because of that.

Now I just need to figure out how to import the downloaded sources to my external portable Eclipse environment. I tried the obvious thing, i.e. copied the files over the incomplete version in my workspace (on the external HD) but they don't show up in Eclipse. The only thing I see when I launch Eclipse is the interrupted incomplete download.

Awww, never mind. It was just silly me forgetting to Refresh.

I've got the Java source up and running, although there was no class "Gui_NewGame - Forge" (as per http://www.slightlymagic.net/wiki/Forge ... ping_Forge ). I launched "main - Forge.view" instead.

Now I can really start inspecting what makes the game tick...

RumbleBBU wrote:I've got the Java source up and running, although there was no class "Gui_NewGame - Forge" (as per http://www.slightlymagic.net/wiki/Forge ... ping_Forge ). I launched "main - Forge.view" instead.

 
I get this several times each month. There is a brief section in the troubleshooting section dealing with this issue.

I wanted to let you know, guys, that closer to the end of the year I may return as a more or less full-time contributor to the SVN codebase of Forge (I used to help with a few things in the past, namely the borders of cards, quest deck sets, and developer mode testing facilities). Currently I'm overly busy with work, but when I have spare time, I'm reading up on Java (because I'm more of a C/C++ coder) and learning to use the features of the language that are different or new compared to C/C++. I should be ready as a full-fledged Java developer closer to the end of the year. I have a few questions in the meantime (I've been reading this page and some of the wiki, but I've found some of the material not to be detailed enough or a bit outdated, maybe I was looking in the wrong place). Can you please tell me:

1. If there is a list of coding standards anywhere, like, what coding style to use, any recommendations on use (or prohibition of use) of certain methods, libraries, techniques, etc. If so, I'd like to read that to make sure I collaborate in the fashion that would be expected of me.
2. Is there any introduction to the structure of code? I recall having a very hard time looking for the class that drew cards (to add the borders), if there is any guide as to how the classes are organized and structured and where to generally look for different things (e.g. the implementation of card facilities, the implementation of the interface, etc.), I'd love to check it out.
3. Are the SVN checkout/commit instructions on the Wiki up to date and still working? I was able to get my copy of Eclipse up and running and I checked out and compiled the Forge repo, but I'm not sure if committing stuff into the SVN repo would still work the old way (probably, but just checking - currently I don't have commit permissions but I'll apply for them closer to the time when I'm ready to actually commit).
4. Is there any central documentation/list available anywhere related to who is currently doing what? Just to avoid duplication of effort, it might be a good idea to see what projects are currently in progress and who is working on them, to see that either I'm working on something no one's working on or I can talk to the proper person regarding an aspect of Forge that I'd like to help with.
5. Is the information on card scriting facilities up to date? If not, what would be the best approach to learn how to implement a new feature in card scripting (e.g. code a type of card not currently supported in Forge) or to add a new card?

Thank you kindly in advance for your help in this respect! See you guys soon!

1.Generally follow Checkstyle and Java conventions.Also, certain methods are being phased out in favour of Multiplayer-compatible versions so look out for that.Limit singleton usage?
2.Not that I know of,no, but I think much of the code has been sorted into packages better since then.
3.They should be good. ttdic managed to check out and build Forge using those with just a single correction by Chris. I think that's a record.
4.Not anymore. There was a topic but it's fallen into the forum depths.Pretty much everyone is working on multiplayer compatibility,though, it's pretty safe to assume. I was tinkering with the Offering abilities but havn't made much headway so no biggie either way.
5.Err, some of the info on the wiki is old or missing, but alot of it is good.Sol's been updating it recently, too.

Best of luck!

Hellfish wrote:1.Generally follow Checkstyle and Java conventions.Also, certain methods are being phased out in favour of Multiplayer-compatible versions so look out for that.Limit singleton usage?
2.Not that I know of,no, but I think much of the code has been sorted into packages better since then.
3.They should be good. ttdic managed to check out and build Forge using those with just a single correction by Chris. I think that's a record.
4.Not anymore. There was a topic but it's fallen into the forum depths.Pretty much everyone is working on multiplayer compatibility,though, it's pretty safe to assume. I was tinkering with the Offering abilities but havn't made much headway so no biggie either way.
5.Err, some of the info on the wiki is old or missing, but alot of it is good.Sol's been updating it recently, too.
Best of luck!

Thanks for your reply, I'll look around and check out the newer version of the code and the updates docs on the wiki!

By the way, is it only possible to use Eclipse for Forge development or is NetBeans a viable option? I noticed that the wiki documentation mentions NetBeans but covers only the installation of all the necessary tools for Eclipse, which is a bit of a bummer cause NetBeans feels faster and cleaner as far as an IDE goes (that's subjective, of course, tastes differ). But anyway, would it be possible for me to configure NetBeans to work with Forge, or should I basically give up the whole idea and just stick to Eclipse? Do any of the active coders of Forge use NetBeans as an IDE of choice successfully? I'm flexible, so I can use Eclipse as a means to an end (especially if it's the only option or if configuring NB for Forge development would be a nightmare), but if it's practically possible to code Forge using NetBeans, I might actually look into switching over to that. Thanks in advance for help.

EDIT: In fact, nevermind - I tried NetBeans 7.2 and it worked seamlessly without any additional plugins or configuration, at least it allowed me to check out the project and built it with no errors whatsoever with its default configuration (no headache with m2e, subclipse, whatever). Unless there are any hidden dangers on the way, should be all good. Not sure how well committing would have worked, but checking out went surprisingly magically well. :\

Does Netbeans allow you to go to class declarations, etc? Right-click a class or method name and choose go to.

jeffwadsworth wrote:Does Netbeans allow you to go to class declarations, etc? Right-click a class or method name and choose go to.

Yep, does it without a problem.

Umm since I'm pretty much going through the Forge code base at the moment, trying to find out how various aspects of the game work, I might also start a document, like a table or something, where I'm going to outline different points of interest, such as location of various classes, certain methods and objects of interest (e.g. CardDb.insance(), Aggregates.random, etc.). It's likely that it won't be a detailed description of every single piece of code, of course, but it might be of some use for the people who might join the project in the future - do you think it'd be worth starting a thread for that here and then possibly later reworking it into a wiki page or set of wiki pages?

- Agetian

After a while, I decided to download the current sources and check out what's happening with Forge nowadays. I updated to Java 7, launched Eclipse, Refresh, Clean all projects, and...

...can't compile.
First I'm getting a "build.properties does not exist", some complaints about Maven dependencies related to maven-resources-plugin and maven-compiler-plugin, and lots of errors about undefined and unresolvable stuff (propably a result of the the first two problems).

I tried updating the Maven dependencies and resources but keep getting the same result. Can anyone suggest where to look for a solution? My setup (Eclipso Indigo + Java 7) compiles and runs the older version of Forge sources from around April just fine. But the fresh trunk archive gives me the problems.

Here's the boring complete list of errors:

| Open

Description Resource Path Location Type
build.properties does not exist ForgeLocal Unknown Plug-in Problem
Cannot instantiate the type LobbyPlayer Lobby.java /ForgeLocal/src/main/java/forge/control line 65 Java Problem
Cannot instantiate the type LobbyPlayer Lobby.java /ForgeLocal/src/main/java/forge/control line 75 Java Problem
Cannot instantiate the type LobbyPlayer Lobby.java /ForgeLocal/src/main/java/forge/control line 99 Java Problem
Cannot override the final method from Player AIPlayer.java /ForgeLocal/src/main/java/forge/game/player line 215 Java Problem
Cannot override the final method from Player HumanPlayer.java /ForgeLocal/src/main/java/forge/game/player line 192 Java Problem
CARDFORGE_URL cannot be resolved or is not a field CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 263 Java Problem
CARDFORGE_URL cannot be resolved or is not a field CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 278 Java Problem
CARDFORGE_URL cannot be resolved or is not a field CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 288 Java Problem
CARDFORGE_URL cannot be resolved or is not a field CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 298 Java Problem
COMBAT_DECLARE_ATTACKERS_INSTANT_ABILITY cannot be resolved or is not a field CombatUtil.java /ForgeLocal/src/main/java/forge/game/phase line 1142 Java Problem
Execution default-compile of goal org.apache.maven.plugins:maven-compiler-plugin:3.0:compile failed: Plugin org.apache.maven.plugins:maven-compiler-plugin:3.0 or one of its dependencies could not be resolved: Failed to collect dependencies for org.apache.maven.plugins:maven-compiler-plugin:jar:3.0 () (org.apache.maven.plugins:maven-compiler-plugin:3.0:compile:default-compile:compile) pom.xml /ForgeLocal line 320 Maven Build Problem
Execution default-testCompile of goal org.apache.maven.plugins:maven-compiler-plugin:3.0:testCompile failed: Plugin org.apache.maven.plugins:maven-compiler-plugin:3.0 or one of its dependencies could not be resolved: Failed to collect dependencies for org.apache.maven.plugins:maven-compiler-plugin:jar:3.0 () (org.apache.maven.plugins:maven-compiler-plugin:3.0:testCompile:default-testCompile:test-compile) pom.xml /ForgeLocal line 320 Maven Build Problem
FN_GET_TYPE cannot be resolved or is not a field MatchController.java /ForgeLocal/src/main/java/forge/game line 144 Java Problem
GenerateDeckUtil.CanBePaidWithColors cannot be resolved to a type LimitedDeck.java /ForgeLocal/src/main/java/forge/game/limited line 104 Java Problem
GenerateDeckUtil.CanBePaidWithColors cannot be resolved to a type LimitedDeck.java /ForgeLocal/src/main/java/forge/game/limited line 440 Java Problem
IDENTITY_PICK cannot be resolved or is not a field SealedDeckFormat.java /ForgeLocal/src/main/java/forge/game/limited line 81 Java Problem
IMAGE_BASE cannot be resolved or is not a field CopyFiles.java /ForgeLocal/src/main/java/forge/util line 99 Java Problem
IMAGE_BASE cannot be resolved or is not a field GuiImportPicture.java /ForgeLocal/src/main/java/forge/gui line 132 Java Problem
IMAGE_BASE cannot be resolved or is not a field GuiImportPicture.java /ForgeLocal/src/main/java/forge/gui line 226 Java Problem
IMAGE_BASE cannot be resolved or is not a field GuiImportPicture.java /ForgeLocal/src/main/java/forge/gui line 327 Java Problem
Incompatible operand types String and int QuestEventManager.java /ForgeLocal/src/main/java/forge/quest line 457 Java Problem
Lang cannot be resolved or is not a field ForgeProps.java /ForgeLocal/src/main/java/forge/properties line 164 Java Problem
MANA_COLORS cannot be resolved or is not a field InputPayManaBase.java /ForgeLocal/src/main/java/forge/control/input line 143 Java Problem
Name cannot be resolved or is not a field InputPassPriority.java /ForgeLocal/src/main/java/forge/control/input line 61 Java Problem
PhaseLabel cannot be resolved to a type PhaseUtil.java /ForgeLocal/src/main/java/forge/game/phase line 267 Java Problem
PREFS_MAIN_PROPERTIES_FILE cannot be resolved or is not a field ForgeProps.java /ForgeLocal/src/main/java/forge/properties line 47 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field DeckLister.java /ForgeLocal/src/main/java/forge/gui/toolbox line 426 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field DeckLister.java /ForgeLocal/src/main/java/forge/gui/toolbox line 431 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field DeckLister.java /ForgeLocal/src/main/java/forge/gui/toolbox line 438 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field DeckLister.java /ForgeLocal/src/main/java/forge/gui/toolbox line 444 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field InputBlock.java /ForgeLocal/src/main/java/forge/control/input line 109 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field InputPassPriority.java /ForgeLocal/src/main/java/forge/control/input line 77 Java Problem
SINGLETON_INSTANCE cannot be resolved or is not a field MatchController.java /ForgeLocal/src/main/java/forge/game line 145 Java Problem
The constructor AbilityActivated(Card, Cost, Target) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 45 Java Problem
The constructor AbilityActivated(Card, Cost, Target) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 115 Java Problem
The constructor AbilityActivated(Card, Cost, Target) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 258 Java Problem
The constructor AiAttackController(AIPlayer, Player) is undefined AiInputCommon.java /ForgeLocal/src/main/java/forge/game/ai line 118 Java Problem
The constructor BoosterGenerator(Collection<CardPrinted>) is undefined SealedDeckFormat.java /ForgeLocal/src/main/java/forge/game/limited line 69 Java Problem
The constructor BoosterGenerator(ItemPoolView<PaperCard>) is undefined SealedDeckFormat.java /ForgeLocal/src/main/java/forge/game/limited line 276 Java Problem
The constructor Cost(Card, String, boolean) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 99 Java Problem
The constructor Cost(Card, String, boolean) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 186 Java Problem
The constructor Cost(Card, String, boolean) is undefined CardFactoryArtifacts.java /ForgeLocal/src/main/java/forge/card/cardfactory line 305 Java Problem
The constructor Cost(Card, String, boolean) is undefined CardFactorySorceries.java /ForgeLocal/src/main/java/forge/card/cardfactory line 616 Java Problem
The constructor Cost(Card, String, boolean) is undefined CombatUtil.java /ForgeLocal/src/main/java/forge/game/phase line 1116 Java Problem
The constructor Cost(Card, String, boolean) is undefined GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 397 Java Problem
The constructor CostPayment(Cost, SpellAbility, GameState) is undefined GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 84 Java Problem
The constructor CostPayment(Cost, SpellAbility, GameState) is undefined GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 397 Java Problem
The constructor CostPayment(Cost, SpellAbility, GameState) is undefined GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 399 Java Problem
The constructor CostPayment(Cost, SpellAbility, GameState) is undefined GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 441 Java Problem
The constructor EndOfTurn(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 118 Java Problem
The constructor GameAction(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 110 Java Problem
The constructor HttpUtil() is not visible CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 262 Java Problem
The constructor HttpUtil() is not visible CardRatings.java /ForgeLocal/src/main/java/forge/game/limited line 274 Java Problem
The constructor MagicStack(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 112 Java Problem
The constructor Phase(GameState) is undefined Cleanup.java /ForgeLocal/src/main/java/forge/game/phase line 35 Java Problem
The constructor Phase(GameState) is undefined EndOfCombat.java /ForgeLocal/src/main/java/forge/game/phase line 35 Java Problem
The constructor PhaseHandler(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 113 Java Problem
The constructor Player(LobbyPlayer, GameState) is undefined AIPlayer.java /ForgeLocal/src/main/java/forge/game/player line 57 Java Problem
The constructor Player(LobbyPlayer, GameState) is undefined HumanPlayer.java /ForgeLocal/src/main/java/forge/game/player line 56 Java Problem
The constructor PlayerControllerAi(GameState, AIPlayer) is undefined AIPlayer.java /ForgeLocal/src/main/java/forge/game/player line 58 Java Problem
The constructor PlayerControllerHuman(GameState, HumanPlayer) is undefined HumanPlayer.java /ForgeLocal/src/main/java/forge/game/player line 58 Java Problem
The constructor ReplacementHandler() is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 79 Java Problem
The constructor Spell(Card, Cost, null) is undefined CardFactorySorceries.java /ForgeLocal/src/main/java/forge/card/cardfactory line 617 Java Problem
The constructor SpellAbility(null) is undefined InputPayManaExecuteCommands.java /ForgeLocal/src/main/java/forge/control/input line 97 Java Problem
The constructor StaticEffects() is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 77 Java Problem
The constructor TriggerHandler() is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 78 Java Problem
The constructor UnOpenedProduct(Function<BoosterGenerator,List<CardPrinted>>, BoosterGenerator) is undefined SealedDeckFormat.java /ForgeLocal/src/main/java/forge/game/limited line 301 Java Problem
The constructor Untap(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 115 Java Problem
The constructor Upkeep(GameState) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 116 Java Problem
The constructor ViewWinLose(MatchController) is undefined MatchController.java /ForgeLocal/src/main/java/forge/game line 117 Java Problem
The constructor Zone(ZoneType) is undefined GameState.java /ForgeLocal/src/main/java/forge/game line 87 Java Problem
The import forge.gui.match.nonsingleton.VField.PhaseLabel cannot be resolved PhaseUtil.java /ForgeLocal/src/main/java/forge/game/phase line 36 Java Problem
The import forge.properties.NewConstants.Lang cannot be resolved MatchController.java /ForgeLocal/src/main/java/forge/game line 36 Java Problem
The method add(Card) in the type CardPool is not applicable for the arguments (List<CardPrinted>) LimitedDeck.java /ForgeLocal/src/main/java/forge/game/limited line 176 Java Problem
The method add(Card) in the type CardPool is not applicable for the arguments (List<CardPrinted>) LimitedDeck.java /ForgeLocal/src/main/java/forge/game/limited line 178 Java Problem
The method add(Card) in the type CardPool is not applicable for the arguments (List<CardPrinted>) LimitedDeck.java /ForgeLocal/src/main/java/forge/game/limited line 179 Java Problem
The method add(GameLogEntryType, String) in the type GameLog is not applicable for the arguments (String, String, int) MatchController.java /ForgeLocal/src/main/java/forge/game line 100 Java Problem
The method add(GameLogEntryType, String) in the type GameLog is not applicable for the arguments (String, String, int) MatchController.java /ForgeLocal/src/main/java/forge/game line 107 Java Problem
The method add(GameLogEntryType, String) in the type GameLog is not applicable for the arguments (String, String, int) MatchController.java /ForgeLocal/src/main/java/forge/game line 114 Java Problem
The method add(GameLogEntryType, String) in the type GameLog is not applicable for the arguments (String, String, int) PhaseUtil.java /ForgeLocal/src/main/java/forge/game/phase line 238 Java Problem
The method add(Integer) in the type List<Integer> is not applicable for the arguments (String) QuestEventManager.java /ForgeLocal/src/main/java/forge/quest line 222 Java Problem
The method add(SpellAbility) in the type MagicStack is not applicable for the arguments (SpellAbility, boolean) GameActionPlay.java /ForgeLocal/src/main/java/forge/game line 98 Java Problem
The method add(UnOpenedProduct) in the type ArrayList<UnOpenedProduct> is not applicable for the arguments (IUnOpenedProduct) SealedDeckFormat.java /ForgeLocal/src/main/java/forge/game/limited line 207 Java Problem
The method addListToHash(SpellAbility, String) is undefined for the type CostDiscard InputPayDiscardCost.java /ForgeLocal/src/main/java/forge/control/input line 170 Java Problem
The method addListToHash(SpellAbility, String) is undefined for the type CostReturn InputPayReturnCost.java /ForgeLocal/src/main/java/forge/control/input line 171 Java Problem
The method addListToHash(SpellAbility, String) is undefined for the type CostSacrifice InputPaySacCost.java /ForgeLocal/src/main/java/forge/control/input line 172 Java Problem
The method addObserver(CStack) is undefined for the type MagicStack MatchController.java /ForgeLocal/src/main/java/forge/game line 157 Java Problem
The method addObserver(InputProxy) is undefined for the type MagicStack MatchController.java /ForgeLocal/src/main/java/forge/game line 154 Java Problem
The method addObserver(InputProxy) is undefined for the type PhaseHandler MatchController.java /ForgeLocal/src/main/java/forge/game line 155 Java Problem
The method addTarget(Card) from the type TargetChoices is not visible Target.java /ForgeLocal/src/main/java/forge/card/spellability line 354 Java Problem
The method addTarget(Player) from the type TargetChoices is not visible Target.java /ForgeLocal/src/main/java/forge/card/spellability line 358 Java Problem
The method addTarget(SpellAbility) from the type TargetChoices is not visible Target.java /ForgeLocal/src/main/java/forge/card/spellability line 362 Java Problem
The method addToList(Card) from the type CostPartWithList is not visible InputPayDiscardCost.java /ForgeLocal/src/main/java/forge/control/input line 131 Java Problem
The method addToList(Card) from the type CostPartWithList is not visible InputPayReturnCost.java /ForgeLocal/src/main/java/forge/control/input line 131 Java Problem
The method addToList(Card) from the type CostPartWithList is not visible InputPaySacCost.java /ForgeLocal/src/main/java/forge/control/input line 132 Java Problem
The method announceRequirements() is undefined for the type SpellAbility SpellAbilityRequirements.java /ForgeLocal/src/main/java/forge/card/spellability line 127 Java Problem
The method assignCombatDamage(Card, List<Card>, int, GameEntity, boolean) in the type PlayerController is not applicable for the arguments (Card, List<Card>, int, GameEntity) Combat.java /ForgeLocal/src/main/java/forge/game/phase line 745 Java Problem
The method assignCombatDamage(Card, List<Card>, int, GameEntity, boolean) in the type PlayerController is not applicable for the arguments (Card, List<Card>, int, null) Combat.java /ForgeLocal/src/main/java/forge/game/phase line 704 Java Problem
The method buildColorDeck(List<String>, boolean) in the type DeckgenUtil is not applicable for the arguments (String[], PlayerType) FDeckChooser.java /ForgeLocal/src/main/java/forge/gui/toolbox line 206 Java Problem

Any help and pointers appreciated.

...Nevermind. Apparently that was simply caused by some leftover files from the previous version that hadn't been properly cleaned up when I checked out the fresh source. Full nuke of the whole project dir + new checkout solved it.

RumbleBBU wrote:...Nevermind. Apparently that was simply caused by some leftover files from the previous version that hadn't been properly cleaned up when I checked out the fresh source. Full nuke of the whole project dir + new checkout solved it.

In the future, if you get into this state, simply right-clicking on the root folder and doing a Refresh usually fixes this. At least it does for me after updating my source checkout.