Page 1 of 1

Hide the Ante tab on Duel screen?

PostPosted: 21 Jul 2013, 03:43
by spr
Hi,

If the Play for Ante setting is disabled is there any reason why the Ante tab should not be hidden on the Duel view?

Cheers,
Steve.

Re: Hide the Ante tab on Duel screen?

PostPosted: 29 Jul 2013, 14:43
by drdev
I think the bottom line is some of the tabs should be closable. That way you can just close it and have that remembered in the XML layout settings. I think I'll work on supporting that since I've been making changes for tabs and layout saving already. I'll just need to figure out a good way to get them back after they're closed.

Re: Hide the Ante tab on Duel screen?

PostPosted: 29 Jul 2013, 15:18
by spr
drdev wrote:I'll just need to figure out a good way to get them back after they're closed.
How about right click on a tab header/bar, display popup menu with list of available tabs, click to toggle on or off?

Cheers,
Steve

Re: Hide the Ante tab on Duel screen?

PostPosted: 30 Jul 2013, 00:55
by drdev
spr wrote:
drdev wrote:I'll just need to figure out a good way to get them back after they're closed.
How about right click on a tab header/bar, display popup menu with list of available tabs, click to toggle on or off?

Cheers,
Steve
That could work. I'll play with a few ideas.

I'm also thinking of adding support for reordering the tabs in a single pane (currently only possible by dragging a tab away to a new pane and back) and having options to display tabs for a pane on the bottom instead the top, and maybe even the left and right (with rotated text) too. That would give more flexibility in the layout, such as having your battlefield and the opponents battlefield be closer together (without a row of tabs in between).

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 15:02
by spr
The ability to save the Deck Editor layout would be very useful. I keep corrupting mine for some reason and have to rearrange everything again.

Cheers,
Steve.

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 15:23
by drdev
spr wrote:The ability to save the Deck Editor layout would be very useful. I keep corrupting mine for some reason and have to rearrange everything again.

Cheers,
Steve.
I'm confused. From what I've seen the Deck Editor layout is saved automatically any time it's changed, same as the other screens. What would adding a button to save the layout do exactly?

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 15:42
by friarsol
drdev wrote:I'm confused. From what I've seen the Deck Editor layout is saved automatically any time it's changed, same as the other screens. What would adding a button to save the layout do exactly?
Sounds like since the automatically saved file is being corrupted, he wants to be able to export his settings, and reimport them later. So the separate file would be untouched if a layout gets corrupted.

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 15:51
by spr
drdev wrote:I'm confused. From what I've seen the Deck Editor layout is saved automatically any time it's changed, same as the other screens. What would adding a button to save the layout do exactly?
As mentioned, something corrupted the layout so it reset itself. Admittedly this may be caused by switching between development and release versions of Forge but even so it appears to be a a fairly common occurrence hence the need for the "Reset Editor Layout" button. Also, consistency - the match screen is also saved automatically, but also provides the option to save its layout.

Cheers,
Steve.

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 15:57
by spr
friarsol wrote:Sounds like since the automatically saved file is being corrupted, he wants to be able to export his settings, and reimport them later. So the separate file would be untouched if a layout gets corrupted.
Yes, this is the reason why it would be useful - to restore a layout after a it has been corrupted. Thanks.

Cheers,
Steve

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 16:14
by drdev
Should we consider a setting to disable auto-saving layout changes, instead requiring you to click a Save Layout button?

Also, could the corruption by any chance have anything to do with my recent change to save the selected tab in an xml attribute for each pane? I know I tested that loading an old xml file without that attribute worked fine in the latest source build, but perhaps loading an xml file with that attribute into the last released build is failing? If that's the case, the issue will go away as soon as my change is released, which it sounds like should be soon.

Re: Hide the Ante tab on Duel screen?

PostPosted: 31 Jul 2013, 16:28
by spr
drdev wrote:Should we consider a setting to disable auto-saving layout changes, instead requiring you to click a Save Layout button?
Whether you manually save or auto-save, you would still get the problem if that single save was corrupted. One idea might be to automatically create a backup of the layout file which could be used to attempt a restore behind the scenes.

drdev wrote:Also, could the corruption by any chance have anything to do with my recent change to save the selected tab in an xml attribute for each pane? I know I tested that loading an old xml file without that attribute worked fine in the latest source build, but perhaps loading an xml file with that attribute into the last released build is failing? If that's the case, the issue will go away as soon as my change is released, which it sounds like should be soon.
I was getting corruption going from the latest release back to an earlier version which was my development branch so may be it has something to do with that. My development branch is now up-to-date so any changes you have made should now be incorporated.

Cheers,
Steve