Page 2 of 2

Re: Keyword enhancement

PostPosted: 19 Apr 2014, 10:02
by Hellfish
*Necromancy*
I had to duplicate a little work to get back to a better state, but actually having a branch should mitigate that in the future. As noted it does not build because it is not quite yet at the point I last reported again.I think the CardKeywords system should work with the new stuff now though, and besides that it's mostly a copy-paste slog to move from strings to the (monolithic, I know) enum and instance class. The enum and Instance class may need a little bit of fat trimmed as well (having multiples of any parameter type is only necessary rarely, for instance) but I thought it better to be inclusive.

Also, I had to add a small hack to be able to launch in the first place, as the res folder can't be found otherwise.

ALSO, thanks to swordshine (and anyone else I might've missed :S ) for helping remove excess keywords.

Re: Keyword enhancement

PostPosted: 19 Apr 2014, 12:47
by drdev
Hellfish wrote:*Necromancy*
...
Also, I had to add a small hack to be able to launch in the first place, as the res folder can't be found otherwise.
...
What hack are you referring to? You shouldn't be hard-coding "res/" anywhere anymore. You should use ForgeConstants. And if this code is not in the GUI code, you should pass the path from forge-gui.

Re: Keyword enhancement

PostPosted: 19 Apr 2014, 15:40
by Hellfish
I had to trim out the first "../" from ForgeConstants.INSTALL_ROOT to be able to run from idea. I'm running the Main in forge-gui-desktop.

Re: Keyword enhancement

PostPosted: 19 Apr 2014, 17:35
by friarsol
Hellfish wrote:I had to trim out the first "../" from ForgeConstants.INSTALL_ROOT to be able to run from idea. I'm running the Main in forge-gui-desktop.
I use IntelliJ IDEA too and didn't need to do this.

My main class is forge.view.Main
My working dir is: <forgeParent>\forge\forge-gui-desktop
My classpath is forge-gui-desktop

Re: Keyword enhancement

PostPosted: 28 Apr 2014, 06:14
by Hellfish
Well, crashing svn, that's a first. Not error message -> no commit, a full on stack dump crash to commandline. :lol:
I'll have to grab the branch from scratch again when I have time, I guess.