Page 1 of 1
Reversing turn order

Posted:
03 Jun 2014, 10:47
by elcnesh
The attached patch provides code for reversing the game turn order, used on cards via the effect ReverseTurnOrder.
I'm not sure if it appears in other places than Game.getNextPlayerAfter, that's the only method that uses the turn order as far as I could find.
Re: Reversing turn order

Posted:
03 Jun 2014, 14:03
by friarsol
Thanks elcnesh. I've approved your commit rights (not sure if it notified you). This one and the other diff look good. Feel free to commit them up. I believe the credentials are just the same ones you log into these forums with.
Re: Reversing turn order

Posted:
03 Jun 2014, 14:07
by elcnesh
Cool, thanks a lot!

Re: Reversing turn order

Posted:
03 Jun 2014, 14:24
by swordshine
Technically, some effects containing "Starting with you" (RepeatEach, BidLife, Vote) are also related to the turn order. Small tweaks are needed.
Re: Reversing turn order

Posted:
03 Jun 2014, 14:37
by elcnesh
Ah yes, that's right... I'm thinking about having Game.getPlayers() return a reversed array. So far I haven't found anything that seems problematic when doing that, but I'll check!