Bunch of functional reprints and suggestions for cleanup

[Sloth]

Magic has a lot of functional reprints and as mtgrares mentioned MTG Forge does already feature a lot of them (vanilla and french vanilla creatures), I will try to post all the necessary changes needed to implement some spells:

cards.txt:

Code: Select all

Eye of Nowhere
U U
Sorcery
Return target permanent to its owner's hand.

Ravages of War
3 W
Sorcery
Destroy all lands.

False Defeat
3 W
Sorcery
Return target creature card from your graveyard to the battlefield.

Act of Treason
2 R
Sorcery
Untap target creature and gain control of it until end of turn. That creature gains haste until end of turn. (It can attack this turn.)

Brilliant Plan
4 U
Sorcery
Draw three cards.

Touch of Brilliance
3 U
Sorcery
Draw two cards.

Inspiration
3 U
Sorcery
Draw two cards.

Divination
2 U
Sorcery
Draw two cards.

Preemptive Strike
1 U
Instant
Counter target creature spell.

False Summoning
1 U
Instant
Counter target creature spell.

Essence Scatter
1 U
Instant
Counter target creature spell.


The following lines have to be modified in cardfactory.java:

Code: Select all

if(cardName.equals("Remove Soul") || cardName.equals("False Summoning") || cardName.equals("Essence Scatter") || cardName.equals("Preemptive Strike"))

if(cardName.equals("Counsel of the Soratami") || cardName.equals("Divination") || cardName.equals("Inspiration") || cardName.equals("Touch of Brilliance"))

if(cardName.equals("Concentrate") || cardName.equals("Harmonize") || cardName.equals("Brilliant Plan"))

if(cardName.equals("Threaten") || cardName.equals("Act of Treason"))

if(cardName.equals("Breath of Life") || cardName.equals("Resurrection") || cardName.equals("False Defeat") || cardName.equals("Zombify"))

if(cardName.equals("Armageddon") || cardName.equals("Ravages of War"))

else if(cardName.equals("Boomerang") || cardName.equals("Eye of Nowhere"))


Note 1: Zombify is already implemented, but the code of Zombify is just a copy of Breath of Life. It can be deleted.
Note 2: Regress has an effect identical to Boomerang and Eye of Nowhere, but has its own section of code, which seems to have better AI-targeting than that of Boomerang. They should be merged.
Note 3: Since the AI can't use Remove Soul this has to be added to GenerateConstructedDeck.java:

Code: Select all

remove.add("False Summoning");
remove.add("Essence Scatter");
remove.add("Preemptive Strike");


[mtgrares]

At first I thought funcational reprints might be bad, negative, or boring but now I don't mind them although when I'm using the deck editor sometimes I wish I could remove all of the functional reprints or "very sucky cards in general".