Page 2 of 3

Re: i18n

PostPosted: 04 Aug 2014, 18:31
by krishkrush
So, any news? Or do we wait till after next release?

Re: i18n

PostPosted: 04 Aug 2014, 18:36
by friarsol
krishkrush wrote:So, any news? Or do we wait till after next release?
I believe Krazy said he was in the middle of moving to a new apartment(?). Don't worry, he'll report when he starts working on it.

Re: i18n

PostPosted: 04 Aug 2014, 19:00
by KrazyTheFox
friarsol wrote:
krishkrush wrote:So, any news? Or do we wait till after next release?
I believe Krazy said he was in the middle of moving to a new apartment(?). Don't worry, he'll report when he starts working on it.
That's correct. I found a place and have been moving all weekend, but don't have my computer set up yet. I'll be able to work on things soon.

Re: i18n

PostPosted: 04 Aug 2014, 20:06
by krishkrush
Alright, didn't meant to be pushy. Just asking :mrgreen:

Re: i18n

PostPosted: 07 Aug 2014, 23:46
by KrazyTheFox
Working on adding the support classes now. I'll have that + documentation up soon so people can get started converting the code. I'll post here again when it's available.

Re: i18n

PostPosted: 08 Aug 2014, 01:02
by KrazyTheFox
Alright, it begins!

Check out the wiki here for instructions (and if you need clarification, ask away): http://www.slightlymagic.net/wiki/Forge:How_to_Get_Started_Developing_Forge#Localization

Here's a sample showing the localization on the splash:

forgelang.jpg


For now, the default language can't be changed from within Forge itself, so the only way to test languages is to set it manually as specified in the wiki. This is intentional for testing purposes and will be fixed when we get everything converted over.

Re: i18n

PostPosted: 08 Aug 2014, 18:47
by krishkrush
So, uhm, i just start with the regular 1.5.24 or do i need some special version of forge? Sorry if this is a dumb question but as i am no developer and new to this...
Also, what happens when the new version is released? Do i have to start all over again?
And what about that icu4j thingie you mentioned in your first post? Do i need that? I'm just a little nervous about me messing with code :lol:

Re: i18n

PostPosted: 09 Aug 2014, 05:53
by drdev
So I had to remove com.ibm.icu as a reference (r27013) as it caused problems for the Android build. That said, it seems that you were only using it for the MessageFormat class, which already lives in java.text. So it doesn't seem to be a necessary reference anyway. Or am I missing something?

Re: i18n

PostPosted: 09 Aug 2014, 12:06
by KrazyTheFox
krishkrush wrote:So, uhm, i just start with the regular 1.5.24 or do i need some special version of forge? Sorry if this is a dumb question but as i am no developer and new to this...
Also, what happens when the new version is released? Do i have to start all over again?
And what about that icu4j thingie you mentioned in your first post? Do i need that? I'm just a little nervous about me messing with code :lol:
Until we programmers are done with implementing the code, there's not much for you to do if you're not comfortable with helping out there. I'll be sure to let you know once it's ready to translate, though.

drdev wrote:So I had to remove com.ibm.icu as a reference (r27013) as it caused problems for the Android build. That said, it seems that you were only using it for the MessageFormat class, which already lives in java.text. So it doesn't seem to be a necessary reference anyway. Or am I missing something?
That's weird. icu4j uses almost the same classes that regular java does, just with a bunch of improvements such as pluralization. I'll see if I can figure out how to fix it. What kind of problems was it causing?

Re: i18n

PostPosted: 09 Aug 2014, 17:39
by drdev
KrazyTheFox wrote:
drdev wrote:So I had to remove com.ibm.icu as a reference (r27013) as it caused problems for the Android build. That said, it seems that you were only using it for the MessageFormat class, which already lives in java.text. So it doesn't seem to be a necessary reference anyway. Or am I missing something?
That's weird. icu4j uses almost the same classes that regular java does, just with a bunch of improvements such as pluralization. I'll see if I can figure out how to fix it. What kind of problems was it causing?
The problem is it adds a lot of additional code to the Forge package that causes it to grow beyond the allowed limit for Android. It's also probably not good to continue to bloat the code for the desktop app either, as it increases the size of the install package for others to download and increases the install time I'd imagine.

Instead of pulling in that dependency, can we just write our own code for anything that java.text.MessageFormat doesn't already give us?

Re: i18n

PostPosted: 09 Aug 2014, 21:00
by KrazyTheFox
drdev wrote:The problem is it adds a lot of additional code to the Forge package that causes it to grow beyond the allowed limit for Android. It's also probably not good to continue to bloat the code for the desktop app either, as it increases the size of the install package for others to download and increases the install time I'd imagine.

Instead of pulling in that dependency, can we just write our own code for anything that java.text.MessageFormat doesn't already give us?
Ah, I hadn't realized it was such a large dependency. I think there's a way to get only specific parts of it, so I'll see if I can do that instead. It'd be possible to rewrite what we need, but I'd rather not if I can help it. :P

Re: i18n

PostPosted: 10 Aug 2014, 09:32
by krishkrush
KrazyTheFox wrote:
krishkrush wrote:So, uhm, i just start with the regular 1.5.24 or do i need some special version of forge? Sorry if this is a dumb question but as i am no developer and new to this...
Also, what happens when the new version is released? Do i have to start all over again?
And what about that icu4j thingie you mentioned in your first post? Do i need that? I'm just a little nervous about me messing with code :lol:
Until we programmers are done with implementing the code, there's not much for you to do if you're not comfortable with helping out there. I'll be sure to let you know once it's ready to translate, though.
Ah okay thanks for clarifying this.

Re: i18n

PostPosted: 13 Aug 2014, 00:51
by KrazyTheFox
drdev wrote:The problem is it adds a lot of additional code to the Forge package that causes it to grow beyond the allowed limit for Android. It's also probably not good to continue to bloat the code for the desktop app either, as it increases the size of the install package for others to download and increases the install time I'd imagine.

Instead of pulling in that dependency, can we just write our own code for anything that java.text.MessageFormat doesn't already give us?
I can package it down to 6.5MB while keeping the functionality we'd need. Unfortunately it's not split up into smaller modules than that. Would this work for us? There's a lot of "gotcha"s when it comes to languages and I feel like trying to manually support that later would come back to bite us. If that's still too big, I can possibly go in and chop up the source code myself, though I don't really have the time to do that at the moment.

Re: i18n

PostPosted: 13 Aug 2014, 03:12
by drdev
I can try it out I guess. We could also try trimming other libraries or parts of the code if needed.

Re: i18n

PostPosted: 13 Aug 2014, 03:44
by KrazyTheFox
drdev wrote:I can try it out I guess. We could also try trimming other libraries or parts of the code if needed.
I'll give it a shot after this next release. I don't have much time until Saturday for things.