Collectible Card Game Headquarters

Rob Cashwalker wrote:The trick with multiple keywords, like spPumpTgt and Cycling is that the order of processing in CardFactory.java needs to be changed. The permanent ability keywords need to be first. Then the spell keywords need to be second. Then the "tack-on" keywords need to be processed last, possibly at the very end of CardFactory, allowing for "tack-ons" to be used for explicitly coded cards.

Cantrip isn't implemented like the others. It's checked upon resolution of any spell - if the card contains the keyword, then it just draws a card. Quite separately from any other card code.

The tricky part I've been trying to think about lately, is the Charms or Commands. Each individual ability of Chaos Charm for example, is something that we have keywords for. But we can't just do it like this:

Chaos Charm
R
Instant
Choose one - Destroy target Wall; or Chaos Charm deals 1 damage to target creature; or target creature gains haste until end of turn.
spDestroyTgt:Creature.Wall
spDamageC:1 (OK, we don't have creature-only damage yet, but it's easy enough)
spPumpTgt:Haste

Because each of the sp___ code blocks clears out the spell abilities of the card. (because all cards are assumed to be permanents, and given a default spell ability to be put into play).
So it would process spDestroyTgt (never mind the fact that the code needs the text formatted a certain way in order to extract the input dialog text) removing the default ability.
Then it would process the spDamageC ability, removing the spDestroyTgt abilty.
Then it would process the spPumpTgt ability, removing the spDamageC ability.
And that's just a rough example, because that's not the order of code blocks... spDamageC would be first, up by the spDamageCP and spDamageP blocks; then spDestroyTgt, and spPumpTgt would probably be inserted last when Dennis merges it.

I think the best way to handle this may be something like the following:

Code: Select all

public boolean hasSpKeyword()
{
  ArrayList k = card.getKeywords();
  for (i = 0; i < k.length; i++)
    if (k(i).startsWith("sp")
      return true;
  return false;
}


Code: Select all

if (hasSpKeyword)
{
   card.clearSpellAbility();

   if (shouldSpDamageCP)
   {
      ...
   }
   if (shouldSpDamageP)
   {
      ...
   }
   if (shouldSpDestroyTgt)
   {
      ...
   }
   if (shouldSpPumpTgt)
   {
      ...
   }
   ...
      etc
   ...
}


Then remove the clearSpellAbility() from each individual code block. Oh, and make sure each one has a spell.setDescription().

When you go to play the spell, the game will now present each spell option. This won't work for the Commands, which want two choices... but that's OK... for now.

Code: Select all

    //*************** START *********** START **************************
    if(cardName.equals("Jokulhaups") || cardName.equals("Akroma's Vengeance"))
    {
      final SpellAbility spell = new Spell(card)
      {
      private static final long serialVersionUID = -7384618531690849205L;

      public void resolve()
        {
          CardList all = new CardList();
          all.addAll(AllZone.Human_Play.getCards());
          all.addAll(AllZone.Computer_Play.getCards());

          for(int i = 0; i < all.size(); i++)
          {
            Card c = all.get(i);
           
            if(cardName.equals("Jokulhaups") & (c.isCreature() || c.isArtifact() || c.isLand()))
                AllZone.GameAction.destroyNoRegeneration(c);
             
            if(cardName.equals("Akroma's Vengeance") & (c.isCreature() || c.isArtifact() || c.isEnchantment()))
                  AllZone.GameAction.destroy(c);
          }
        }//resolve()
      };//SpellAbility
      card.clearSpellAbility();
      card.addSpellAbility(spell);
    }//*************** END ************ END **************************

Code: Select all

    //*************** START *********** START **************************
    if(cardName.equals("Jokulhaups") || cardName.equals("Akroma's Vengeance"))
    {
      final SpellAbility spell = new Spell(card)
      {
      private static final long serialVersionUID = -7384618531690849205L;

      public void resolve()
        {
          CardList all = new CardList();
          all.addAll(AllZone.Human_Play.getCards());
          all.addAll(AllZone.Computer_Play.getCards());

          for(int i = 0; i < all.size(); i++)
          {
            Card c = all.get(i);
           
            if(cardName.equals("Jokulhaups") & (c.isCreature() || c.isArtifact() || c.isLand()))
                AllZone.GameAction.destroyNoRegeneration(c);
             
            if(cardName.equals("Akroma's Vengeance") & (c.isCreature() || c.isArtifact() || c.isEnchantment()))
                  AllZone.GameAction.destroy(c);
          }
        }//resolve()
      };//SpellAbility
      card.clearSpellAbility();
      card.addSpellAbility(spell);
      if (cardName.equals("Akroma's Vengeance")) //add cycling
               card.addSpellAbility(CardFactoryUtil.ability_cycle(card, "3"));
    }//*************** END ************ END **************************

mtgrares wrote:At the beginning of CardFactory for every card I called card.addSpellAbility(new Spell_Permanent()) to give the creatures in cards.txt a "default" spells, which summons a permanent such as an artifact, enchantment, land, planeswalker etc... So all instants and sorceries have to remove the permanent SpellAbility by calling card.clearSpellAbility().

Hopefully that explains things a little bit.

DennisBergkamp wrote:By the way, the Cycling part probably won't work. I've had the same problem with Hush I think. So I had to add in the Cycling code separately, because a card.clearSpellAbility() gets called...

zerker2000 wrote:And you cannot just have "default" code check for the card being a creature/land/artifact/enchantment/planeswalker/plane why?

mtgrares wrote:

zerker2000 wrote:And you cannot just have "default" code check for the card being a creature/land/artifact/enchantment/planeswalker/plane why?

That would work better. Different things makes sense at different times. I usually coded first and thought second. While this isn't a really great way to do things, at least I never got stuck anywhere. (And that also explains CardFactory, the world's longest method.)

Code: Select all

#buyback code#
boolean tofield=false;
boolean tograve=false;
String permanents = "Creature/Land/Artifact/Enchantment/Planeswalker/Plane"
for(String type: card.getTypes().split(" ");)
{
  if (permanents.contains(type)) tofield=true;
  if (type.equals("Instant")|| type.equals("Sorcery")) tograve=true;
}
if(tofield!^tograve) throw (#something heavy at developers#);
if(tofield) {#old code#}
if(tograve) {#old Instant / Sorcery casting code#}

p.s.
I did think long and hard about the Input class (which handles ALL of the mouse input) but it is very confusing to explain.

It seems OK to me... the whole targeting system could be tweaked to allow easier multi-target spells.