Preferred method of patch submission?

by **-gz** » 03 Jan 2015, 20:55

Where do the forge developers want patches submitted to? I've filed a couple of issues on the tracker and attached diffs, but it seems pretty overlooked. The changes are pretty trivial and should be easy for anyone to review and apply.

Wanted to tackle some harder things (like AI snafu) but don't want to launch on anything big without adding test cases, and forge-ai has zero? Especially given the work Myrd is already doing, poking old code that's liable to get reworked shortly without a suite to guard against regressions seems fruitless.

by **Rob Cashwalker** » 03 Jan 2015, 23:10

post them here. As you become more active, one of the mods can give you commit privileges on the SVN.

The bug tracker was hotly requested at one point, but fell out of favor.

by **-gz** » 04 Jan 2015, 17:04

Okay, attaching patches here.

Cards that say "may tap any number of untapped creatures you control" such as Jaddi Lifestrider force you to tap all valid creatures, or skip the ability entirely. Instead they should allow the ability to resolve with 0 to all valid creatures selected.

by **-gz** » 04 Jan 2015, 17:06

Every AI pick, forge reports to stdout "Draft Rankings - Card Not Found: Forest" and similar for each basic land. The code understands it should not rate basic lands, but in the wrong place to recognise this is not a useful warning.

by **friarsol** » 04 Jan 2015, 22:05

Hey gz, thanks for the patches. Since you are looking into joining the Forge group, can you request access to the Developers - Forge group and I'll add you to the group.

Then you can add these in, and look into other spots you might be interested. Feel free to start a new post if you want to look into something bigger, and whoever is most familiar with the area can give some pointers about what to look out for.