Forge version 1.5.36

[Agetian]

Huh, that's weird... Didn't even change anything related to that as far as I know. I'll investigate
(OTOH, if that's the worst bug this refactoring brings, I'm more than happy!!)

Hehe true, my testing thus far (although not very extensive due to the lack of time) has been rather quiet and stable, which is a good sign I think.

- Agetian

[Agetian]

Here's my first fatal crash report related to the new GUI code:

Description: This NPE happens every time I'm trying to start a quest draft tournament match (could be related to AI vs. AI matches only, but I don't know).

NullPointerException | Open

Code: Select all

Forge Version:    1.5.36-SNAPSHOT-r28878u
Operating System: Linux 3.8.0-26-generic amd64
Java Version:     1.7.0_51 Oracle Corporation

java.lang.NullPointerException
   at com.google.common.collect.Iterables.getFirst(Iterables.java:771)
   at forge.match.AbstractGuiGame.setLocalPlayers(AbstractGuiGame.java:39)
   at forge.screens.match.CMatchUI.initMatch(CMatchUI.java:250)
   at forge.screens.match.CMatchUI.openView(CMatchUI.java:763)
   at forge.match.HostedMatch.startGame(HostedMatch.java:192)
   at forge.match.HostedMatch.startMatch(HostedMatch.java:107)
   at forge.match.HostedMatch.startMatch(HostedMatch.java:84)
   at forge.quest.QuestDraftUtils.update(QuestDraftUtils.java:199)
   at forge.quest.QuestDraftUtils.startNextMatch(QuestDraftUtils.java:117)
   at forge.screens.home.quest.CSubmenuQuestDraft.startNextMatch(CSubmenuQuestDraft.java:568)
   at forge.screens.home.quest.CSubmenuQuestDraft.access$000(CSubmenuQuestDraft.java:54)
   at forge.screens.home.quest.CSubmenuQuestDraft$7.actionPerformed(CSubmenuQuestDraft.java:271)
   at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
   at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
   at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
   at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
   at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
   at java.awt.Component.processMouseEvent(Component.java:6505)
   at javax.swing.JComponent.processMouseEvent(JComponent.java:3311)
   at java.awt.Component.processEvent(Component.java:6270)
   at java.awt.Container.processEvent(Container.java:2229)
   at java.awt.Component.dispatchEventImpl(Component.java:4861)
   at java.awt.Container.dispatchEventImpl(Container.java:2287)
   at java.awt.Component.dispatchEvent(Component.java:4687)
   at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
   at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
   at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
   at java.awt.Container.dispatchEventImpl(Container.java:2273)
   at java.awt.Window.dispatchEventImpl(Window.java:2719)
   at java.awt.Component.dispatchEvent(Component.java:4687)
   at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:735)
   at java.awt.EventQueue.access$200(EventQueue.java:103)
   at java.awt.EventQueue$3.run(EventQueue.java:694)
   at java.awt.EventQueue$3.run(EventQueue.java:692)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
   at java.awt.EventQueue$4.run(EventQueue.java:708)
   at java.awt.EventQueue$4.run(EventQueue.java:706)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
   at java.awt.EventQueue.dispatchEvent(EventQueue.java:705)
   at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
   at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
   at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
   at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
   at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)


P.S. Any luck figuring out what made the creature row be placed differently for the top player?..

- Agetian

[elcnesh]

Ok, I know how to fix this! And have also fixed the other one, will commit when I have real (non-mobile) internet

Edit: done, r28880

[Hexadecimal]

I think that after the latest GUI refactoring, the location where creatures are visualized on the battlefield has changed - right now, for the top player, creatures are displayed in a row above lands, which is unusual because before the refactoring, top player's creatures were displayed in a row below lands, "against" the bottom player's creatures (which looked good in combat, I think). Now my eyes have to constantly shift up to look at the row above lands, which is a little awkward in combat with the targeting arrows crossing the lands and stuff.

This problem still exists in AI vs AI matches for the bottom player.

[-gz]

Ok, so I've just committed the change that allows multiple games to be played simultaneously (desktop only). It's rather large, so I hope people can give it a good shake before the next beta release, to iron out any bugs (although my tests so far have been really stable). I've fixed all the bugs that I mentioned in the other thread earlier.

Just fixed an issue that prevented booster draft games progressing past the first round that was caused by this refactor, you may want to check it (r28983). There's also an issue when picking "Play one opponent" instead that leaves a splash overlay in the way of the game, not sure if that's also from your change or a later one.

[Jordski1688]

How do you summon you tiny leader in the Forge for PC?