Forge version 1.5.36
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
21 posts
• Page 1 of 2 • 1, 2
Re: Forge version 1.5.36
by drdev » 15 Feb 2015, 15:38
I just finished implementing initial support for the Tiny Leaders format. The only thing I need to add is deck building support and mobile support. So you should be able to play Tiny Leaders using generated decks that are legal to the format, respecting the CMC restriction, the ban list, as well as the additional commander ban list.
As part of this, I've increased the flexibility of the DeckGeneratorBase class and DeckFormat enum to support restricted pools. With this increased flexibility, my next plan is to add Pauper and Peasant support, and maybe Tribal Wars after that.
Let me know if the CMC percentages need tweaking for generated Tiny Leaders decks. At the moment I made it do 33% CMC 0-1, 33% CMC 2, and 33% CMC 3. I also think it might be adding too high a percentage of lands, so that may need adjusting.
Thanks.
-Dan
As part of this, I've increased the flexibility of the DeckGeneratorBase class and DeckFormat enum to support restricted pools. With this increased flexibility, my next plan is to add Pauper and Peasant support, and maybe Tribal Wars after that.
Let me know if the CMC percentages need tweaking for generated Tiny Leaders decks. At the moment I made it do 33% CMC 0-1, 33% CMC 2, and 33% CMC 3. I also think it might be adding too high a percentage of lands, so that may need adjusting.
Thanks.
-Dan
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge version 1.5.36
by Hanmac » 15 Feb 2015, 16:35
hey can you do that too that if you select a Modern Deck for you and the Enemy has AutoGenerated from Colors, that he also only get a Modern legal deck?drdev wrote:I just finished implementing initial support for the Tiny Leaders format.
and if you implement new formats i have some plans for Forge to implement some different Multiplayer settings like Pentraram or RainBow Magic ... (in a Pentragram only the far distant players are your enemies)
a german description is there:
http://magic.freizeitspieler.de/pentagramm.php
Re: Forge version 1.5.36
by drdev » 15 Feb 2015, 16:55
Adding format filtering is something I've wanted to do, so maybe this as good a time as any to do it.Hanmac wrote:hey can you do that too that if you select a Modern Deck for you and the Enemy has AutoGenerated from Colors, that he also only get a Modern legal deck?drdev wrote:I just finished implementing initial support for the Tiny Leaders format.
and if you implement new formats i have some plans for Forge to implement some different Multiplayer settings like Pentraram or RainBow Magic ... (in a Pentragram only the far distant players are your enemies)
a german description is there:
http://magic.freizeitspieler.de/pentagramm.php
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge version 1.5.36
by drdev » 15 Feb 2015, 18:05
So I'm now thinking I'm going to refactor Commander and Tiny Leaders formats.txt and extend the scripting supported by that so people can add their own custom formats and have us able to support them both from a deck building perspective as well as from a deck conformance and generation perspective.
How does this look so far?
How does this look so far?
- variants.txt | Open
Last edited by drdev on 15 Feb 2015, 18:12, edited 1 time in total.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge version 1.5.36
by Agetian » 15 Feb 2015, 18:12
Looks like a very handy and useful feature! Thanks!drdev wrote:So I'm now thinking I'm going to refactor Commander and Tiny Leaders formats.txt and extend the scripting supported by that so people can add their own custom formats and have us able to support them both from a deck building perspective as well as from a deck conformance and generation perspective.
How does this look so far?
- formats.txt | Open
- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
Re: Forge version 1.5.36
by friarsol » 15 Feb 2015, 18:49
This will be great for all the Forge tinkerers who want some more flexibility in the variants.
Some comments:
1) Mulligan would be a good extra parameter, since Commander uses Partial Paris, but others might have different ones.
2) Can you still play Momir Basic with any deck of only basic lands?
Some comments:
1) Mulligan would be a good extra parameter, since Commander uses Partial Paris, but others might have different ones.
2) Can you still play Momir Basic with any deck of only basic lands?
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Forge version 1.5.36
by drdev » 15 Feb 2015, 20:35
Already added FreeMulligan as parameter. I can change that to just Mulligan with a string type parameter, but currently we only support free mulligan as a boolean in the code.friarsol wrote:This will be great for all the Forge tinkerers who want some more flexibility in the variants.
Some comments:
1) Mulligan would be a good extra parameter, since Commander uses Partial Paris, but others might have different ones.
2) Can you still play Momir Basic with any deck of only basic lands?
Yes, Momir Basic can still be played that way using Vanguard and a custom built deck as before, but now you can just edit variants.txt if you want to change the deck breakdown. Eventually I'd hope to create a Variant Editor in Forge that could facilitate creating your own custom variants/formats with specific sets, banned lists, life/hand adjustments, etc.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge version 1.5.36
by elcnesh » 17 Feb 2015, 08:55
Ok, so I've just committed the change that allows multiple games to be played simultaneously (desktop only). It's rather large, so I hope people can give it a good shake before the next beta release, to iron out any bugs (although my tests so far have been really stable). I've fixed all the bugs that I mentioned in the other thread earlier.
Note that there's a lot of code duplication in the selection code (SGuiChoose vs AbstractGuiGame). I'm still looking for a way to get rid of this, but the former is static while the latter is an abstract base class, so I'm not sure how to do that elegantly. Fixing this shouldn't change any functionality though, so it doesn't really matter for testing.
PS: in the meantime I've also fixed Ripple, as it was causing crashes during my testing
Note that there's a lot of code duplication in the selection code (SGuiChoose vs AbstractGuiGame). I'm still looking for a way to get rid of this, but the former is static while the latter is an abstract base class, so I'm not sure how to do that elegantly. Fixing this shouldn't change any functionality though, so it doesn't really matter for testing.
PS: in the meantime I've also fixed Ripple, as it was causing crashes during my testing
- elcnesh
- Posts: 290
- Joined: 16 May 2014, 15:11
- Location: Netherlands
- Has thanked: 34 times
- Been thanked: 92 times
Re: Forge version 1.5.36
by Agetian » 17 Feb 2015, 10:47
Congrats on getting such a huge overhaul complete!elcnesh wrote:Ok, so I've just committed the change that allows multiple games to be played simultaneously (desktop only). It's rather large, so I hope people can give it a good shake before the next beta release, to iron out any bugs (although my tests so far have been really stable). I've fixed all the bugs that I mentioned in the other thread earlier.
Here's some initial testing: I updated to the latest SVN build and the first thing I got in the very first match (right at its start) was this exception:
- NullPointerException | Open
- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
Re: Forge version 1.5.36
by Agetian » 18 Feb 2015, 16:18
I think that after the latest GUI refactoring, the location where creatures are visualized on the battlefield has changed - right now, for the top player, creatures are displayed in a row above lands, which is unusual because before the refactoring, top player's creatures were displayed in a row below lands, "against" the bottom player's creatures (which looked good in combat, I think). Now my eyes have to constantly shift up to look at the row above lands, which is a little awkward in combat with the targeting arrows crossing the lands and stuff.
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
Re: Forge version 1.5.36
by elcnesh » 18 Feb 2015, 16:35
Huh, that's weird... Didn't even change anything related to that as far as I know. I'll investigate 
(OTOH, if that's the worst bug this refactoring brings, I'm more than happy!!)
(OTOH, if that's the worst bug this refactoring brings, I'm more than happy!!)
- elcnesh
- Posts: 290
- Joined: 16 May 2014, 15:11
- Location: Netherlands
- Has thanked: 34 times
- Been thanked: 92 times
Re: Forge version 1.5.36
by kudit » 18 Feb 2015, 18:17
elcnesh wrote:(OTOH, if that's the worst bug this refactoring brings, I'm more than happy!!)
likePlease give feedback on our card database at http://www.deckmaster.info
Send comments via PM here or info@deckmaster.info
Send comments via PM here or info@deckmaster.info
21 posts
• Page 1 of 2 • 1, 2
Who is online
Users browsing this forum: No registered users and 39 guests