Page 2 of 2

Re: Cards with the add mana keyword

PostPosted: 10 Oct 2009, 13:39
by Chris H.
DennisBergkamp wrote:Oh I see, interesting, so it seems like they're just missing the text somehow...

I just tested Kaleidostone myself, it doesn't work for me though. I get W U B R G, but it doesn't get sacrificed.
`
I somehow missed the sacrifice requirement, I guess that I have been fairly centered on making sure that the mana appears in the mana pool.

We have a large number of new cards to add in via zeerker's new code. We can leave out the Kaleidostone.

Re: Cards with the add mana keyword

PostPosted: 10 Oct 2009, 13:41
by Chris H.
zerker2000 wrote:
Chris H. wrote:This card will only provide the G and not 1 G in mana:

Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1 G
I think it's supposed to be "tap: add 1G"
`
This is strange. I have the following for the Nantuko Elder:


Code: Select all
Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1 G
`
When I tap the Nantuko Elder, this is what appears in the mana pool window:


Code: Select all
Mana available:
G(1)
`
I was expecting:


Code: Select all
Mana available:
1G(1)

Re: Cards with the add mana keyword

PostPosted: 10 Oct 2009, 15:56
by zerker2000
Chris H. wrote:
zerker2000 wrote:
Chris H. wrote:This card will only provide the G and not 1 G in mana:

Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1 G
I think it's supposed to be "tap: add 1G"
`
This is strange. I have the following for the Nantuko Elder:


Code: Select all
Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1 G
`
When I tap the Nantuko Elder, this is what appears in the mana pool window:


Code: Select all
Mana available:
G(1)
`
I was expecting:


Code: Select all
Mana available:
1G(1)
Have you tried
Code: Select all
Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1G
:?:

Re: Cards with the add mana keyword

PostPosted: 10 Oct 2009, 16:30
by Chris H.
zerker2000 wrote:Have you tried

Code: Select all
Nantuko Elder
2 G
Creature Elf Druid
no text
1/2
tap: add 1G
:?:
`
I tried it and I also tried reversing the order of the "G" and the "1". It did not word either way.

I have not had a chance to examine the keyword code for this new keyword.

Is it possible that the code that handles the string to the right of the colon ":" is only handling the color mana and is not set up to recognize and assign colorless mana to the mana pool?

Re: Cards with the add mana keyword

PostPosted: 12 Oct 2009, 00:26
by zerker2000
Ah, caught the bug! In ManaPool.addMana(String), Colorless.concat(s) should be Colorless+=s :oops: . Also, following proper java grammar, Colorless should be lowercase(applies to a bunch of other variables in my code too).

EDIT:And Ability_Mana constructor has mana.replaceAll(" ", ""), so 1 G vs 1G matters only for description.