Dragon Presence Cards
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
38 posts
• Page 3 of 3 • 1, 2, 3
Re: Dragon Presence Cards
by Agetian » 16 May 2015, 05:15
The addition of Dragon Presence cards allows to add all five DTK intro packs to Forge. I went ahead and committed the quest mode precons in r29399. EDIT: Also added Landslide Charge DTK event deck (r29401).
I also see Commune with Lava is now in - great job, Sol, thanks! Is there any hard stopper for Hedonist's Trove? I thought about it a little bit yesterday but found it too complex for my skills (the absence of similar mechanics in already scripted cards doesn't help either
), although the fact that it's roughly based around the exile mechanic somewhat reminiscent of Commune with Lava makes me feel a little bit optimistic about it 
[Side note: it looks like Hedonist's Trove only appears in 1 deck in MTGDecks.net converted decklists, so it's not a popular tournament card after all].
- Agetian
I also see Commune with Lava is now in - great job, Sol, thanks! Is there any hard stopper for Hedonist's Trove? I thought about it a little bit yesterday but found it too complex for my skills (the absence of similar mechanics in already scripted cards doesn't help either
), although the fact that it's roughly based around the exile mechanic somewhat reminiscent of Commune with Lava makes me feel a little bit optimistic about it [Side note: it looks like Hedonist's Trove only appears in 1 deck in MTGDecks.net converted decklists, so it's not a popular tournament card after all].- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
Re: Dragon Presence Cards
by friarsol » 16 May 2015, 13:43
It's kinda similar to Yawgmoth's Will, but with exiling things first. I was suggesting this originally, but never tested it. I think swordshine said it didn't work with somethings, so I didn't look into it too much.Agetian wrote:Is there any hard stopper for Hedonist's Trove? I thought about it a little bit yesterday but found it too complex for my skills (the absence of similar mechanics in already scripted cards doesn't help either
- Prototype | Open
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Dragon Presence Cards
by friarsol » 16 May 2015, 16:21
Ahhh just looked through the Spoiler thread. It seems that the case was Misthollow Griffin. I'm not sure if that's a strong enough corner case here.
Hedonist's Trove (exiles the Griffin), opponent Confiscate s your Trove. Then casts Griffin (here an opponent should get an option whether to cast the Griffin through the Trove, or cast it through it's native ability.) When casting natively, it shouldn't count for your once per turn for the Trove.
Hedonist's Trove (exiles the Griffin), opponent Confiscate s your Trove. Then casts Griffin (here an opponent should get an option whether to cast the Griffin through the Trove, or cast it through it's native ability.) When casting natively, it shouldn't count for your once per turn for the Trove.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Dragon Presence Cards
by excessum » 06 Jun 2015, 23:27
Other than Scaleguard Sentinels, the AI does not seem to receive the bonus effect from the "reveal" clause of the dragon presence cards. The bonus for dragons on the battlefield does seem to work though.
Re: Dragon Presence Cards
by Agetian » 07 Jun 2015, 05:14
This seems to be related to the fact that for some reason the check at SpellAbilityCondition.java:229 (isOptionalCostPaid, in particular) fails - the spell ability that is being tested does not have its GenericCost filled when the AI casts the spell and reveals a dragon (so, the optional costs array is empty). :/ Does anyone have an idea why that might be happening?excessum wrote:Other than Scaleguard Sentinels, the AI does not seem to receive the bonus effect from the "reveal" clause of the dragon presence cards. The bonus for dragons on the battlefield does seem to work though.
- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
Re: Dragon Presence Cards
by Agetian » 07 Jun 2015, 15:29
Ok, I tried to fix the issue with the Dragon Presence cards when they're used by the AI in the "reveal a dragon from hand" mode. I was successful in making Foul-Tongue Invocation work correctly. Orator of Ojutai, Silumgar's Scorn and Scaleguard Sentinels seem to work fine as they are (at least in multiple tests that I ran...), I don't remember if I had to change anything about Silumgar's Scorn to make it work.
Draconic Roar is a bit of a hit-or-miss... I was able to make it work in some cases but not in all cases. There's a strange bug somewhere deep in the code (I got lost tracing the code tbh) that causes the SubAbility to lose its target information and paidcosts information when the AI casts the spell. If that happens (and it seems to happen when the AI tries to cast Draconic Roar in its main phase), the game is unable to identify that the dragon presence reveal was used via "ConditionDragonPresence$ True" (because paycosts info is lost). It correctly identifies that the spell was cast with dragon presence reveal using the new method I implemented but it still fails to target the card's controller (because the target info was lost). No idea how and where that happens, but if anyone is willing to tackle this, here's a test case that clearly demonstrates the issue (the AI will try to cast Draconic Roar in its main phase every time, the thing is, it won't always reveal a dragon, but it'll reveal it often enough):
- Agetian
Draconic Roar is a bit of a hit-or-miss... I was able to make it work in some cases but not in all cases. There's a strange bug somewhere deep in the code (I got lost tracing the code tbh) that causes the SubAbility to lose its target information and paidcosts information when the AI casts the spell. If that happens (and it seems to happen when the AI tries to cast Draconic Roar in its main phase), the game is unable to identify that the dragon presence reveal was used via "ConditionDragonPresence$ True" (because paycosts info is lost). It correctly identifies that the spell was cast with dragon presence reveal using the new method I implemented but it still fails to target the card's controller (because the target info was lost). No idea how and where that happens, but if anyone is willing to tackle this, here's a test case that clearly demonstrates the issue (the AI will try to cast Draconic Roar in its main phase every time, the thing is, it won't always reveal a dragon, but it'll reveal it often enough):
- TEST CASE: AI MAKES SPELLABILITY LOSE TARGETING INFO | Open
- Agetian
- Agetian
- Programmer
- Posts: 3471
- Joined: 14 Mar 2011, 05:58
- Has thanked: 676 times
- Been thanked: 561 times
38 posts
• Page 3 of 3 • 1, 2, 3
Who is online
Users browsing this forum: KeithOvart and 89 guests