Upcoming Release: Forge version 1.5.55

[friarsol]

Hopefully by the end of July to get in as much of eldritch moon as possible, plus all the bug fixes/ai improvements that come with new editions.

[Shadowzeny]

Perhaps even add Briarbridge patrol <.<

[Agetian]

I'm bringing this up here because it's relevant for both 1.5.54 and current SVN, and it's an issue we may want to look into as it causes a hard crash under reproducible cirtumstances that does not allow one to continue playing the game.

I confirmed a bug reported by Zirbert in the 1.5.54 thread regarding putting a tapland into play via Necropotence. Here's a test case:

Code: Select all

humanlife=34
ailife=20
activeplayer=human
activephase=MAIN1
humancardsinhand=Soul Summons;Soul Summons;Soul Summons;Soul Summons;Soul Summons;Soul Summons
humancardsinlibrary=Bojuka Bog;Bojuka Bog;Soul Summons;Soul Summons
humancardsingraveyard=Metamorphose;Metamorphose
humancardsinplay=Dakmor Salvage;Creeping Tar Pit;Blackcleave Cliffs;Bloodstained Mire;Cabal Pit;Necropotence
humancardsinexile=Soul Summons;Soul Summons;Soul Summons;Soul Summons
humancardsincommand=
aicardsinhand=Soul Summons;Soul Summons;Soul Summons;Soul Summons
aicardsinlibrary=Soul Summons;Soul Summons
aicardsingraveyard=Soul Summons;Soul Summons;Soul Summons;Soul Summons;Soul Summons;Soul Summons
aicardsinplay=Mountain|Tapped:True;Mountain|Tapped:True;Mountain;Tropical Island;Jungle Shrine|Tapped:True;Jungle Shrine|Tapped:True;Wall of Earth;Wall of Ice;Dakmor Salvage
aicardsinexile=
aicardsincommand=


The issue manifests itself ONLY when:
1. A tapland is on top of the player's library.
2. The player uses Necropotence to draw that tapland at the beginning of his end step.
3. Next turn, the player puts that tapland into play. At that moment, the following crash occurs:

RuntimeException | Open

Code: Select all

Forge Version:    SVN
Operating System: Linux 3.8.0-26-generic amd64
Java Version:     1.7.0_51 Oracle Corporation

java.lang.RuntimeException: AbilityFactory : getAbility -- no API in :
   at forge.game.ability.AbilityFactory.getAbility(AbilityFactory.java:106)
   at forge.game.replacement.ReplacementHandler.executeReplacement(ReplacementHandler.java:175)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:134)
   at forge.game.replacement.ReplacementHandler.run(ReplacementHandler.java:71)
   at forge.game.GameAction.changeZone(GameAction.java:221)
   at forge.game.GameAction.moveTo(GameAction.java:458)
   at forge.game.GameAction.moveTo(GameAction.java:439)
   at forge.game.player.Player.playLand(Player.java:1604)
   at forge.player.HumanPlay.playSpellAbility(HumanPlay.java:88)
   at forge.player.PlayerControllerHuman.playChosenSpellAbility(PlayerControllerHuman.java:939)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:958)
   at forge.game.GameAction.startGame(GameAction.java:1481)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:220)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:744)


To reproduce it with the test case file above, do the following:

1. Load the test case using "Setup game state".
2. Use Necropotence once, then wait for your next turn (in the process you'll draw a Bojuka Bog which was previously exiled face down via Necropotence).
3. On your turn, put that Bojuka Bog into play. Witness the crash.

Currently I'm baffled as to what exactly is causing this, and why it has anything to do with Replacement Effects. Can anyone please help me crack this one?..

- Agetian

[Hanmac]

Agetian found the culprit, for some reason the card in ReplacementHandler still thought it was a faceDown card ...
and faceDown does not have that SVar.


Hm for better debugging i would vote for that "AbilityFactory.getAbility" be slightly rewritten or extended.

in most cases its "getAbility(card.getSVar(var), card)" but if card.getSVar does return "" for some reason, then we get only "no API in" which is not very helpful ...

we might do some "getAbilitySVar(card, var)" or something that does do the check if card has the SVar and does warn us if it has not.

[Agetian]

Yeah, that sounds like a good idea. By now I have come to accept that the whole "No API" thing can mean a whole range of things, from a banal mistype in the card script that references a non-existent SVar to issues such as the Necropotence issue discussed above. A little bit more detailed information on the cause of the problem (such as the potentially missing SVar) would have been nice indeed.

Thanks for fixing the issue promptly, Hanmac!

- Agetian

[mastroego]

Perhaps even add Briarbridge patrol <.<

I believe you'll find it in the last or next snapshot build.

[mcrawford620]

I'm pretty much done with my little branch LimitedCardRanker. It tries to use the DeckHints more liberally to find card synergies when drafting and building limited decks. I added a bunch of hints to SOI, OGW, and BFZ cards. I was going take a pass at Eldritch Moon soon when I have time.

I've merged in the trunk changes to my branch, so the merge back in should be pretty painless. Does someone want/need to take a look at it before I merge it in? Or have any suggestions/changes?

[Agetian]

I'm pretty much done with my little branch LimitedCardRanker. It tries to use the DeckHints more liberally to find card synergies when drafting and building limited decks. I added a bunch of hints to SOI, OGW, and BFZ cards. I was going take a pass at Eldritch Moon soon when I have time.

I've merged in the trunk changes to my branch, so the merge back in should be pretty painless. Does someone want/need to take a look at it before I merge it in? Or have any suggestions/changes?

I just want to say that I monitored your commits in the branch and I really like the project, I think it'll be a nice addition to the upcoming release! I don't think I have any specific suggestions for the project, except maybe that in the future some of the older cards get deck synergy hints for the AI as well. Overall, best of luck with merging it back to trunk!

- Agetian

[mcrawford620]

I just want to say that I monitored your commits in the branch and I really like the project, I think it'll be a nice addition to the upcoming release! I don't think I have any specific suggestions for the project, except maybe that in the future some of the older cards get deck synergy hints for the AI as well. Overall, best of luck with merging it back to trunk!

- Agetian

Thanks, I'm really glad you've monitored it since I haven't contributed anything here for a few years. I do want to go back and do older sets as I have the time; I figured more people would be drafting the newer sets right now, and I was more familiar with them. It takes me a bit of time to look over a set and understand what the major things going on are. Also, I started with BFZ and OGW in particular because I got my work lunch gaming group to play some with a little set cube I made up, so I was familiar with the archetypes for that block. It's been fun working on it!

[Agetian]

Yeah, indeed! Agreed!

- Agetian

[mcrawford620]

OK, I have merged in and committed my branch. It works as far as I can tell. Wow, the whole merge thing took an hour and half of mostly just sitting around. Merge, update, commit, switch, fail merge, update, merge, fail, update, commit... my connection was really slow tonight so every merge took forever.

[Agetian]

Thanks a lot for this project! Will give it a test soon and will report if any problems arise. Good luck with the future improvements, too!

- Agetian

[Xitax]

.Skirsdag High Priest, Demonic Rising should use both demon token images.

Reign of the Pit has a CNS token image.

BFZ and OGW eldrazi scion token producers should use all 6 tokens - it's not clear which belongs to which...

Predator's Howl should use the CNS token - only 1 of 3 CNS wolf token producers are not reprints.

Selvala's Guide should use the CNS token - again 1 of 3.

Custodi Soulbinders, Rousing of Souls can use the CNS token.

[Agetian]

The token update was added to trunk. Thanks, Xitax!

- Agetian

[friarsol]

Crazy what are the names of the Melded cards (Chittering Host, etc) on the server?