It is currently 21 Nov 2019, 05:43
   
Text Size

Card Ligatures and YOU!

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Card Ligatures and YOU!

Postby friarsol » 22 Sep 2016, 02:41

So, it looks like we might have a small issue with AE ligature conversions to Ae. For the Kaladesh card, "Aether Tradewinds" everywhere in Forge it's listed as AEther Tradewinds. I think for now, we can just adjust the edition file to be the existing version, but we should come up with a plan to convert the ligature across the board. We can probably do this for all ligature cards at the same time, but basically we'll need to convert editions files AND on-the-fly loading of decks.

Anyone interested in taking that on?
friarsol
Global Moderator
 
Posts: 7479
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 937 times

Re: Card Ligatures and YOU!

Postby Agetian » 27 Sep 2016, 18:07

By the way, as a little related observation, this might also require the conversion of card picture names *or* exceptional treating of AE/Ae in card picture file names in the code (the latter would be preferable, I guess), otherwise the cards with AE in their names won't show up correctly on any case-sensitive operating system (which in case of Forge means Linux, MacOS, anything BSD, and Android).

Hmm, so basically we need all the cards that had AE in them to now have Ae, right?
What should this cover? For example:

* editions files (AE->Ae everywhere);
* decks (deck loader should be able to load both the AE version and the Ae version);
* card pictures (card picture loader should be able to load both the AE version and the Ae version to operate correctly on case-sensitive operating systems).

Anything else I'm missing here?

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Card Ligatures and YOU!

Postby Hanmac » 27 Sep 2016, 18:55

i think the most easy way would be to allow the card to have an Alternate Name where it does look for it too.

like if it does not find "Aether Tradewinds" it does try "AEther Tradewinds".

that would fix the problems with converting for now.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Card Ligatures and YOU!

Postby Marek14 » 28 Sep 2016, 06:24

To make it simpler, note that all cards with the AE ligature contain the word "AEther", with just a single exception (AErathi Berserker).
Marek14
Tester
 
Posts: 2667
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 270 times

Re: Card Ligatures and YOU!

Postby Hanmac » 05 Oct 2016, 08:51

i added "AltName" to Card scripts so this is possible:
Code: Select all
Name:Aetherflame Wall
AltName:AEtherflame Wall
what works: without changing the set files, the card is found under its new name. (Set has AEtherflame Wall, but it gets Aetherflame Wall)
That will work with already created Deck files.

What does not work yet:
i didn't manage to get it with the Imagekey loading.
it should try Name first and if that fails it should try AltName.
but it didn't do as i want yet.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Card Ligatures and YOU!

Postby Agetian » 05 Oct 2016, 09:33

Nice job so far, Hanmac! It'd be important to get it working with ImageKey properly as well since pretty much any non-Windows system, including Android, is otherwise going to suffer from missing images when being unable to load the image by the alt-name key...

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Card Ligatures and YOU!

Postby Hanmac » 05 Oct 2016, 09:39

yeah i know ;P thats why i said that ImageKey is not converted yet to understand AltName (i have linux)

i need to see how many functions i need to rewrite to make it working like that. probably everywhere "getImageKey" is used. :(
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 5 guests


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 553 on 18 Nov 2019, 23:05

Users browsing this forum: No registered users and 5 guests

Login Form