It is currently 14 Nov 2019, 16:55
   
Text Size

Upcoming Release: Forge version 1.5.57

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Re: Upcoming Release: Forge version 1.5.57

Postby Xitax » 02 Oct 2016, 00:44

I also tried and failed. I might have to take pictures of packs again...
Xitax
 
Posts: 865
Joined: 16 May 2010, 17:19
Has thanked: 159 times
Been thanked: 117 times

Re: Upcoming Release: Forge version 1.5.57

Postby Agetian » 02 Oct 2016, 05:08

Would be nice if you could do it, Xitax! :)

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Upcoming Release: Forge version 1.5.57

Postby friarsol » 06 Oct 2016, 12:50

Krazy, any chance you'll be able to roll another release this weekend? I'm not going to be around, but between everyone we should be able to fire it off and post the new version.
friarsol
Global Moderator
 
Posts: 7477
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 936 times

Re: Upcoming Release: Forge version 1.5.57

Postby Agetian » 08 Oct 2016, 07:04

In r32301 I updated Kaya, Ghost Assassin to get rid of the somewhat counterintuitive targeting mechanism where first you target a creature and then decide whether to exile the creature of Kaya herself. Things seem to work correctly according to my testing, but I'm not sure if maybe there was a bigger reason to implement it the way it was implemented. If there was a reason for that, let me know and I'll revert that part.

EDIT: Reverted it since apparently Kaya does not target herself (which is odd and tbh I would never have guessed that it has to work the way it has to work, lol).

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Upcoming Release: Forge version 1.5.57

Postby Hanmac » 08 Oct 2016, 09:25

I am currently doing some tweaking of her first ability. Hope to get it finish before next release.
Need three four different way for:
  • Without Target: exile herself if she is still on the battlefield. (Do Check StrictlySelf)
  • With Target: if she does choose herself (StrictlySelf check too)
  • with Target: choose Target
  • Without Target: but no exile.

after reading some post I found the last in the list is possible too. Hm maybe I don't need to rewrite as much as I thought.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Upcoming Release: Forge version 1.5.57

Postby friarsol » 08 Oct 2016, 13:49

Hanmac wrote:I am currently doing some tweaking of her first ability. Hope to get it finish before next release.
Need three four different way for:
  • Without Target: exile herself if she is still on the battlefield. (Do Check StrictlySelf)
  • With Target: if she does choose herself (StrictlySelf check too)
  • with Target: choose Target
  • Without Target: but no exile.

after reading some post I found the last in the list is possible too. Hm maybe I don't need to rewrite as much as I thought.
#2 doesn't matter. If she targets herself, and she's not on the battlefield the ability will fizzle
friarsol
Global Moderator
 
Posts: 7477
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 936 times

Re: Upcoming Release: Forge version 1.5.57

Postby Hanmac » 08 Oct 2016, 15:40

@friarsol: no its like that:
if you do target a creature, and THEN choose that Kaya should exile herself she needs to be on the battlefield for that.

(Kaya does not target herself which is the main reason for that problem)
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Upcoming Release: Forge version 1.5.57

Postby KrazyTheFox » 09 Oct 2016, 13:36

I can definitely get a new release out tomorrow.
User avatar
KrazyTheFox
Programmer
 
Posts: 725
Joined: 18 Mar 2014, 23:51
Has thanked: 66 times
Been thanked: 226 times

Re: Upcoming Release: Forge version 1.5.57

Postby friarsol » 12 Oct 2016, 01:06

KrazyTheFox wrote:I can definitely get a new release out tomorrow.
Any luck?
friarsol
Global Moderator
 
Posts: 7477
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 936 times

Re: Upcoming Release: Forge version 1.5.57

Postby KrazyTheFox » 14 Oct 2016, 14:25

Sorry, no. Plans unexpectedly changed and I ended up being busy for the past few days. I'll make another attempt today.
User avatar
KrazyTheFox
Programmer
 
Posts: 725
Joined: 18 Mar 2014, 23:51
Has thanked: 66 times
Been thanked: 226 times

Re: Upcoming Release: Forge version 1.5.57

Postby Agetian » 14 Oct 2016, 15:06

Important: As of r32344, Forge for Android no longer compiles with the following error message:

Code: Select all
forge.game.card.Card: can't find referenced method 'void sort(java.util.Comparator)' in class java.util.List
[INFO]       You should check if you need to specify additional program jars.
This may be related to a change in Card.java implemented in r32344?.. The method in question is possibly missing in the Android SDK we're targeting.

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Upcoming Release: Forge version 1.5.57

Postby friarsol » 14 Oct 2016, 15:07

Agetian wrote:Important: As of r32344, Forge for Android no longer compiles with the following error message:

Code: Select all
forge.game.card.Card: can't find referenced method 'void sort(java.util.Comparator)' in class java.util.List
[INFO]       You should check if you need to specify additional program jars.
This may be related to a change in Card.java implemented in r32344?.. The method in question is possibly missing in the Android SDK we're targeting.

- Agetian
Ah I'll check it out.
friarsol
Global Moderator
 
Posts: 7477
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 936 times

Re: Upcoming Release: Forge version 1.5.57

Postby Agetian » 14 Oct 2016, 15:24

Works now, thanks for the prompt resolution, Sol!

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Upcoming Release: Forge version 1.5.57

Postby friarsol » 14 Oct 2016, 15:51

Agetian wrote:Works now, thanks for the prompt resolution, Sol!
Been doing a lot of Python lately, totally wasn't thinking that Java was finicky about how you have to sort.
friarsol
Global Moderator
 
Posts: 7477
Joined: 15 May 2010, 04:20
Has thanked: 241 times
Been thanked: 936 times

Re: Upcoming Release: Forge version 1.5.57

Postby KrazyTheFox » 15 Oct 2016, 03:54

Before I do the release, is there anything notable that needs to be in the changes file?
User avatar
KrazyTheFox
Programmer
 
Posts: 725
Joined: 18 Mar 2014, 23:51
Has thanked: 66 times
Been thanked: 226 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 7 guests


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 427 on 11 Nov 2019, 13:00

Users browsing this forum: No registered users and 7 guests

Login Form