Aether Revolt Spoiler Season

[friarsol]

Here's an archive with Marek's submitted cards so far split into individual files.

- Agetian

If they seem to work, people can just upload them to the upcoming folder. The more eyes the better.

[Agetian]

I haven't tested them in the game yet, but generally the scripts look fine, so I guess I'll commit them to the "upcoming" folder and then let's see if people can identify any issues and bugs in them, right?

- Agetian

[friarsol]

I haven't tested them in the game yet, but generally the scripts look fine, so I guess I'll commit them to the "upcoming" folder and then let's see if people can identify any issues and bugs in them, right?

- Agetian

As long as they don't crash and pass the smell test I think I'd be ok with that. The upcoming folder is basically a holding area for unreleased cards.

We should just make sure to create a blank editions file for Aether Revolt so all the cards get assigned into it.

[Agetian]

I added a small placeholder editions file and tested the cards in the deck editor, they don't crash the game when their script is loaded and when they are visualized in the deck editor. Haven't tested in an actual game yet.

- Agetian

[Agetian]

Some notes: I noticed that Sun Titan has split triggers, one for ETB, one for attacking, with different wordings, instead of the "Secondary" syntax that seems to be standard.

Also, some abilities that animate artifacts into artifact creatures just add "Creature" instead of "Artifact,Creature". This matters in cases where the permanent got its artifact type through a temporary effect like Liquimetal Coating.

I updated Sun Titan to the Secondary syntax.
Also, updated some of the effects I could find with "noncreature artifact becomes an artifact creature", please let me know if that's what you meant.

- Agetian

[Agetian]

I coded Kari Zev, Skyship Raider and Kari Zev's Expertise today, both are added to upcoming.

- Agetian

[Marek14]

OK, I plan to go through the set today and code what I can. Here's the first batch:

Please check that Ajani's Aid is working correctly, it's quite complicated.

[Hanmac]

about new cards:
Scrounging Bandar - MoveCounter currently does not support "Amount$ Any" might be helpful for that. (i know its possible to use ChooseNumber before, but i think its better if MoveCounter can do that itself)
Maulfist Revolutionary - for that is probably doable with a loop, but i think a New Effect might be the right choice. (so it can have special AI coded there)

[Marek14]

Second batch.

Question -- I'm using Ceaseless Searblades to code Crackdown Construct, but the code of Ceaseless Searblades seems weird. It has an AbilityCast trigger and TapsForMana trigger, but does it cover mana abilities that don't require tapping (like Manaforge Cinder)? Also, it probably needs a Secondary$ clause.

[Hanmac]

Marek14: looks good so far, but Alley Evasion, Charm Spells does not need SpellDescription, its auto generated and is the original one is ignored.

EDIT: i added Revolt similar to all other conditions like Hellbent or FatefulHour
currently there is no way to calculate it. i wanted to make it similar than Morbid, but it didn't work as i wanted, so i add it in GameAction#changeZone

[Agetian]

OK, I plan to go through the set today and code what I can. Here's the first batch:

Please check that Ajani's Aid is working correctly, it's quite complicated.

Hmm, Ajani's Aid does not work correctly, it does the search (at least in the library, anyway) but doesn't let you choose Ajani, Valiant Protector and put it into play afterwards :/

- Agetian

[Marek14]

OK, I plan to go through the set today and code what I can. Here's the first batch:

Please check that Ajani's Aid is working correctly, it's quite complicated.

Hmm, Ajani's Aid does not work correctly, it does the search (at least in the library, anyway) but doesn't let you choose Ajani, Valiant Protector and put it into play afterwards :/

- Agetian

Hm, I took that part from Liberating Combustion. I thought if there will be problems, it will be in the damage prevention part...

Hanmac: So, I can code cards with Revolt wording, they just won't work for now? In that case, can I just code cards with improvise by adding K:Improvise line?

EDIT: Trying to code Daredevil Dragster with help of Clockwork Avian - is there a better condition than "Card.blocking"? For example, if Clockwork Avian regenerates while blocking, it will be removed from combat, but it should still count as having blocked. Conversely, if something puts it onto the battlefield blocking, it should not trigger because it wasn't declared as a blocker. Could you add blockedThisCombat condition similar to attackedThisCombat?

[Hanmac]

Revolt is coded so it should just work for new cards. (Like Hellbent) Improvise is not coded yet so it would not work.

For the "blockedThisCombat" i will see what I can do.

[Marek14]

Third batch.

[Agetian]

Hm, I took that part from Liberating Combustion. I thought if there will be problems, it will be in the damage prevention part...

Ah, found out what was wrong, turns out the name had to be specified with a ";" (semicolon) instead of a colon, I fixed that part, but sadly the damage prevention part does not work - first of all, looks like the activation cost is wrong ( instead of "sacrifice Ajani's Aid" ), but even if you pay, it lets you choose the card but it does not prevent combat damage from the chosen card :/ Maybe it can be written using ChooseSource like Circles of Protection and stuff?

- Agetian