name-mutator.txt and NameChanger.java files

[Chris H.]

In a brief and lucid moment I removed the name-mutator.txt file from my local copy and edited the NameChanger.java file. I built the project and there were no errors or warnings. I ran this version of the game and it works. Both the Deck Editor and the game itself. wow.

I will attach my edited NameChanger.java file and will let Dennis do a file compare to see what I did. If he feels that there will be no repercussions with my work, great. Merge this with the SVN and remove that pesky name-mutator.txt file!

Code: Select all

package forge;
import java.io.BufferedReader;
import java.io.FileReader;
import java.util.HashMap;
import java.util.Iterator;
import java.util.Map;
import java.util.StringTokenizer;

import forge.error.ErrorViewer;
import forge.properties.ForgeProps;
import forge.properties.NewConstants;


@SuppressWarnings("unused")
public class NameChanger implements NewConstants {
    private Map<String, String> mutatedMap  = new HashMap<String, String>();
    private Map<String, String> originalMap = new HashMap<String, String>();
   
    private boolean             changeCardName;
   
    public NameChanger() {
//        readFile();
        setShouldChangeCardName(false);
    }
   
    //should change card name?
    public boolean shouldChangeCardName() {
        return changeCardName;
    }
   
    public void setShouldChangeCardName(boolean b) {
        changeCardName = b;
    }
   
    //returns an array of copies
    public Card[] changeCard(Card c[]) {
        for(int i = 0; i < c.length; i++)
            changeCard(c[i]);
       
        return c;
    }
   
    //changes card name, getText(), and all SpellAbility getStackDescription() and toString()
    public Card changeCard(Card c) {
        //change name
        String newName = changeName(c.getName());
        c.setName(newName);
       
        //change text
        String s;
        s = c.getSpellText();
        c.setText(changeString(c, s));
       
        //change all SpellAbilities
        SpellAbility[] spell = c.getSpellAbility();
        for(int i = 0; i < spell.length; i++) {
            s = spell[i].getStackDescription();
            spell[i].setStackDescription(changeString(c, s));
           
            s = spell[i].toString();
            spell[i].setDescription(changeString(c, s));
        }
       
        return c;
    }//getMutatedCard()
   
    public String changeString(Card c, String in) {
        //String name = getOriginalName(c.getName()); // unused
//    in = in.replaceAll(name, changeName(name));
       
        return in;
    }
   
    //always returns mutated (alias) for the card name
    //if argument is a mutated name, it returns the same mutated name
    public String changeName(String originalName) {
        Object o = mutatedMap.get(originalName);
       
        if(o == null) return originalName;
       
        return o.toString();
    }//getMutatedName()
   
    //always returns the original cardname
    //if argument is a original name, it returns the same original name
    public String getOriginalName(String mutatedName) {
        Object o = originalMap.get(mutatedName);
       
        if(o == null) return mutatedName;
       
        return o.toString();
    }//getOriginalName()
/*   
    private void readFile() {
        try {
            BufferedReader in = new BufferedReader(new FileReader(ForgeProps.getFile(NAME_MUTATOR)));
           
            String line = in.readLine();
           
            //stop reading if end of file or blank line is read
            while(line != null && (line.trim().length() != 0)) {
                processLine(line.trim());
               
                line = in.readLine();
            }//while
        }//try
        catch(Exception ex) {
//~      throw new RuntimeException("NameMutator : readFile() error, " +ex);
           

            //~ (could be cleaner...)
            try {
                BufferedReader in = new BufferedReader(new FileReader(ForgeProps.getFile(NAME_MUTATOR)));
               
                String line;
               
                //stop reading if end of file or blank line is read
                while((line = in.readLine()) != null && (line.trim().length() != 0)) {
                    processLine(line.trim());
                }//while
            } catch(Exception ex2) {
                // Show orig exception
                ErrorViewer.showError(ex2);
                throw new RuntimeException(String.format("NameMutator : readFile() error, %s", ex), ex);
            }
            //~
        }
    }//readFile()
*/   
    //line is formated "original card name : alias card name"
//    @SuppressWarnings("unused")
   private void processLine(String line) {
        StringTokenizer tok = new StringTokenizer(line, ":");
       
        if(tok.countTokens() != 2)
            throw new RuntimeException(
                    "NameMutator : processLine() error, invalid line in file name-mutator.txt - " + line);
       
        String original = tok.nextToken().trim();
        String mutated = tok.nextToken().trim();
       
        mutatedMap.put(original, mutated);
        originalMap.put(mutated, original);
    }
   
//    @SuppressWarnings("unused")
    // printMap
    private void printMap(Map<String, String> map) {
        Iterator<String> it = map.keySet().iterator();
        String key;
        for(int i = 0; i < 5; i++) {
            key = it.next().toString();
            System.out.println(key + " : " + map.get(key));
        }
    }
   
    public static void main(String[] args) {}//main()
}

`

[Chris H.]

OK, I spent some more time analyzing the NameChanger.java file and found a very simple way to achieve the same result.

All we have to do is comment out line 21. This line calls the readFile method which in turn reads in the data from the name-mutator.txt file.

Code: Select all

20      public NameChanger() {
21  //      readFile();
22          setShouldChangeCardName(false);
23      }

[DennisBergkamp]

Sure, looks good to me, thanks Chris

[Chris H.]

OK, r205 on the SVN contains this update and we can say goodbye to the name mutator file.