Page 1 of 1

Unify confirm GUI

PostPosted: 20 Jan 2017, 20:25
by pfps
Right now there are two ways of getting user confirmation in the desktop GUI. Some confirmations use a pop-up window. Some confirmations use the prompt pane.

I don't see any reason to keep both methods. If I don't hear any reason to keep both, I'll start moving confirmations over to one method. As I don't like pop-ups, that will be via the input pane.

Re: Unify confirm GUI

PostPosted: 20 Jan 2017, 20:43
by friarsol
That's mostly how they got to this state to begin with. Lots of them were pop-ups, and a bunch of the easier ones were converted.

Re: Unify confirm GUI

PostPosted: 20 Jan 2017, 20:46
by pfps
OK. I think that there is infrastructure to easily move most of them over so I'll give it a try.

Re: Unify confirm GUI

PostPosted: 21 Jan 2017, 16:33
by pfps
It wasn't as easy as I thought, as sometimes there is a card to show but no spellability so the prompt pane had to be changed to work with a cardview.
I did move several over.

One that might not be possible to move over is the prompt inside the mulligan confirmation.

Re: Unify confirm GUI

PostPosted: 25 Jan 2017, 02:19
by pfps
In the desktop interface almost all confirmations use the prompt area. The mobile interface doesn't yet.