Re: Amonkhet Spoiler Season
so all cards are out, tell me when you need code changes
@Marek14:
Vizier of Many Faces: Clone Effect now has Embalm$ param which does set that stuff but only if card is embalmed.
===
PS: i did look at CloneEffect, for such thing we always need:
1) why using Remembered when it can already access ChosenCard?
2) even when using that, in both cases there is Cleanup missing (i know it might not be that important, but i prefer to clean my stuff when not needed anymore, also to prevent side effects)
i want to put the choose card effect into CloneEffect itself
that would make the code a bit shorter, and maybe it could be better for the AI too.
@Marek14:
Vizier of Many Faces: Clone Effect now has Embalm$ param which does set that stuff but only if card is embalmed.
===
PS: i did look at CloneEffect, for such thing we always need:
- Code: Select all
K:ETBReplacement:Copy:ChooseCreature:Optional
SVar:ChooseCreature:DB$ ChooseCard | Cost$ 0 | Defined$ You | Amount$ 1 | Choices$ Creature.Other | SubAbility$ DBCopy | RememberChosen$ True | AILogic$ Clone | SpellDescription$ You may have CARDNAME enter the battlefield as a copy of
SVar:DBCopy:DB$ Clone | Defined$ Remembered
1) why using Remembered when it can already access ChosenCard?
2) even when using that, in both cases there is Cleanup missing (i know it might not be that important, but i prefer to clean my stuff when not needed anymore, also to prevent side effects)
i want to put the choose card effect into CloneEffect itself
that would make the code a bit shorter, and maybe it could be better for the AI too.