It is currently 17 Nov 2019, 03:02
   
Text Size

Starter projects new developer

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Starter projects new developer

Postby austinio7116 » 24 Apr 2017, 19:14

Hi all,

At friarsol's request, as a potential new developer to the project I am going to make a few minor fixes as a first foray into the codebase. This is what I plan to fix/add:

1: make the quest mode shop selling percentages editable in the preferences (very easy but I'll enjoy the result)
2: make the black borders in the desktop version optional - so i can use my same image set for the desktop and the android versions
3: Fix the display of the aftermath card images in list views on the android version (I need to double check this has not already been fixed or if someone is planning to fix it first.
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times

Re: Starter projects new developer

Postby Agetian » 25 Apr 2017, 04:36

Sounds like reasonable and interesting additions, good luck!

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Starter projects new developer

Postby austinio7116 » 25 Apr 2017, 17:37

Here is the patch. I'll upload this via SVN if I get approval.
Attachments
austinio7116.txt
(12.73 KiB) Downloaded 47 times
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times

Re: Starter projects new developer

Postby Agetian » 25 Apr 2017, 20:20

Thanks a lot for your effort, Austinio!
I'll test the patch tomorrow morning (it's a bit late in my time zone...) and I'll get back to you with the results of how things work on my end!

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Starter projects new developer

Postby austinio7116 » 25 Apr 2017, 21:09

Hi Agetian, friarsol has already taken a look at it, but please feel free to try it out. I am going to commit it to SVN if you'd rather wait for that and save patching it.
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times

Re: Starter projects new developer

Postby austinio7116 » 25 Apr 2017, 22:01

All committed to SVN rev 33847
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times

Re: Starter projects new developer

Postby Agetian » 26 Apr 2017, 04:32

Thanks a lot for the submission, Austinio, and welcome to the team! :D

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Starter projects new developer

Postby Agetian » 26 Apr 2017, 05:41

Did some testing and things seem to work fine on my end! :) One minor thing, I'm quite positive it's already known, but just in case: Amonkhet splits currently show the same face twice instead of showing the two different faces.

- Agetian
Agetian
Programmer
 
Posts: 3359
Joined: 14 Mar 2011, 05:58
Has thanked: 644 times
Been thanked: 499 times

Re: Starter projects new developer

Postby austinio7116 » 27 Apr 2017, 07:37

Yes - that was all I managed to do so far. Getting the second image rotated and resized to fit under the first image will require a fair bit more refactoring to get right.
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times

Re: Starter projects new developer

Postby austinio7116 » 14 May 2017, 20:24

Just in case anyone is reading this old thread, the aftermath card second image is now correctly rotated and shown below the top image in the list views.
User avatar
austinio7116
 
Posts: 421
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 149 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 5 guests


Who is online

In total there are 5 users online :: 0 registered, 0 hidden and 5 guests (based on users active over the past 10 minutes)
Most users ever online was 546 on 15 Nov 2019, 10:18

Users browsing this forum: No registered users and 5 guests

Login Form