Starter projects new developer

[austinio7116]

Hi all,

At friarsol's request, as a potential new developer to the project I am going to make a few minor fixes as a first foray into the codebase. This is what I plan to fix/add:

1: make the quest mode shop selling percentages editable in the preferences (very easy but I'll enjoy the result)
2: make the black borders in the desktop version optional - so i can use my same image set for the desktop and the android versions
3: Fix the display of the aftermath card images in list views on the android version (I need to double check this has not already been fixed or if someone is planning to fix it first.

[Agetian]

Sounds like reasonable and interesting additions, good luck!

- Agetian

[austinio7116]

Here is the patch. I'll upload this via SVN if I get approval.

[Agetian]

Thanks a lot for your effort, Austinio!
I'll test the patch tomorrow morning (it's a bit late in my time zone...) and I'll get back to you with the results of how things work on my end!

- Agetian

[austinio7116]

Hi Agetian, friarsol has already taken a look at it, but please feel free to try it out. I am going to commit it to SVN if you'd rather wait for that and save patching it.

[austinio7116]

All committed to SVN rev 33847

[Agetian]

Thanks a lot for the submission, Austinio, and welcome to the team!

- Agetian

[Agetian]

Did some testing and things seem to work fine on my end! One minor thing, I'm quite positive it's already known, but just in case: Amonkhet splits currently show the same face twice instead of showing the two different faces.

- Agetian

[austinio7116]

Yes - that was all I managed to do so far. Getting the second image rotated and resized to fit under the first image will require a fair bit more refactoring to get right.

[austinio7116]

Just in case anyone is reading this old thread, the aftermath card second image is now correctly rotated and shown below the top image in the list views.