Re: Foil rarity fix patch (completed)
Posted: 16 Jul 2017, 19:09
Done, let's do these tests.
VMA 1000 packs, expected, 146 foil R, 20 foil M, 333 foil UC, 478 foil C, 18 Nonfoil specials, and 0.5 foil Special.
(I went with the assumption that foil P9 cards have the same rarity compared to nonfoil versions of them, as all other rares : 1 in ~30 is foil.)
Result : 24 foil M, 133 foil R, 327 foil UC 468 foil C, 3 foil P9 and 45 nonfoil P9.
...that's one in 26 packs instead of 53 twice as much as expected, I used random incorrectly?
Indeed, updating the number and trying again gave 20 nonfoil and 1 foil Specials.
ratio of other cards in the second batch was also correct, VMA testing complete.
Next, Time Spiral.
...is crashing. "No cards were found on sheet, TimeSpiral TSP". I haven't touched that, though. Did you? ...You sure did. You moved splitting the string from AFTER generating the sheetkey to before. That's not going to work, it uses that variable and needs it unsplitted. Using a simpler string splitting code is a great idea. Moving lines elsewhere however is never a good idea.
...let's try now.
34 rares, 65 Uncommons, 81 Commons, 28 Timeshifted.
Looks correct. (I did update timeshifted slot to be equal to rares.)
Arabian Nights.
35 rares, 67 Uncommons, 85 Commons, 18 timeshif...oh I didn't turn off the time spiral set, let's try again lol
32 rares, 68 uncommons, 106 commons.
Was expecting less rares and more uncommons here. I think it's 1 R for 3 U, not 1 for 2.
Let's roll 10k packs next.
368 rares, 727 Uncommons, 1072 commons.
That's odd, it's as if Rare and Uncommon slots were separate, even though they are shared.
...I have to assume even though the ratio of U to R is 3 to 1, the number of them are not equal, so the overall result is closer to 1 to 2. To prove this, I compare the nonfoils : 659 rares for 1341 uncommons. Indeed, this is the correct ratio, there are more rares in the set than uncommons.
Skipping Masques - it's a generic set with no interesting slots to test for.
Avycin Restored (10k)...
44 Mythics, 313 Rares, 703 Uncommons, 985 Commons.
Correct.
Dark Ascension (1k)...
NonDFC : 5 Mythics, 38 rares, 82 uncommons, 54 commons, 3 lands
DFC : 2 Mythic DFC, 12 Rare DFC, 6 uncommon DFC, 12 common DFC
about right but the UC is a bit high, C bit low. I would expect the two to be about the same. I have no idea what the rarity distribution in a DFC slot should be so I can't judge that.
One more roll.
NonDFC : 1 Mythic, 32 rare, 74 uncommon, 65 common, 2 lands
DFC : 3 Mythics, 14 rare, 10 uncommon, 4 common
This is closer to what's expected tho the RNG still favors uncommons over commons, the difference is only 7 now if counting lands (which do consume the common roll).
...speaking of consuming common rolls. I think that's not the best idea. I'm going to rewrite that part so each type gets it's own chance instead of being a subset of commons. This method results in 1/2/2/1 in Time Spiral for example (R/U/C/S) when I believe it should be 1/2/3/1.
VMA 1000 packs, expected, 146 foil R, 20 foil M, 333 foil UC, 478 foil C, 18 Nonfoil specials, and 0.5 foil Special.
(I went with the assumption that foil P9 cards have the same rarity compared to nonfoil versions of them, as all other rares : 1 in ~30 is foil.)
Result : 24 foil M, 133 foil R, 327 foil UC 468 foil C, 3 foil P9 and 45 nonfoil P9.
...that's one in 26 packs instead of 53 twice as much as expected, I used random incorrectly?
Indeed, updating the number and trying again gave 20 nonfoil and 1 foil Specials.
ratio of other cards in the second batch was also correct, VMA testing complete.
Next, Time Spiral.
...is crashing. "No cards were found on sheet, TimeSpiral TSP". I haven't touched that, though. Did you? ...You sure did. You moved splitting the string from AFTER generating the sheetkey to before. That's not going to work, it uses that variable and needs it unsplitted. Using a simpler string splitting code is a great idea. Moving lines elsewhere however is never a good idea.
...let's try now.
34 rares, 65 Uncommons, 81 Commons, 28 Timeshifted.
Looks correct. (I did update timeshifted slot to be equal to rares.)
Arabian Nights.
35 rares, 67 Uncommons, 85 Commons, 18 timeshif...oh I didn't turn off the time spiral set, let's try again lol
32 rares, 68 uncommons, 106 commons.
Was expecting less rares and more uncommons here. I think it's 1 R for 3 U, not 1 for 2.
Let's roll 10k packs next.
368 rares, 727 Uncommons, 1072 commons.
That's odd, it's as if Rare and Uncommon slots were separate, even though they are shared.
...I have to assume even though the ratio of U to R is 3 to 1, the number of them are not equal, so the overall result is closer to 1 to 2. To prove this, I compare the nonfoils : 659 rares for 1341 uncommons. Indeed, this is the correct ratio, there are more rares in the set than uncommons.
Skipping Masques - it's a generic set with no interesting slots to test for.
Avycin Restored (10k)...
44 Mythics, 313 Rares, 703 Uncommons, 985 Commons.
Correct.
Dark Ascension (1k)...
NonDFC : 5 Mythics, 38 rares, 82 uncommons, 54 commons, 3 lands
DFC : 2 Mythic DFC, 12 Rare DFC, 6 uncommon DFC, 12 common DFC
about right but the UC is a bit high, C bit low. I would expect the two to be about the same. I have no idea what the rarity distribution in a DFC slot should be so I can't judge that.
One more roll.
NonDFC : 1 Mythic, 32 rare, 74 uncommon, 65 common, 2 lands
DFC : 3 Mythics, 14 rare, 10 uncommon, 4 common
This is closer to what's expected tho the RNG still favors uncommons over commons, the difference is only 7 now if counting lands (which do consume the common roll).
...speaking of consuming common rolls. I think that's not the best idea. I'm going to rewrite that part so each type gets it's own chance instead of being a subset of commons. This method results in 1/2/2/1 in Time Spiral for example (R/U/C/S) when I believe it should be 1/2/3/1.