Page 1 of 4

Commander 2017 spoiler season

PostPosted: 07 Aug 2017, 16:25
by Agetian
Looks like it's time for the upcoming Commander 2017 set spoilers. Some previews started appearing at Wizards.com (e.g. http://magic.wizards.com/en/articles/ar ... 2017-08-07 ), and various spoiler resources such as magicspoiler.com started showcasing some new stuff that wasn't previously revealed.

Let's see how many cards we can code and how easy/difficult it would be to support the tricky ones with code.

Feel free to post your submissions for Commander 2017 cards here. The dev team will do its best to test them ingame and integrate them upstream. Thanks in advance!

- Agetian

Re: Commander 2017 spoiler season

PostPosted: 08 Aug 2017, 09:08
by Marek14
Ok, here are 9 scripts: Arahbo, Roar of the World, Balan, Wandering Knight, Bloodforged Battle-Axe, Bloodline Necromancer, Hammer of Nazahn, Herald's Horn, Hungry Lynx, Nazahn, Revered Bladesmith, and Traverse the Outlands - as always, please check that they work correctly (I wrote them between bouts of working).

Especially Balan, that seems the most complicated.

I also include some corrections (mostly AB$ to DB$ changes) for other cards, this time I'll be putting the corrections into subdirectory.

So, out of 16 cards in MTGSalvation spoiler, we're missing 4:

O-Kagachi, Vengeful Kami: needs to know whether a player attacked you during his/her last turn.
Stalking Leonin: has secret choice of player and cost that involves revealing that choice.
Mirri, Weatherlight Duelist: not sure, the abilities might be doable but not sure how. Temporary effect created for her attack trigger? Not sure if that's the best solution.
Alms Collector: a new kind of replacement condition -- please read http://magicjudge.tumblr.com/post/16391 ... e-confused before attempting to implement, and they might still change the rules a bit.

Re: Commander 2017 spoiler season

PostPosted: 08 Aug 2017, 12:24
by Agetian
Thanks a lot, Marek! All integrated after some corrections in a few places. Now all tested to work ingame.

- Agetian

Re: Commander 2017 spoiler season

PostPosted: 08 Aug 2017, 13:22
by stormcat

Re: Commander 2017 spoiler season

PostPosted: 09 Aug 2017, 10:08
by Marek14
Next batch (all put together as I edited some of yesterday's cards).

6 new cards: Boneyard Scourge, Kindred Discovery, Kindred Summons, Mirror of the Forebears, Qasali Slingers, and Scalelord Reckoner.

As for the others:

Path of Ancestry will require some routine to check whether an object shares a creature type with your commander (and it needs to work with Partner).

Territorial Hellkite needs some check to see which player it attacked during your last combat.

Fractured Identity needs a way to say "all players except for the controller of ParentTarget"

Fortunate Few has complicated choosing scheme.

Re: Commander 2017 spoiler season

PostPosted: 09 Aug 2017, 11:51
by Marek14
One new card appeared:
Code: Select all
Name:Licia, Sanguine Tribune
ManaCost:5 R W B
Types:Legendary Creature Vampire Soldier
PT:4/4
S:Mode$ ReduceCost | ValidCard$ Card.Self | Type$ Spell | Amount$ X | EffectZone$ All | Description$ CARDNAME costs {1} less to cast for each life you gained this turn.
K:First Strike
K:Lifelink
A:AB$ PutCounter | Cost$ PayLife<5> | CounterType$ P1P1 | CounterNum$ 3 | PlayerTurn$ True | ActivationLimit$ 1 | SpellDescription$ Put 3 +1/+1 counters on CARDNAME. Activate this ability only during your turn, and only once each turn.
SVar:X:Count$LifeYouGainedThisTurn
SVar:Picture:http://www.wizards.com/global/images/magic/general/licia_sanguine_tribune.jpg
Oracle:Licia, Sanguine Tribute costs {1} less to cast for each life you gained this turn.\nFirst strike, lifelink\nPay 5 life: Put 3 +1/+1 counters on Licia. Activate this ability only during your turn, and only once each turn.

Re: Commander 2017 spoiler season

PostPosted: 09 Aug 2017, 12:54
by Agetian
Thanks a lot for your effort, Marek! Your changes and the 7 new cards have been committed after some modifications.

Have you changed anything in the previous cards except for two deck hints and the casting cost for Traverse the Outlands? I have changed the code for some of the cards before committing, so now it's a bit tricky for me since you're using your original code instead of the up-to-date one upstream to make changes, so it's a bit difficult to discern what exactly has changed... :/

If possible, please use the latest version of the card code (as in trunk) to make modifications. Here are all the C17 cards coded so far as they were committed upstream.

Re: Commander 2017 spoiler season

PostPosted: 09 Aug 2017, 12:59
by Marek14
I basically added tribal deck hints, that should be all :)

Re: Commander 2017 spoiler season

PostPosted: 09 Aug 2017, 13:19
by Agetian
Okie doke, yep, I added those in :)
Btw, tried to code Fractured Identity upstream, seems to do its job correctly.

- Agetian

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 08:25
by Marek14
I see you modified code for Arahbo, but I think you made a mistake there. I modeled the eminence condition based on Firemane Angel which has a similar quirk: the presence in a specified zone is a intervening if condition, and so the card must still be in the same zone when the ability resolves for the effect to happen. That's why I split it into two abilities.

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 09:40
by Agetian
Ah, interesting! Thanks for the info! I corrected the card script to account for that. :)
(The reason I originally changed it was because the original code didn't want to work - but now I realize that it was only due to IsPresent$ parameter being absent).

A question: you're also using a SVar for comparison in those two triggered abilities, which I don't really understand (and the ability seems to work without it): you're checking X for GE1, with X being the triggered card (Arahbo's) power. What's that necessary for? :/

- Agetian

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 10:11
by Marek14
Ah, that seems to be a mistake. Not sure why that was there.

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 10:48
by Agetian
Ok, should be all good then! Thanks! :)

- Agetian

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 12:12
by Marek14
Another batch with 12 cards. This will probably require a lot of testing and modifications, as many of the cards are rather complicated.

Cards included: Bloodsworn Steward, Crimson Honor Guard, Disrupt Decorum, Edgar Markov, Heirloom Blade, Inalla, Archmage Ritualist, Kheru Mind-Eater, Kindred Charge, Mathas, Fiend Seeker, New Blood, Patron of the Vein, Teferi's Protection.

For Mathas, I used the technique that is currently on Aquitect's Will and similar, but it's still not perfect -- what we need is a duration condition that will expire the moment the number of certain counters on a certain permanent equals 0 and won't be reenabled even if the same kind of counter if re-added.

Re: Commander 2017 spoiler season

PostPosted: 10 Aug 2017, 12:13
by Marek14
As for the other spoiled cards -- the Curse cycle might need some better conditions (if you implement one, I might be able to implement the others).