It is currently 13 Nov 2018, 02:57
   
Text Size

Unifying Keywords with Reminder Texts

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, friarsol, Blacksmith, KrazyTheFox, Agetian, CCGHQ Admins

Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 03 Sep 2017, 10:36

So I'm now on "crusade" against non-evergreen keywords without reminder texts.
This also includes former evergreen keywords.

Bushido (Devoted Retainer)
Cascade (Shardless Agent)
Conspire (Gleeful Sabotage) (Also: See if Wort, the Raidmother can be improved)
Cumulative upkeep (Uktabi Efreet)
Delve (Gurmag Angler)
Devoid (Vestige of Emrakul)
D1redge (Greater Mossdog)
Epic (Enduring Ideal)
Evolve (Adaptive Snapjaw)
Exalted (Akrasan Squire)
Extort (Syndic of Tithes)
Flanking (Benalish Cavalry)
Flashback (Think Twice)
Horsemanship (Wu Light Cavalry)
Infect (Glistener Elf)
Persist (Lingering Tormentor) (Notably a pain, does the text say creature or permanent?)
Phasing (Sandbar Crocodile)
Poisonous (Snake Cult Initiation)
Prowess (Nimble-Blade Khenra) (Evergreen Keyword)
Rampage (Wolverine Pack)
Ripple (Surging Sentinels) (Also: See if Thrumming Stone can be improved)
Shadow (Soltari Foot Soldier)
Skulk (Furtive Homunculus)
Split second (Krosan Grip)
Sunburst (Suntouched Myr) (Possible weird interaction with Arcbound Wanderer)
Totem armor (Eland Umbra)
Undying (Young Wolf) (See persist)
Wither (Sickle Ripper)

Former evergreen keywords;

Banding (Benalish Hero) (Cor blimey, look at that box!)
F1ear (Prickly Boggart)
Intimidate (Highborn Ghoul)
Shroud (Elvish Lookout)

Other odd keywords;

Awaken (Coastal Discovery) (Can we have this changed from "Awaken N - {Cost}" to "Awaken N—{Cost}")
Bloodthirst (Gorehorn Minotaurs) (It says "This permanent" instead of "this creature")
Devour (Thunder-Thrash Elder) (This has an odd colon in the middle of it "Devour:N")
Equip (Honed Khopesh) (Technically this should be removed as it is an evergreen keyword, but it's not really doing any harm, so we can leave it)
Hideaway (Shelldock Isle) (Oh boy, see below)
Prowl (Thieves' Fortune) (Is this even a hardcoded keyword?)
Reinforce (Mosquito Guard) (See Prowl)
Done
Replicate (Train of Thought) (Needs to change the barebones "Replicate 1 U " to "Replicate {1} {U} ")
Suspend (Durkwood Baloth) (See Awaken, "Suspend N—{Cost}")
U1nearth (Dregscape Zombie) (Similar to Devour, This has a colon at the end as if it is an activated ability "Un1earth {B}: ({B}: Return...)")

Hideaway - Hideaway is a weird case. On the card detail side, it has no reminder text, as all the text is written out like normal text. Compare:

"Hideaway
CARDNAME enters the battlefield tapped.

When CARDNAME enters the battlefield, look at the top four cards of your library, exile one face down, the put the rest on the bottom of your library."

with

"Hideaway (This land enters the battlefield tapped. When it does, look at the top four cards of your library, exile one face down, then put the rest on the bottom of your library.)"

So if these could be changed... that'll be great.
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 06 Sep 2017, 13:06

Bushido (Devoted Retainer)
Cascade (Shardless Agent)
Conspire (Gleeful Sabotage) (Also: See if Wort, the Raidmother can be improved)
Cumulative upkeep (Uktabi Efreet)
Delve (Gurmag Angler)*
Devoid (Vestige of Emrakul)
D1redge (Greater Mossdog)
Epic (Enduring Ideal)
Evolve (Adaptive Snapjaw)
Exalted (Akrasan Squire)
Extort (Syndic of Tithes)
Flanking (Benalish Cavalry)
Flashback (Think Twice)
Horsemanship (Wu Light Cavalry)
Infect (Glistener Elf)
Persist (Lingering Tormentor)
Phasing (Sandbar Crocodile)
Poisonous (Snake Cult Initiation)
Prowess (Nimble-Blade Khenra) (Evergreen Keyword)*
Rampage (Wolverine Pack)
Ripple (Surging Sentinels) (Also: See if Thrumming Stone can be improved)
Shadow (Soltari Foot Soldier)
Skulk (Furtive Homunculus)
Split second (Krosan Grip)
Sunburst (Suntouched Myr) (Possible weird interaction with Arcbound Wanderer)
Totem armor (Eland Umbra)
Undying (Young Wolf)
Wither (Sickle Ripper)


Former evergreen keywords;

Banding (Benalish Hero) (Cor blimey, look at that box!)
F1ear (Prickly Boggart)
Intimidate (Highborn Ghoul)
Shroud (Elvish Lookout)


Other odd keywords;

Awaken (Coastal Discovery) (Can we have this changed from "Awaken N - {Cost}" to "Awaken N—{Cost}")
Bloodthirst (Gorehorn Minotaurs) (It says "This permanent" instead of "this creature")
Devour (Thunder-Thrash Elder) (This has an odd colon in the middle of it "Devour:N")
Equip (Honed Khopesh) (Technically this should be removed as it is an evergreen keyword, but it's not really doing any harm, so we can leave it)
Hideaway (Shelldock Isle) (Oh boy)
Prowl (Thieves' Fortune) (Is this even a hardcoded keyword?)
Reinforce (Mosquito Guard) (See Prowl)
Done
Replicate (Train of Thought) (Needs to change the barebones "Replicate 1 U " to "Replicate {1} {U} ")
Suspend (Durkwood Baloth) (See Awaken, "Suspend N—{Cost}")
U1nearth (Dregscape Zombie) (Similar to Devour, This has a colon at the end as if it is an activated ability "Un1earth {B}: ( {B} : Return...)")
Last edited by Indigo Dragon on 06 Sep 2017, 13:48, edited 1 time in total.
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 06 Sep 2017, 13:11

Bushido N (Devoted Retainer)
Cascade (Shardless Agent, Bituminous Blast)
Conspire (Gleeful Sabotage) (Also: See if Wort, the Raidmother can be improved)
Cumulative upkeep {Cost} (Uktabi Efreet)
Delve (Gurmag Angler, Treasure Cruise)
Devoid (Vestige of Emrakul, Reality Hemorrahage)
D1redge N (Greater Mossdog, Life from the Loan)
Epic (Enduring Ideal)
Flashback {Cost} (Think Twice)
Poisonous N (Snake Cult Initiation)
Prowess (Nimble-Blade Khenra) (Evergreen Keyword)*
Rampage N (Wolverine Pack)
Ripple N (Surging Sentinels, Surging Aether) (Also: See if Thrumming Stone can be improved)
Split second (Krosan Grip, Qaugnoth)
Sunburst (Suntouched Myr, Clearwater Goblet) (Possible weird interaction with Arcbound Wanderer)
Totem armor (Eland Umbra)

Other odd keywords;
Awaken N—{Cost} (Coastal Discovery) (Can we have this changed from "Awaken N - {Cost}" to "Awaken N—{Cost}")
Devour N (Thunder-Thrash Elder) (This has an odd colon in the middle of it "Devour:N")
Hideaway (Shelldock Isle) (Oh boy)
Replicate {Cost} (Train of Thought) (Needs to change the barebones "Replicate 1 U " to "Replicate {1} {U} ")
Suspend N—{Cost} (Durkwood Baloth, Divine Congregation) (See Awaken, "Suspend N—{Cost}")
U1nearth {Cost} (Dregscape Zombie) (Similar to Devour, This has a colon at the end as if it is an activated ability "Un1earth {B}: ( {B} : Return...)")
Last edited by Indigo Dragon on 06 Sep 2017, 15:05, edited 1 time in total.
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby Agetian » 06 Sep 2017, 14:22

I fixed the issue with Devour and Awaken.

Btw, your latest commit broke compilation of Forge due to a mistype (keword instead of keyword), please make sure you test and ensure that Forge still compiles after making changes to the code ;)

- Agetian
Agetian
Programmer
 
Posts: 3278
Joined: 14 Mar 2011, 05:58
Has thanked: 629 times
Been thanked: 477 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 06 Sep 2017, 14:41

Oh, whoops. I can't exactly test using the methods I have available to me though, any help with that?
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby Agetian » 06 Sep 2017, 14:48

Indigo Dragon wrote:Oh, whoops. I can't exactly test using the methods I have available to me though, any help with that?
Hmm, I think you said you were using IntelliJ, right? You can use it to compile Forge and run it from inside the environment (click a dropdown box in the top right part of the screen, below the menu bar, and click "Edit Configurations..."; when there, click the "+" button and choose "Application"; set the Working directory to the forge-gui-desktop folder in the downloaded SVN repository; set "Use classpath of module" to "forge-gui-desktop"; then specify the Main class as "forge.view.Main" (click the "..." button and it should let you pick it) ). Then click OK. You should then be able to click the Run button to compile and run Forge from IntelliJ ;)

Alternatively, in that same window, click the "+" button and choose "Maven", specify the root folder of the downloaded SVN repository as the working directory, specify the command line as "clean install" and click OK. You should then be able to use this configuration to build Forge using the Maven process we're using to deploy the project. (This method can't be used to run Forge from IntelliJ though)

Come to think of it, since you're making modifications to the code, how exactly are you... testing them? :) I mean, you are testing the changes somehow, right? (that they work and do what you want them to do and all)

- Agetian
Agetian
Programmer
 
Posts: 3278
Joined: 14 Mar 2011, 05:58
Has thanked: 629 times
Been thanked: 477 times

Re: Unifying Keywords with Reminder Texts

Postby Agetian » 06 Sep 2017, 15:21

Forge doesn't compile again since you used a non-UTF-8 character in the source code :/ (interestingly, no, it wasn't the em-dash, it was some kind of a weird unprintable character in the very beginning of the file).

Please make sure you're only using UTF-8 characters in Java source files (and, once again, please make sure you set up an environment to test the changes by compiling Forge and running it after you've changed something in the source).

- Agetian
Agetian
Programmer
 
Posts: 3278
Joined: 14 Mar 2011, 05:58
Has thanked: 629 times
Been thanked: 477 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 07 Sep 2017, 07:42

Every time I try to compile in forge I get this error.
Android Pre Dex: [forge-gui-android] Android SDK is not specified.
I hope you can help me with this. The Internet isn't.
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby kevlahnota » 07 Sep 2017, 08:35

Indigo Dragon wrote:Every time I try to compile in forge I get this error.
Android Pre Dex: [forge-gui-android] Android SDK is not specified.
I hope you can help me with this. The Internet isn't.
What IDE do you use?

Edit:
If you use IntelliJ, try adding sdk path on your maven goal.
I use this one for windows build in IntelliJ(Just replace the path where you install your Android SDK):
Code: Select all
mvn -U -B clean -P windows-linux install -Dandroid.sdk.path=C:\android-sdk -T 1C
User avatar
kevlahnota
Programmer
 
Posts: 527
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 12 times
Been thanked: 152 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 07 Sep 2017, 11:04

Okay, So I installed Android SDK, set it up. Then it didn't work. :mad:
Then in my Rage, I removed the forge-gui-android from my project. Then it worked. Yay :).
Scared, but intrigued, I re added forge-gui-android back, in case it broke anything. It hasn't. So it works. Yay :-s ?

TL,DR: I can test things now. :D
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times

Re: Unifying Keywords with Reminder Texts

Postby Agetian » 07 Sep 2017, 17:41

Yeah, you can set IntelliJ to ignore forge-gui-android, then it won't require the SDK and stuff :) You don't need it all unless you're specifically planning to run/debug/code Forge for Android.

- Agetian
Agetian
Programmer
 
Posts: 3278
Joined: 14 Mar 2011, 05:58
Has thanked: 629 times
Been thanked: 477 times

Re: Unifying Keywords with Reminder Texts

Postby Indigo Dragon » 08 Sep 2017, 11:46

Indigo Dragon wrote:Bushido N (Devoted Retainer)
Cascade (Shardless Agent, Bituminous Blast)*
Conspire (Gleeful Sabotage) (Also: See if Wort, the Raidmother can be improved)
Cumulative upkeep {Cost} (Uktabi Efreet)
Delve (Gurmag Angler, Treasure Cruise)
Devoid (Vestige of Emrakul, Reality Hemorrahage)
D1redge N (Greater Mossdog, Life from the Loan)*
Epic (Enduring Ideal)
Flashback {Cost} (Think Twice)*
Poisonous N (Snake Cult Initiation)*
Prowess (Nimble-Blade Khenra) (Evergreen Keyword)
Rampage N (Wolverine Pack)
Ripple N (Surging Sentinels, Surging Aether) (Also: See if Thrumming Stone can be improved)
Split second (Krosan Grip, Qaugnoth)
Sunburst (Suntouched Myr, Clearwater Goblet) (Possible weird interaction with Arcbound Wanderer)
Totem armor (Eland Umbra)

Other odd keywords;
Hideaway (Shelldock Isle) (Oh boy)
Replicate {Cost} (Train of Thought) (Needs to change the barebones "Replicate 1 U " to "Replicate {1} {U} ")
U1nearth {Cost} (Dregscape Zombie) (Similar to Devour, This has a colon at the end as if it is an activated ability "Un1earth {B}: ( {B} : Return...)")
Cumulative upkeep {Cost} (Uktabi Efreet)
Ripple N (Surging Sentinels, Surging Aether) (Also: See if Thrumming Stone can be improved)
Sunburst (Suntouched Myr, Clearwater Goblet) (Possible weird interaction with Arcbound Wanderer)
Hideaway (Shelldock Isle) (Oh boy)
Replicate {Cost} (Train of Thought) ("Replicate 1 U " to "Replicate {1} {U}")
U1nearth {Cost} (Dregscape Zombie) ("Unearth {B}:" to "Unearth {B}")

Flashback - Flashback now works, especially with em Dashes. I'll be looking at other keywords that alternate between mana costs and non-mana cost em Dashes
Buyback (Slaughter)
Cumulative upkeep (Gallowbraid)
Cycling (Street Wraith, Edge of Autumn)
Echo (Deepcavern Imp, Skizzik Surger)
Equip (Nightmare Lash)
Eternalize (Sunscourge Champion, Sinuous Striker)
Kicker (Phyrexian Scuta)
Morph (Zombie Cutthroat)
Splice onto Arcane (Roar of Jukai)

And Cascade - I'll take a gander at Yidris, Maelstrom Wielder and Maelstrom Nexus.
Ctrl+C, Ctrl+V
User avatar
Indigo Dragon
 
Posts: 130
Joined: 11 May 2016, 10:18
Location: Australia
Has thanked: 62 times
Been thanked: 56 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 6 guests


Who is online

In total there are 6 users online :: 0 registered, 0 hidden and 6 guests (based on users active over the past 10 minutes)
Most users ever online was 279 on 11 Jul 2013, 22:03

Users browsing this forum: No registered users and 6 guests

Login Form