It is currently 16 Apr 2024, 16:39
   
Text Size

Rivals of Ixalan Spoiler Season

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 07 Jan 2018, 07:26

Added Jadelight Ranger, Deeproot Elite, Polyraptor and Forerunner of the Heralds

That's all the non-Ascend Green done I believe
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 07 Jan 2018, 14:50

I'm going to script some of the remaining gold cards today if I can, starting with Zacama

- only managed Zacama for now - that is tested and committed, but I got stuck on Protean Raider
-added Siegehorn Ceratops too
Last edited by austinio7116 on 07 Jan 2018, 15:59, edited 2 times in total.
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Rivals of Ixalan Spoiler Season

Postby Marek14 » 07 Jan 2018, 14:53

I'm now working on black cards.

Skipping Ascend cards: Dusk Charger, Golden Demise, Mausoleum Harpy, Twilight Prophet, Vona's Hunger

Dead Man's Chest -- a Frankenstein mess of several cards to put together the complicated effect, will probably need extensive testing.

Tetzimoc, Primal Death -- I noticed that the reveal cost is not actually written out on Forecast cards, so I omitted it here as well -- I rpesume the card would be revealed automatically when activated anyway?

Implemented: Arterial Flow, Canal Monitor, Champion of Dusk, Dark Inquiry, Dead Man's Chest (check), Dinosaur Hunter, Dire Fleet Poisoner, Fathom Fleet Boarder, Forerunner of the Coalition, Grasping Scoundrel, Gruesome Fate, Impale, Mastermind's Acquisition, Moment of Craving, Oathsworn Vampire, Pitiless Plunderer, Reaver Ambush, Sadistic Skymarcher, Tetzimoc, Primal Death, Tomb Robber, Vampire Revenant, Voracious Vampire.
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Rivals of Ixalan Spoiler Season

Postby Marek14 » 07 Jan 2018, 16:36

Red:

Blood Sun - will probably need a way to lose all abilities except mana abilities.
Mutiny - I couldn't find a check to ensure that the two targeted creatures have the same controller. Alpha Brawl, which SHOULD have something like that, doesn't.
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Rivals of Ixalan Spoiler Season

Postby Marek14 » 08 Jan 2018, 09:19

I did all red/gold/artifact cards I could (and that weren't already taken), but I'm having serious problems with getting GitLab to accept some of those. Gotta keep trying.

Is Zacama done?
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 08 Jan 2018, 09:37

Yes, it's in the master, but I have noted a slight issue with the "if cast" part of the rules that I am discussing on discord
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 08 Jan 2018, 09:39

With gitlab, just keep trying, it seems to be an intermittent issue
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Rivals of Ixalan Spoiler Season

Postby Agetian » 08 Jan 2018, 13:05

I think Ascend is in the code base now (check the implementation of Tendershoot Dryad for an example).

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Rivals of Ixalan Spoiler Season

Postby swordshine » 08 Jan 2018, 13:35

Hi, Marek! I closed the your merge requests in my fork. I looks like you need to fork the project https://git.cardforge.org/core-developers/forge/forks
swordshine
 
Posts: 682
Joined: 11 Jul 2010, 02:37
Has thanked: 116 times
Been thanked: 87 times

Re: Rivals of Ixalan Spoiler Season

Postby Marek14 » 08 Jan 2018, 14:15

swordshine wrote:Hi, Marek! I closed the your merge requests in my fork. I looks like you need to fork the project https://git.cardforge.org/core-developers/forge/forks
No, I have my own fork... it's just that your fork appears as default for merging for some reason.
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Rivals of Ixalan Spoiler Season

Postby Agetian » 08 Jan 2018, 14:50

Marek14 wrote:
swordshine wrote:Hi, Marek! I closed the your merge requests in my fork. I looks like you need to fork the project https://git.cardforge.org/core-developers/forge/forks
No, I have my own fork... it's just that your fork appears as default for merging for some reason.
Ohhh, I think it may be because you forked Swordshine's fork (yeah, it's actually possible to do things like that) instead of forking the actual upstream Master... You'd need to fork this particular repo -> https://git.cardforge.org/core-developers/forge
I'd suggest the following course of action:

1. Try to submit a merge request to upstream Master (you were able to do that previously, so you should be able to do it now, at least that's the hope).
2. Once everything is in (I'll tell you here once I integrate it), you can then start a new fork from Master, and once you get everything working, you can then delete the first fork you made (from Swordshine's fork).

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Rivals of Ixalan Spoiler Season

Postby Marek14 » 08 Jan 2018, 14:55

I will try that, but I still have a lot of reloading to do before all my cards get through.
Marek14
Tester
 
Posts: 2759
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 296 times

Re: Rivals of Ixalan Spoiler Season

Postby Agetian » 08 Jan 2018, 14:58

Marek14 wrote:I will try that, but I still have a lot of reloading to do before all my cards get through.
Yeah, I'm not sure what's up with the lag... :/ I also have to reload a few times to get a merge through.

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 08 Jan 2018, 14:58

Is it even possible to submit a merge request from one fork to another using the gitlab UI, or does it require commandline git?
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

Re: Rivals of Ixalan Spoiler Season

Postby austinio7116 » 08 Jan 2018, 14:59

Is Krazy the only one with access to the git server (do we even have root access with the hosting?) to see what's going on with the performance?
User avatar
austinio7116
 
Posts: 451
Joined: 10 Mar 2017, 11:59
Has thanked: 47 times
Been thanked: 169 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 34 guests


Who is online

In total there are 34 users online :: 0 registered, 0 hidden and 34 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 34 guests

Login Form