Rivals of Ixalan Spoiler Season
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Rivals of Ixalan Spoiler Season
by austinio7116 » 04 Jan 2018, 20:59
- ravenous_chupacabra.txt | Open
- Code: Select all
Name:Ravenous Chupacabra
ManaCost:2 B B
Types:Creature Beast Horror
PT:2/2
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigDestroy | TriggerDescription$ When CARDNAME enters the battlefield, destroy target creature an opponent controls.
SVar:TrigDestroy:DB$Destroy | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls.
SVar:PlayMain1:TRUE
SVar:Picture:http://www.wizards.com/global/images/magic/general/ravenous_chupacabra.jpg
Oracle:When Ravenous Chupacabra enters the battlefield, destroy target creature an opponent controls.
-
austinio7116 - Posts: 451
- Joined: 10 Mar 2017, 11:59
- Has thanked: 47 times
- Been thanked: 169 times
Re: Rivals of Ixalan Spoiler Season
by friarsol » 04 Jan 2018, 21:58
The problem with this way is that it still took a lot of manual effort for the development team to collate and commit cards. Now anyone is able to attempt to merge cards, and anyone can eyeball them and reject or approve without needing to be at their codebase.ShivaFang wrote:I kinda preferred the old way where I could copy the scripts as soon as people posted them, without having to wait for the 'official' update.
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Rivals of Ixalan Spoiler Season
by ShivaFang » 05 Jan 2018, 00:21
I saw that, but it wasn't working either. I see that I had Local Branches and Remote Branches - and I had figured out that the remote branches were the ones that should have pointed to the full project.austinio7116 wrote:Git takes a bit of getting used to, but once you are comfortable with it it is just as easy as SVN but more powerful. In IntelliJ, I use the drop down branch menu in the bottom right to switch or create branches, it tells you which branch you are on there too. Then I just use the commit/update menu options in the VCS menu. Hopefully you changes are not lost if you check branches (and perhaps the IntelliJ local history too). There are many ways to do these things though and I too am more familiar with SVN.
Doesn't matter - I figured it out. I downloaded SourceTree and made sure I pointed to the full project (which I now know is called the 'upstream') when I submitted a pull request so all is good.
Oh I get that - and now that I have it working I can see how this streamlines your process (I like seeing all the branches and updates in the history - one of the things about git that appealed to me when I looked at it before when I was working with a parner on a game for Ludum Dare)The problem with this way is that it still took a lot of manual effort for the development team to collate and commit cards. Now anyone is able to attempt to merge cards, and anyone can eyeball them and reject or approve without needing to be at their codebase.
I was just railing because I resist change and when I have something working well for me that suddenly doesn't - I get a bit testy =Z. Sorry for that.
Re: Rivals of Ixalan Spoiler Season
by Marek14 » 05 Jan 2018, 06:36
I will try to code some cards, but since the full spoiler is probably going up today, I'm going to wait for it
Re: Rivals of Ixalan Spoiler Season
by Agetian » 05 Jan 2018, 10:46
Very nice! Best of luck, Marek, glad to have you on board for the spoiler season, as always!Marek14 wrote:I will try to code some cards, but since the full spoiler is probably going up today, I'm going to wait for it
Feel free to experiment with our new Git system, you should be able to submit cards directly to Git now (your own fork, then request merge with the master branch) without needing any special commit permissions like on the old SVN system.
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Re: Rivals of Ixalan Spoiler Season
by austinio7116 » 05 Jan 2018, 17:54
Looks like we're on..Marek14 wrote:I will try to code some cards, but since the full spoiler is probably going up today, I'm going to wait for it
https://magic.wizards.com/en/articles/a ... -of-ixalan
-
austinio7116 - Posts: 451
- Joined: 10 Mar 2017, 11:59
- Has thanked: 47 times
- Been thanked: 169 times
Re: Rivals of Ixalan Spoiler Season
by Marek14 » 05 Jan 2018, 18:57
Started, working on white cards...
EDIT: Not sure if I will find more time today; added 9 cards so far: Baffling End, Bishop of Binding, Blazing Hope, Cleansing Ray, Everdawn Champion, Exultant Skymarcher, Famished Paladin, Forerunner of the Legion and Imperial Ceratops.
EDIT: Not sure if I will find more time today; added 9 cards so far: Baffling End, Bishop of Binding, Blazing Hope, Cleansing Ray, Everdawn Champion, Exultant Skymarcher, Famished Paladin, Forerunner of the Legion and Imperial Ceratops.
Re: Rivals of Ixalan Spoiler Season
by austinio7116 » 05 Jan 2018, 19:46
I'll upload these to git and generate a merge requesttorridus wrote:Some of today's official spoilers. All are untested, but they're pretty basic on the code level, so I don't imagine any issues will crop up.
Edit: Merge request submitted for these 4 posted above by torridus.
-
austinio7116 - Posts: 451
- Joined: 10 Mar 2017, 11:59
- Has thanked: 47 times
- Been thanked: 169 times
Re: Rivals of Ixalan Spoiler Season
by Marek14 » 05 Jan 2018, 23:35
I corrected a bunch of cards that interact with their copies -- some of them used "CARDNAME" in construction "cards named XXX", which is incorrect. Probably doesn't matter for spells, but does for creatures -- Sakashima the Impostor copying Squadron Hawk should still display that he will search for cards named "Squadron Hawk" even if it's not HIS name.
Re: Rivals of Ixalan Spoiler Season
by Agetian » 06 Jan 2018, 06:00
Hmm, it looks like you're requesting to merge it all with Swordshine's fork instead of with the master branch... You should request a merge with "core-developers/master" (specifically, with this repo: https://git.cardforge.org/core-developers/forge )Marek14 wrote:I corrected a bunch of cards that interact with their copies -- some of them used "CARDNAME" in construction "cards named XXX", which is incorrect. Probably doesn't matter for spells, but does for creatures -- Sakashima the Impostor copying Squadron Hawk should still display that he will search for cards named "Squadron Hawk" even if it's not HIS name.
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Re: Rivals of Ixalan Spoiler Season
by Marek14 » 06 Jan 2018, 06:16
ah, sorry. I'm still learning to work with that system.
Re: Rivals of Ixalan Spoiler Season
by Agetian » 06 Jan 2018, 06:19
Hehe, no worries - me too, actually Feel free to ask questions if you have any issues (here or on our Discord) - we're also still kinda working out the kinks and learning to use the system to maximum efficiencyMarek14 wrote:ah, sorry. I'm still learning to work with that system.
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Re: Rivals of Ixalan Spoiler Season
by Agetian » 06 Jan 2018, 06:53
Btw, it looks like there's no way for me to retarget or at least "import" your merge request to core-developers, so feel free to submit a new merge request (to core master) when you have some time (with those cards you already made and fixed).
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Re: Rivals of Ixalan Spoiler Season
by Marek14 » 06 Jan 2018, 07:01
ok, I'm working on more atm.
How are we with Ascend mechanic? This mechanic is weird that it works as a normal keyword on permanents, but more like a keyword action on spells, so I guess we need:
1. Ascend keyword for permanents, which will constantly update and give you city's blessing when you gave 10 or more permanents. If you have city's blessing, this keyword won't do anything anymore.
2. Ascend ability type, which will perform a one-time check.
3. Condition to check if a player has city's blessing.
How are we with Ascend mechanic? This mechanic is weird that it works as a normal keyword on permanents, but more like a keyword action on spells, so I guess we need:
1. Ascend keyword for permanents, which will constantly update and give you city's blessing when you gave 10 or more permanents. If you have city's blessing, this keyword won't do anything anymore.
2. Ascend ability type, which will perform a one-time check.
3. Condition to check if a player has city's blessing.
Re: Rivals of Ixalan Spoiler Season
by Agetian » 06 Jan 2018, 07:11
Ascend - Hanmac said he's working on it and it should be ready this weekend (unless plans change for some reason)
- Agetian
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Who is online
Users browsing this forum: No registered users and 97 guests