It is currently 27 Apr 2024, 07:12
   
Text Size

tap: add {} to your mana pool for each {} on the ...

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

tap: add {} to your mana pool for each {} on the ...

Postby Chris H. » 30 Jan 2010, 19:19

I found several cards that can use the new "tap: add {ManaSymbol} to your mana pool for each {Type} {on the battlefield / you control}." keyword. All but two would need additional coding. So I added the two below:

Code: Select all
Cloudpost
no cost
Land Locus
no text
Comes into play tapped.
tap: add 1 to your mana pool for each Locus on the battlefield.

Rofellos, Llanowar Emissary
G G
Legendary Creature Elf Druid
no text
2/1
tap: add G to your mana pool for each Forest you control.
`
The elf is good to go. Cloudpost does not add mana to the pool. I have been fairly busy and have not had a chance to dig through the code. From my tests it appears that this new keyword does not handle colorless mana. When I exchanged the "1" with a "W" the card added white mana to the mana pool.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: tap: add {} to your mana pool for each {} on the ...

Postby DennisBergkamp » 30 Jan 2010, 19:55

Ahh, I see... yeah I did not take that into account. I'll add in colorless mana as well.
User avatar
DennisBergkamp
AI Programmer
 
Posts: 2602
Joined: 09 Sep 2008, 15:46
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby zerker2000 » 30 Jan 2010, 21:40

Wait a moment: would Cloudpost count creatures with changeling, perchance?
O forest, hold thy wand'ring son
Though fears assail the door.
O foliage, cloak thy ravaged one
In vestments cut for war.


--Eladamri, the Seed of Freyalise
zerker2000
Programmer
 
Posts: 569
Joined: 09 May 2009, 21:40
Location: South Pasadena, CA
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby DennisBergkamp » 30 Jan 2010, 22:07

Ugh, yes I think it would :( Which is not correct.
User avatar
DennisBergkamp
AI Programmer
 
Posts: 2602
Joined: 09 Sep 2008, 15:46
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby zerker2000 » 30 Jan 2010, 22:17

Should there be a big creature type list in properties? It can be pasted off of comp rules easily:
Code: Select all
204.3k Creatures and tribals share their lists of subtypes; these subtypes are called creature types. The creature types are Advisor, Ally, Angel, Anteater, Antelope, Ape, Archer, Archon, Artificer, Assassin, Assembly-Worker, Atog, Aurochs, Avatar, Badger, Barbarian, Basilisk, Bat, Bear, Beast, Beeble, Berserker, Bird, Blinkmoth, Boar, Bringer, Brushwagg, Camarid, Camel, Caribou, Carrier, Cat, Centaur, Cephalid, Chimera, Citizen, Cleric, Cockatrice, Construct, Coward, Crab, Crocodile, Cyclops, Dauthi, Demon, Deserter, Devil, Djinn, Dragon, Drake, Dreadnought, Drone, Druid, Dryad, Dwarf, Efreet, Egg, Elder, Elemental, Elephant, Elf, Elk, Eye, Faerie, Ferret, Fish, Flagbearer, Fox, Frog, Fungus, Gargoyle, Giant, Gnome, Goat, Goblin, Golem, Gorgon, Graveborn, Griffin, Hag, Harpy, Hellion, Hippo, Homarid, Homunculus, Horror, Horse, Hound, Human, Hydra, Hyena, Illusion, Imp, Incarnation, Insect, Jellyfish, Juggernaut, Kavu, Kirin, Kithkin, Knight, Kobold, Kor, Kraken, Lammasu, Leech, Leviathan, Lhurgoyf, Licid, Lizard, Manticore, Masticore, Mercenary, Merfolk, Metathran, Minion, Minotaur, Monger, Mongoose, Monk, Moonfolk, Mutant, Myr, Mystic, Nautilus, Nephilim, Nightmare, Nightstalker, Ninja, Noggle, Nomad, Octopus, Ogre, Ooze, Orb, Orc, Orgg, Ouphe, Ox, Oyster, Pegasus, Pentavite, Pest, Phelddagrif, Phoenix, Pincher, Pirate, Plant, Prism, Rabbit, Rat, Rebel, Reflection, Rhino, Rigger, Rogue, Salamander, Samurai, Sand, Saproling, Satyr, Scarecrow, Scorpion, Scout, Serf, Serpent, Shade, Shaman, Shapeshifter, Sheep, Siren, Skeleton, Slith, Sliver, Slug, Snake, Soldier, Soltari, Spawn, Specter, Spellshaper, Sphinx, Spider, Spike, Spirit, Splinter, Sponge, Squid, Squirrel, Starfish, Surrakar, Survivor, Tetravite, Thalakos, Thopter, Thrull, Treefolk, Triskelavite, Troll, Turtle, Unicorn, Vampire, Vedalken, Viashino, Volver, Wall, Warrior, Weird, Whale, Wizard, Wolf, Wolverine, Wombat, Worm, Wraith, Wurm, Yeti, Zombie, and Zubera.
O forest, hold thy wand'ring son
Though fears assail the door.
O foliage, cloak thy ravaged one
In vestments cut for war.


--Eladamri, the Seed of Freyalise
zerker2000
Programmer
 
Posts: 569
Joined: 09 May 2009, 21:40
Location: South Pasadena, CA
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby Incantus » 31 Jan 2010, 00:25

DennisBergkamp wrote:Ugh, yes I think it would :( Which is not correct.
Actually, that is correct. So you're all good.
Incantus
DEVELOPER
 
Posts: 267
Joined: 29 May 2008, 15:53
Has thanked: 0 time
Been thanked: 3 times

Re: tap: add {} to your mana pool for each {} on the ...

Postby zerker2000 » 31 Jan 2010, 01:04

Locus is a land type, not a creature type. Incorrect.
O forest, hold thy wand'ring son
Though fears assail the door.
O foliage, cloak thy ravaged one
In vestments cut for war.


--Eladamri, the Seed of Freyalise
zerker2000
Programmer
 
Posts: 569
Joined: 09 May 2009, 21:40
Location: South Pasadena, CA
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby DennisBergkamp » 31 Jan 2010, 01:05

No I don't think so, since it's not a creature type:

http://forums.mtgsalvation.com/showthread.php?t=214171
User avatar
DennisBergkamp
AI Programmer
 
Posts: 2602
Joined: 09 Sep 2008, 15:46
Has thanked: 0 time
Been thanked: 0 time

Re: tap: add {} to your mana pool for each {} on the ...

Postby Rob Cashwalker » 31 Jan 2010, 01:43

The solution is simple - make sure that your "for each {type} in play" can support two more than one type at a time... like "Land Locus".
The Force will be with you, Always.
User avatar
Rob Cashwalker
Programmer
 
Posts: 2167
Joined: 09 Sep 2008, 15:09
Location: New York
Has thanked: 5 times
Been thanked: 40 times

Re: tap: add {} to your mana pool for each {} on the ...

Postby Marek14 » 31 Jan 2010, 06:23

Rob Cashwalker wrote:The solution is simple - make sure that your "for each {type} in play" can support two more than one type at a time... like "Land Locus".
Well, wouldn't it still affect changelings with Life or Limb in play? :)
Marek14
Tester
 
Posts: 2761
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 297 times

Re: tap: add {} to your mana pool for each {} on the ...

Postby zerker2000 » 31 Jan 2010, 09:17

It's Life and Limb :). Anyways, I do think that following comp rules on this is worthwhile, i.e. "Changeling" = "This object is every creature type.", i.e. have "every creature type" listed in the properties file. This would also make "choose a creature type" more rules-compliant, as the prompt could actually check for the type's existence(more ideas: popup list of all creature types in menu/aforementioned prompt/deck editor/filters; auto-update list when parsing cards.txt and the token file).
O forest, hold thy wand'ring son
Though fears assail the door.
O foliage, cloak thy ravaged one
In vestments cut for war.


--Eladamri, the Seed of Freyalise
zerker2000
Programmer
 
Posts: 569
Joined: 09 May 2009, 21:40
Location: South Pasadena, CA
Has thanked: 0 time
Been thanked: 0 time


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 89 guests


Who is online

In total there are 89 users online :: 0 registered, 0 hidden and 89 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 89 guests

Login Form