Page 4 of 4

Re: eqPump (was VanillaEquipment) keyword

PostPosted: 11 Apr 2010, 17:59
by DennisBergkamp
No problems, Jim :) I don't think it was just you, I overwrote a bunch of changes as well.

Re: eqPump (was VanillaEquipment) keyword

PostPosted: 11 Apr 2010, 19:12
by Chris H.
I checked my notes for the last several months and found just 4 more cards.txt entries to fix. I will move my fixes to the top of the file. We can try it this way for a while and see if it makes it easier on all of us to see the changes. :D

Re: eqPump (was VanillaEquipment) keyword

PostPosted: 12 Apr 2010, 03:10
by Rob Cashwalker
I get <<<< and >>>> all the time in lots of files, including cards.txt and the .classpath. It sucks in .classpath, because it doesn't appear on the tree. It has to be fixed manually.

Eclipse can easily merge differences in the code, but it doesn't handle the cards.txt at all, and manual fixes are prone to these sorts of errors. Maybe a "replace from repository" for cards.txt is better than "update to head". Then paste the new card text at the top and then commit.

Re: eqPump (was VanillaEquipment) keyword

PostPosted: 12 Apr 2010, 09:48
by jim
Rob Cashwalker wrote:Eclipse can easily merge differences in the code, but it doesn't handle the cards.txt at all, and manual fixes are prone to these sorts of errors. Maybe a "replace from repository" for cards.txt is better than "update to head". Then paste the new card text at the top and then commit.
I agree, that sounds like a better idea. I was also thinking, in terms of your previous suggestion of submitting files separately, that I would submit cards.txt separately from other changes. I'll try doing both these things from now on.

Ironically, for my next submission I don't have to touch cards.txt anyway. :|