GameActionUtil.java indentation

Posted:
10 Apr 2010, 22:21
by slapshot5
Hi all,
The indentation of GameActionUtil.java for me in Eclipse is all screwed up. See screenshot.

Am I the only one seeing this? I just Ctrl+A then Source > Correct Indentation in Eclipse.
If others are seeing this, perhaps doing the above actions and checking it in would fix this?
Thanks,
slapshot5
Re: GameActionUtil.java indentation

Posted:
10 Apr 2010, 22:27
by DennisBergkamp
Yeah, this happened because Silly Freak's Eclipse messed with it

I'll fix it using your suggestion, and commit the changes.
Re: GameActionUtil.java indentation

Posted:
11 Apr 2010, 01:51
by Rob Cashwalker
It's funny... what one person calls "correct indentation" isn't what others would consider "correct".
Re: GameActionUtil.java indentation

Posted:
11 Apr 2010, 11:36
by silly freak
I of course consider it correct^^ no, the reason for this is that I have configured my eclipse to format source code automatically on a save. It looks good most of the time, but unfortunately often not for anonymous classes... sorry, i'll see if I can tweak my formatter settings

Re: GameActionUtil.java indentation

Posted:
12 Apr 2010, 03:20
by Rob Cashwalker
Right, but it's more comical that Eclipse has a function called "Correct Indentation", but of course it's really just following your personal preferences. Since Eclipse has no way to import preferences, then what if you were to need to switch your formatting to follow a company policy for standard formatting?
Most open source projects have a formatting policy and naming conventions outlined in the documentation. Granted, we're not like most open source projects, but you can understand why they do....
Re: GameActionUtil.java indentation

Posted:
12 Apr 2010, 05:55
by silly freak
actually, you can import/export preferences, though I wished it was more uniform. the Formatting can be exported from the formatter page, but not via File/Export...