Page 2 of 14

Re: Keywords recognized by Forge

PostPosted: 25 May 2010, 13:43
by Snacko
Those are 2 different ones one shuffles only the card the other shuffles your whole graveyard. This makes a whole difference!

Re: Keywords recognized by Forge

PostPosted: 25 May 2010, 14:16
by Chris H.
Snacko wrote:Those are 2 different ones one shuffles only the card the other shuffles your whole graveyard. This makes a whole difference!
`
Sorry about that Snacko, another new keyword is always a good thing. :D



I was mistaken about the last keyword change. Instead, we have a new keyword that is similar but slightly different. As such, both of these keyword forms work:


When CARDNAME is put into a graveyard from anywhere, reveal CARDNAME and shuffle it into its owner's library instead.

When CARDNAME is put into a graveyard from anywhere, reveal CARDNAME and its owner shuffles his or her graveyard into his or her library.

Re: Keywords recognized by Forge

PostPosted: 27 May 2010, 15:02
by Chris H.
Another keyword has changed:

"This creature can block only creatures with flying."

keyword to

"CARDNAME can block only creatures with flying."


Changes appear in Rev. 1129

Re: Keywords recognized by Forge

PostPosted: 27 May 2010, 22:49
by Chris H.
Another keyword has changed:

"This creature can block creatures with shadow as though they didn't have shadow."

keyword to

"CARDNAME can block creatures with shadow as though they didn't have shadow."


Changes appear in Rev. 1130

Re: Keywords recognized by Forge

PostPosted: 28 May 2010, 14:18
by Chris H.
Another keyword has changed:

"This creature can block as though it had flying."

keyword to

"CARDNAME can block creatures with flying."


Changes appear in Rev. 1131


Note: I suspect that it may be best for us all to use the shorter "Reach" keyword in the future. :)

Re: Keywords recognized by Forge

PostPosted: 29 May 2010, 12:32
by Chris H.
Another keyword has changed:

"This card can't be the target of spells or abilities your opponents control."

keyword to

"CARDNAME can't be the target of spells or abilities your opponents control."


Changes appear in Rev. 1135

Re: Keywords recognized by Forge

PostPosted: 29 May 2010, 23:33
by Chris H.
Another keyword has changed:

"This card can't be the target of Aura spells."

keyword to

"CARDNAME can't be the target of Aura spells."


Changes appear in Rev. 1137

Re: Keywords recognized by Forge

PostPosted: 30 May 2010, 12:14
by Chris H.
Another keyword has changed:

"Remove three spore counters from this card: Put a 1/1 green Saproling creature token into play."

keyword to

"Remove three spore counters from CARDNAME: Put a 1/1 green Saproling creature token onto the battlefield."


Changes appear in Rev. 1138

Re: Keywords recognized by Forge

PostPosted: 31 May 2010, 01:48
by Chris H.
I discovered that the keyword:

"At the beginning of the end step, sacrifice {card name}."

is already updated to the newer form:

"At the beginning of the end step, sacrifice CARDNAME."

I only had to update the keyword listing.

Re: Keywords recognized by Forge

PostPosted: 31 May 2010, 15:39
by Chris H.
While I have the mop and bucket out I checked the code for the keyword:

Code: Select all
At the beginning of your upkeep, sacrifice
`
and I discovered that the code will handle either form of the keyword:

Code: Select all
At the beginning of your upkeep, sacrifice {+ c.getName()}
At the beginning of your upkeep, sacrifice CARDNAME
`
So there is no need to adjust the code base. Both forms of the keyword appear in the cards.txt file so I changed the older form to the newer CARDNAME form (for consistency) and moved these to the top of file.


Changes appear in Rev. r1150

Re: Keywords recognized by Forge

PostPosted: 31 May 2010, 21:26
by Chris H.
I would like to thank Sloth for investigating the keyword:

Code: Select all
1, Sacrifice CARDNAME: Draw a card.
`
I did not need to change any coding, instead I edited the keyword listing.


And, BTW: It is good to hear from you again Sloth. It has been a while. Hope you are doing fine. :D

Re: Keywords recognized by Forge

PostPosted: 01 Jun 2010, 01:24
by Chris H.
The keyword:

Code: Select all
At the beginning of your upkeep, destroy CARDNAME unless you pay:{cost}
`
does not require any code or cards.txt changes. I only had to update the keyword listing.

Re: Keywords recognized by Forge

PostPosted: 01 Jun 2010, 18:05
by Chris H.
I think there is only one keyword left to convert from the actual card name to CARDNAME. And that keyword is at the top of the list:

Code: Select all
{cardName} is {color}
`
It appears that some changes were made to sections of the code and this keyword is now not functional. I am not sure if I will be able to figure out how to get this keyword working again. :(

Re: Keywords recognized by Forge

PostPosted: 02 Jun 2010, 01:34
by Chris H.
I found the code for c.getName " is " color keyword and made two small adjustments to make it handle the new CARDNAME form. I also changed the cards.txt entry for these cards and moved them to top of file:

Crimson Kobolds
Crookshank Kobolds
Ghostfire
Kobolds of Kher Keep
Transguild Courier

The keyword now works as long as the CARDNAME form is used. Shrug. But at least it works. The card border color for all but Transguild Courier is wrong. This will have to be changed elsewhere.

Changes appear in Rev. 1154

Re: Keywords recognized by Forge

PostPosted: 02 Jun 2010, 13:24
by Chris H.
I found the getBorder() code located in GuiDisplayUtil and I added some checks and the proper border color is now displayed in the deck editor and in the game window. Kobolds now have a red border and Ghostfire now has a gray border.

Zerker's card is color keyword should now be fully functional.

Changes appear in Rev. 1158