Page 1 of 1

Uninterrupted picture downloading

PostPosted: 19 Jul 2010, 09:15
by Void
Hi

I want to help you with the project. I have never programmed in Java, but I have used JavaScript a bit.

First thing I would like to improve is picture downloading. Currently there are tens of unobtainable pictures, and every one of them makes a dialog pop-up with error and asks if I want to continue.
I think a better idea is to continue with downloading the remaining pictures from the list and the error should be printed only to standard output. That way I will be able to go for a coffee and have all the possible pictures when I am back to the PC.

Right now all public methods of ErrorViewer class leads to showDialog() function call.
I propose a solution with another methods beside showError, for example suppressError, which behaves the same, but doesn't pop-up a dialog.

Re: Uninterrupted picture downloading

PostPosted: 19 Jul 2010, 17:18
by mtgrares
Yeah I coded the picture download function at the beginning. It stops on errors instead of continuing, so the only thing that needs to be changed in the "error handling" strategy. Which should be "download as many pictures as you can" instead of "stopping when you can't download 1 picture."

That is why I try to create a zip file with all of the card pictures, here.

Re: Uninterrupted picture downloading

PostPosted: 19 Jul 2010, 17:43
by Void
mtgrares wrote:It stops on errors instead of continuing, so the only thing that needs to be changed in the "error handling" strategy.
Exactly. I have prepared a modification, but today someone was thinking about the same and already fixed it (thank you).
I wasn't aware of Log class, as I haven't checked them all yet.