Resource leak in VCardDisplayArea?
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Resource leak in VCardDisplayArea?
by thomek » 19 Apr 2020, 18:32
Hi,
VCardDisplayArea has the inner class CardAreaPanel.
Its static member allCardPanels is filled by the 'get' method.
If running an endless loop of AI battle matches, it looks like allCardPanels keeps growing.
CardAreaPanel includes the cleanup method resetForNewGame.
But there is no reference to that method (master/2020-04-12).
Thanks,
thomek
VCardDisplayArea has the inner class CardAreaPanel.
Its static member allCardPanels is filled by the 'get' method.
If running an endless loop of AI battle matches, it looks like allCardPanels keeps growing.
CardAreaPanel includes the cleanup method resetForNewGame.
But there is no reference to that method (master/2020-04-12).
Thanks,
thomek
Re: Resource leak in VCardDisplayArea?
by friarsol » 20 Apr 2020, 00:31
Hey Thomek,
It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path. Since there might be some overlap between Mobile and Desktop files.
https://git.cardforge.org/core-developers/forge/issues
It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path. Since there might be some overlap between Mobile and Desktop files.
https://git.cardforge.org/core-developers/forge/issues
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Resource leak in VCardDisplayArea?
by kevlahnota » 20 Apr 2020, 01:33
I think thomek was referring to mobile port version, I just found it that the resetfornewgame() is not called.
-
kevlahnota - Programmer
- Posts: 825
- Joined: 19 Jul 2010, 17:45
- Location: Philippines
- Has thanked: 14 times
- Been thanked: 264 times
Re: Resource leak in VCardDisplayArea?
by thomek » 20 Apr 2020, 09:37
Sure, here you go: #1367friarsol wrote:It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path.
(No link, too spamy for a new user).
4 posts
• Page 1 of 1
Who is online
Users browsing this forum: No registered users and 42 guests