It is currently 16 Apr 2024, 15:07
   
Text Size

Resource leak in VCardDisplayArea?

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Resource leak in VCardDisplayArea?

Postby thomek » 19 Apr 2020, 18:32

Hi,

VCardDisplayArea has the inner class CardAreaPanel.
Its static member allCardPanels is filled by the 'get' method.

If running an endless loop of AI battle matches, it looks like allCardPanels keeps growing.

CardAreaPanel includes the cleanup method resetForNewGame.
But there is no reference to that method (master/2020-04-12).

Thanks,
thomek
thomek
 
Posts: 7
Joined: 18 Apr 2020, 10:39
Has thanked: 0 time
Been thanked: 2 times

Re: Resource leak in VCardDisplayArea?

Postby friarsol » 20 Apr 2020, 00:31

Hey Thomek,

It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path. Since there might be some overlap between Mobile and Desktop files.
https://git.cardforge.org/core-developers/forge/issues
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Resource leak in VCardDisplayArea?

Postby kevlahnota » 20 Apr 2020, 01:33

I think thomek was referring to mobile port version, I just found it that the resetfornewgame() is not called.
User avatar
kevlahnota
Programmer
 
Posts: 825
Joined: 19 Jul 2010, 17:45
Location: Philippines
Has thanked: 14 times
Been thanked: 264 times

Re: Resource leak in VCardDisplayArea?

Postby thomek » 20 Apr 2020, 09:37

friarsol wrote:It would probably be more useful to create issues on our git for these leaks you are noticing, and maybe provide the full path.
Sure, here you go: #1367
(No link, too spamy for a new user).
thomek
 
Posts: 7
Joined: 18 Apr 2020, 10:39
Has thanked: 0 time
Been thanked: 2 times


Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 51 guests


Who is online

In total there are 51 users online :: 0 registered, 0 hidden and 51 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 51 guests

Login Form